Skip to content

feat(remote-config)!: add AsmRawResponseBody capability #2278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gh-worker-dd-mergequeue-cf854d merged 1 commit into from
Jul 28, 2026
Merged

feat(remote-config)!: add AsmRawResponseBody capability #2278

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions libdd-remote-config/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ impl Target {
strum_macros::IntoStaticStr,
strum_macros::Display,
)]
#[non_exhaustive]

@estringana estringana Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this to fix the semver-check CI failure

@yannham yannham Jul 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the issue was rather the title (misplaced !), right? It's ok to have breaking changes, the CI just enforces that the title matches. Also I believe adding #[non_exhaustive] is technically a breaking change as well?

That being said, if this C-like enum is likely to be extended in the future, it looks like a good candidate for #[non_exhaustive]. This will make the next changes non-breaking. I'll let you decide if it's worth keeping or not (typically if this enum is expected to be very stable from now, maybe not worth it). Both options are reasonable.

#[serde(rename_all = "SCREAMING_SNAKE_CASE")]
pub enum RemoteConfigCapabilities {
AsmActivation = 1,
Expand Down Expand Up @@ -129,4 +130,5 @@ pub enum RemoteConfigCapabilities {
FfeFlagConfigurationRules = 46,
DdDataStreamsTransactionExtractors = 47,
LlmObsActivation = 48,
AsmRawResponseBody = 49,
}
Loading