Skip to content

feat(stats)!: string field length limit - #2267

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 10 commits into
mainfrom
oscarld/stats-string-length-limits
Jul 29, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 10 commits into
mainfrom
oscarld/stats-string-length-limits

Conversation

@Eldolfin

Copy link
Copy Markdown
Contributor

What does this PR do?

Implement the String length limits section of the cardinality limit RFC.

Motivation

CSS spec compliance.

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

@Eldolfin

Copy link
Copy Markdown
Contributor Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 73f237b8ac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libdd-trace-stats/src/span_concentrator/mod.rs
Comment thread libdd-data-pipeline/src/trace_exporter/stats.rs Outdated
Comment thread libdd-trace-stats/src/span_concentrator/mod.rs
@datadog-official

datadog-official Bot commented Jul 23, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 97.09%
Overall Coverage: 74.76% (+0.10%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6ade2ad | Docs | Datadog PR Page | Give us feedback!

@Eldolfin
Eldolfin marked this pull request as ready for review July 23, 2026 10:14
@Eldolfin
Eldolfin requested review from a team as code owners July 23, 2026 10:14
@Eldolfin
Eldolfin requested a review from VianneyRuhlmann July 23, 2026 10:14

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5467cd14d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread libdd-trace-stats/src/span_concentrator/mod.rs
@dd-octo-sts

dd-octo-sts Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 88.18 MB 88.18 MB +0% (+4.60 KB) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.13 MB 8.13 MB 0% (0 B) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.93 MB 10.93 MB +0% (+56 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.46 MB 99.46 MB +0% (+4.41 KB) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 26.59 MB 26.59 MB +0% (+1.00 KB) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 89.18 KB 89.18 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 191.41 MB 191.37 MB --.01% (-32.00 KB) 💪
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 1.04 GB 1.04 GB +0% (+71.30 KB) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.66 MB 8.66 MB +.01% (+1.00 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 89.18 KB 89.18 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 25.36 MB 25.36 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 50.55 MB 50.56 MB +0% (+2.82 KB) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.16 MB 23.16 MB +0% (+1.50 KB) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 90.58 KB 90.58 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 196.08 MB 196.07 MB -0% (-8.00 KB) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 1.03 GB 1.03 GB +0% (+85.69 KB) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.68 MB 6.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 90.58 KB 90.58 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 27.26 MB 27.26 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 48.13 MB 48.13 MB +0% (+2.19 KB) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 78.64 MB 78.64 MB +0% (+3.86 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.05 MB 9.05 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 94.14 MB 94.14 MB +0% (+3.75 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.02 MB 11.02 MB +.03% (+4.02 KB) 🔍

@pr-commenter

pr-commenter Bot commented Jul 23, 2026

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-07-28 13:41:21

Comparing candidate commit 6ade2ad in PR branch oscarld/stats-string-length-limits with baseline commit 95610de in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 24 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Benchmark execution time: 2026-07-28 13:38:57

Comparing candidate commit 6ade2ad in PR branch oscarld/stats-string-length-limits with baseline commit 79eff2f in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 3 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ade2ad 1785245439 oscarld/stats-string-length-limits
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
trace_buffer/1_senders/10us_delay execution_time 56.326ms 56.577ms ± 0.131ms 56.556ms ± 0.080ms 56.645ms 56.807ms 56.927ms 57.253ms 1.23% 1.178 3.166 0.23% 0.009ms 1 200
trace_buffer/1_senders/10us_delay throughput 15719.788op/s 15907.606op/s ± 36.664op/s 15913.434op/s ± 22.551op/s 15934.818op/s 15955.463op/s 15971.652op/s 15978.543op/s 0.41% -1.152 3.039 0.23% 2.593op/s 1 200
trace_buffer/1_senders/1us_delay execution_time 49.941ms 50.079ms ± 0.032ms 50.074ms ± 0.011ms 50.086ms 50.139ms 50.195ms 50.206ms 0.26% 1.103 4.864 0.06% 0.002ms 1 200
trace_buffer/1_senders/1us_delay throughput 17926.255op/s 17971.620op/s ± 11.626op/s 17973.360op/s ± 4.044op/s 17976.840op/s 17988.035op/s 17991.344op/s 18021.234op/s 0.27% -1.092 4.858 0.06% 0.822op/s 1 200
trace_buffer/1_senders/no_delay execution_time 331.521µs 340.626µs ± 5.278µs 340.253µs ± 1.910µs 342.120µs 345.495µs 354.114µs 395.499µs 16.24% 5.869 57.227 1.55% 0.373µs 1 200
trace_buffer/1_senders/no_delay throughput 2275607.471op/s 2642777.370op/s ± 37830.697op/s 2645091.938op/s ± 14835.245op/s 2660516.644op/s 2688105.614op/s 2699799.818op/s 2714757.780op/s 2.63% -4.825 43.333 1.43% 2675.034op/s 1 200
trace_buffer/2_senders/10us_delay execution_time 56.838ms 57.197ms ± 0.170ms 57.168ms ± 0.127ms 57.315ms 57.507ms 57.568ms 57.579ms 0.72% 0.280 -0.644 0.30% 0.012ms 1 200
trace_buffer/2_senders/10us_delay throughput 31261.277op/s 31470.645op/s ± 93.574op/s 31485.961op/s ± 70.025op/s 31542.450op/s 31607.382op/s 31642.396op/s 31668.907op/s 0.58% -0.269 -0.650 0.30% 6.617op/s 1 200
trace_buffer/2_senders/1us_delay execution_time 50.000ms 50.111ms ± 0.034ms 50.107ms ± 0.020ms 50.125ms 50.184ms 50.202ms 50.221ms 0.23% 0.728 1.157 0.07% 0.002ms 1 200
trace_buffer/2_senders/1us_delay throughput 35841.864op/s 35920.591op/s ± 24.508op/s 35922.995op/s ± 14.089op/s 35937.969op/s 35949.129op/s 35957.186op/s 36000.150op/s 0.21% -0.722 1.154 0.07% 1.733op/s 1 200
trace_buffer/2_senders/no_delay execution_time 852.643µs 898.026µs ± 20.002µs 900.165µs ± 11.153µs 908.673µs 923.925µs 946.385µs 990.537µs 10.04% 0.687 3.344 2.22% 1.414µs 1 200
trace_buffer/2_senders/no_delay throughput 1817196.433op/s 2005372.845op/s ± 44142.341op/s 1999632.972op/s ± 24721.380op/s 2033830.326op/s 2082209.514op/s 2102387.174op/s 2111082.971op/s 5.57% -0.392 2.245 2.20% 3121.335op/s 1 200
trace_buffer/4_senders/10us_delay execution_time 57.154ms 57.449ms ± 0.121ms 57.441ms ± 0.079ms 57.528ms 57.632ms 57.807ms 57.909ms 0.82% 0.365 0.699 0.21% 0.009ms 1 200
trace_buffer/4_senders/10us_delay throughput 62165.997op/s 62664.398op/s ± 131.863op/s 62673.067op/s ± 85.697op/s 62750.849op/s 62886.174op/s 62920.729op/s 62987.613op/s 0.50% -0.349 0.665 0.21% 9.324op/s 1 200
trace_buffer/4_senders/1us_delay execution_time 50.089ms 50.167ms ± 0.040ms 50.159ms ± 0.017ms 50.176ms 50.252ms 50.308ms 50.346ms 0.37% 1.777 4.321 0.08% 0.003ms 1 200
trace_buffer/4_senders/1us_delay throughput 71505.632op/s 71760.133op/s ± 57.273op/s 71772.068op/s ± 24.223op/s 71795.994op/s 71824.143op/s 71833.254op/s 71871.900op/s 0.14% -1.770 4.287 0.08% 4.050op/s 1 200
trace_buffer/4_senders/no_delay execution_time 2.094ms 2.356ms ± 0.088ms 2.352ms ± 0.058ms 2.413ms 2.509ms 2.539ms 2.579ms 9.65% 0.019 -0.017 3.71% 0.006ms 1 200
trace_buffer/4_senders/no_delay throughput 1395714.401op/s 1529863.463op/s ± 57167.052op/s 1530343.171op/s ± 37261.971op/s 1566085.140op/s 1612565.682op/s 1685633.033op/s 1719307.012op/s 12.35% 0.212 0.228 3.73% 4042.321op/s 1 200
trace_buffer/8_senders/10us_delay execution_time 57.617ms 57.901ms ± 0.192ms 57.849ms ± 0.105ms 58.036ms 58.275ms 58.399ms 58.505ms 1.13% 0.932 0.006 0.33% 0.014ms 1 200
trace_buffer/8_senders/10us_delay throughput 123066.716op/s 124351.338op/s ± 411.374op/s 124461.114op/s ± 226.776op/s 124656.586op/s 124831.733op/s 124924.996op/s 124963.171op/s 0.40% -0.920 -0.020 0.33% 29.089op/s 1 200
trace_buffer/8_senders/1us_delay execution_time 50.207ms 50.293ms ± 0.055ms 50.277ms ± 0.028ms 50.320ms 50.396ms 50.461ms 50.565ms 0.57% 1.531 3.200 0.11% 0.004ms 1 200
trace_buffer/8_senders/1us_delay throughput 142390.869op/s 143160.239op/s ± 157.105op/s 143207.249op/s ± 79.669op/s 143272.714op/s 143328.641op/s 143358.708op/s 143406.664op/s 0.14% -1.521 3.151 0.11% 11.109op/s 1 200
trace_buffer/8_senders/no_delay execution_time 6.203ms 6.517ms ± 0.111ms 6.532ms ± 0.089ms 6.606ms 6.681ms 6.707ms 6.715ms 2.80% -0.356 -0.650 1.70% 0.008ms 1 200
trace_buffer/8_senders/no_delay throughput 1072276.021op/s 1105184.584op/s ± 18949.522op/s 1102249.007op/s ± 14959.020op/s 1118669.497op/s 1138237.143op/s 1149864.809op/s 1160761.365op/s 5.31% 0.419 -0.567 1.71% 1339.934op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
trace_buffer/1_senders/10us_delay execution_time [56.559ms; 56.595ms] or [-0.032%; +0.032%] None None None
trace_buffer/1_senders/10us_delay throughput [15902.525op/s; 15912.688op/s] or [-0.032%; +0.032%] None None None
trace_buffer/1_senders/1us_delay execution_time [50.074ms; 50.083ms] or [-0.009%; +0.009%] None None None
trace_buffer/1_senders/1us_delay throughput [17970.009op/s; 17973.232op/s] or [-0.009%; +0.009%] None None None
trace_buffer/1_senders/no_delay execution_time [339.894µs; 341.357µs] or [-0.215%; +0.215%] None None None
trace_buffer/1_senders/no_delay throughput [2637534.399op/s; 2648020.341op/s] or [-0.198%; +0.198%] None None None
trace_buffer/2_senders/10us_delay execution_time [57.173ms; 57.220ms] or [-0.041%; +0.041%] None None None
trace_buffer/2_senders/10us_delay throughput [31457.677op/s; 31483.614op/s] or [-0.041%; +0.041%] None None None
trace_buffer/2_senders/1us_delay execution_time [50.106ms; 50.115ms] or [-0.009%; +0.009%] None None None
trace_buffer/2_senders/1us_delay throughput [35917.194op/s; 35923.988op/s] or [-0.009%; +0.009%] None None None
trace_buffer/2_senders/no_delay execution_time [895.254µs; 900.798µs] or [-0.309%; +0.309%] None None None
trace_buffer/2_senders/no_delay throughput [1999255.141op/s; 2011490.549op/s] or [-0.305%; +0.305%] None None None
trace_buffer/4_senders/10us_delay execution_time [57.432ms; 57.466ms] or [-0.029%; +0.029%] None None None
trace_buffer/4_senders/10us_delay throughput [62646.123op/s; 62682.673op/s] or [-0.029%; +0.029%] None None None
trace_buffer/4_senders/1us_delay execution_time [50.162ms; 50.173ms] or [-0.011%; +0.011%] None None None
trace_buffer/4_senders/1us_delay throughput [71752.195op/s; 71768.070op/s] or [-0.011%; +0.011%] None None None
trace_buffer/4_senders/no_delay execution_time [2.344ms; 2.369ms] or [-0.516%; +0.516%] None None None
trace_buffer/4_senders/no_delay throughput [1521940.659op/s; 1537786.267op/s] or [-0.518%; +0.518%] None None None
trace_buffer/8_senders/10us_delay execution_time [57.874ms; 57.928ms] or [-0.046%; +0.046%] None None None
trace_buffer/8_senders/10us_delay throughput [124294.325op/s; 124408.350op/s] or [-0.046%; +0.046%] None None None
trace_buffer/8_senders/1us_delay execution_time [50.286ms; 50.301ms] or [-0.015%; +0.015%] None None None
trace_buffer/8_senders/1us_delay throughput [143138.466op/s; 143182.013op/s] or [-0.015%; +0.015%] None None None
trace_buffer/8_senders/no_delay execution_time [6.501ms; 6.532ms] or [-0.236%; +0.236%] None None None
trace_buffer/8_senders/no_delay throughput [1102558.363op/s; 1107810.806op/s] or [-0.238%; +0.238%] None None None

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ade2ad 1785245439 oscarld/stats-string-length-limits
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.062µs 1.080µs ± 0.007µs 1.080µs ± 0.004µs 1.084µs 1.087µs 1.088µs 1.130µs 4.66% 1.760 15.820 0.61% 0.000µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [1.079µs; 1.081µs] or [-0.084%; +0.084%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ade2ad 1785245439 oscarld/stats-string-length-limits
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.610ms 8.645ms ± 0.018ms 8.641ms ± 0.010ms 8.656ms 8.679ms 8.690ms 8.699ms 0.67% 0.565 0.051 0.21% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.643ms; 8.648ms] or [-0.029%; +0.029%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 6ade2ad 1785245439 oscarld/stats-string-length-limits
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 14.689µs 15.676µs ± 0.221µs 15.657µs ± 0.108µs 15.765µs 15.983µs 16.209µs 17.187µs 9.77% 1.502 11.835 1.41% 0.016µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [15.645µs; 15.706µs] or [-0.196%; +0.196%] None None None

Baseline

Baseline benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 95610de 1785233641 main
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
trace_buffer/1_senders/10us_delay execution_time 56.317ms 56.514ms ± 0.126ms 56.487ms ± 0.074ms 56.586ms 56.712ms 56.934ms 57.084ms 1.06% 1.362 3.353 0.22% 0.009ms 1 200
trace_buffer/1_senders/10us_delay throughput 15766.350op/s 15925.323op/s ± 35.487op/s 15932.899op/s ± 20.906op/s 15952.605op/s 15972.471op/s 15975.853op/s 15980.986op/s 0.30% -1.339 3.243 0.22% 2.509op/s 1 200
trace_buffer/1_senders/1us_delay execution_time 50.005ms 50.084ms ± 0.031ms 50.082ms ± 0.011ms 50.091ms 50.140ms 50.184ms 50.239ms 0.31% 1.310 4.240 0.06% 0.002ms 1 200
trace_buffer/1_senders/1us_delay throughput 17914.280op/s 17969.803op/s ± 11.046op/s 17970.664op/s ± 3.802op/s 17974.626op/s 17986.263op/s 17991.461op/s 17998.050op/s 0.15% -1.302 4.207 0.06% 0.781op/s 1 200
trace_buffer/1_senders/no_delay execution_time 333.629µs 343.930µs ± 5.422µs 343.328µs ± 2.040µs 345.490µs 349.480µs 361.361µs 400.253µs 16.58% 5.996 57.358 1.57% 0.383µs 1 200
trace_buffer/1_senders/no_delay throughput 2248575.758op/s 2617405.400op/s ± 37989.329op/s 2621399.945op/s ± 15603.563op/s 2635848.419op/s 2654102.153op/s 2668250.100op/s 2697604.113op/s 2.91% -4.995 43.753 1.45% 2686.251op/s 1 200
trace_buffer/2_senders/10us_delay execution_time 56.632ms 57.137ms ± 0.215ms 57.109ms ± 0.135ms 57.266ms 57.506ms 57.659ms 57.919ms 1.42% 0.501 0.291 0.38% 0.015ms 1 200
trace_buffer/2_senders/10us_delay throughput 31077.861op/s 31503.426op/s ± 118.325op/s 31518.503op/s ± 74.484op/s 31571.512op/s 31676.904op/s 31726.860op/s 31784.296op/s 0.84% -0.478 0.253 0.37% 8.367op/s 1 200
trace_buffer/2_senders/1us_delay execution_time 50.052ms 50.115ms ± 0.035ms 50.110ms ± 0.017ms 50.125ms 50.194ms 50.213ms 50.243ms 0.27% 1.190 1.200 0.07% 0.002ms 1 200
trace_buffer/2_senders/1us_delay throughput 35825.779op/s 35917.211op/s ± 25.111op/s 35920.882op/s ± 11.836op/s 35934.562op/s 35945.809op/s 35953.051op/s 35962.381op/s 0.12% -1.186 1.190 0.07% 1.776op/s 1 200
trace_buffer/2_senders/no_delay execution_time 874.050µs 927.107µs ± 14.403µs 927.050µs ± 8.478µs 936.027µs 947.626µs 963.978µs 967.232µs 4.33% -0.387 1.433 1.55% 1.018µs 1 200
trace_buffer/2_senders/no_delay throughput 1860979.864op/s 1941992.697op/s ± 30388.687op/s 1941642.454op/s ± 17919.742op/s 1959365.428op/s 1989669.985op/s 2031760.283op/s 2059377.969op/s 6.06% 0.544 1.731 1.56% 2148.805op/s 1 200
trace_buffer/4_senders/10us_delay execution_time 57.076ms 57.458ms ± 0.113ms 57.455ms ± 0.081ms 57.539ms 57.639ms 57.695ms 57.797ms 0.60% -0.097 0.189 0.20% 0.008ms 1 200
trace_buffer/4_senders/10us_delay throughput 62286.970op/s 62655.195op/s ± 122.821op/s 62657.966op/s ± 87.810op/s 62743.527op/s 62829.530op/s 62941.234op/s 63073.875op/s 0.66% 0.110 0.196 0.20% 8.685op/s 1 200
trace_buffer/4_senders/1us_delay execution_time 50.058ms 50.170ms ± 0.034ms 50.162ms ± 0.018ms 50.184ms 50.235ms 50.279ms 50.306ms 0.29% 1.004 1.847 0.07% 0.002ms 1 200
trace_buffer/4_senders/1us_delay throughput 71562.655op/s 71756.444op/s ± 49.119op/s 71767.719op/s ± 25.245op/s 71787.569op/s 71813.958op/s 71830.132op/s 71916.776op/s 0.21% -0.998 1.838 0.07% 3.473op/s 1 200
trace_buffer/4_senders/no_delay execution_time 2.158ms 2.365ms ± 0.081ms 2.371ms ± 0.059ms 2.428ms 2.484ms 2.530ms 2.547ms 7.43% -0.269 -0.436 3.42% 0.006ms 1 200
trace_buffer/4_senders/no_delay throughput 1413330.801op/s 1523960.733op/s ± 52872.074op/s 1518379.366op/s ± 37320.077op/s 1557701.349op/s 1615921.765op/s 1657602.265op/s 1668367.861op/s 9.88% 0.424 -0.305 3.46% 3738.620op/s 1 200
trace_buffer/8_senders/10us_delay execution_time 57.543ms 57.820ms ± 0.181ms 57.757ms ± 0.092ms 57.918ms 58.219ms 58.301ms 58.329ms 0.99% 1.006 0.177 0.31% 0.013ms 1 200
trace_buffer/8_senders/10us_delay throughput 123438.583op/s 124525.964op/s ± 388.398op/s 124660.675op/s ± 198.493op/s 124802.389op/s 124951.334op/s 125087.028op/s 125124.788op/s 0.37% -0.996 0.152 0.31% 27.464op/s 1 200
trace_buffer/8_senders/1us_delay execution_time 50.207ms 50.306ms ± 0.075ms 50.283ms ± 0.031ms 50.334ms 50.444ms 50.520ms 50.841ms 1.11% 2.615 12.460 0.15% 0.005ms 1 200
trace_buffer/8_senders/1us_delay throughput 141618.501op/s 143123.707op/s ± 213.061op/s 143188.199op/s ± 89.096op/s 143249.941op/s 143339.186op/s 143375.952op/s 143405.390op/s 0.15% -2.581 12.138 0.15% 15.066op/s 1 200
trace_buffer/8_senders/no_delay execution_time 6.026ms 6.387ms ± 0.095ms 6.408ms ± 0.050ms 6.450ms 6.503ms 6.552ms 6.627ms 3.42% -1.148 1.962 1.48% 0.007ms 1 200
trace_buffer/8_senders/no_delay throughput 1086469.054op/s 1127519.051op/s ± 17065.884op/s 1123620.488op/s ± 8655.808op/s 1135006.393op/s 1163429.567op/s 1185643.119op/s 1194918.278op/s 6.35% 1.268 2.310 1.51% 1206.740op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
trace_buffer/1_senders/10us_delay execution_time [56.497ms; 56.532ms] or [-0.031%; +0.031%] None None None
trace_buffer/1_senders/10us_delay throughput [15920.404op/s; 15930.241op/s] or [-0.031%; +0.031%] None None None
trace_buffer/1_senders/1us_delay execution_time [50.080ms; 50.088ms] or [-0.009%; +0.009%] None None None
trace_buffer/1_senders/1us_delay throughput [17968.272op/s; 17971.334op/s] or [-0.009%; +0.009%] None None None
trace_buffer/1_senders/no_delay execution_time [343.179µs; 344.682µs] or [-0.218%; +0.218%] None None None
trace_buffer/1_senders/no_delay throughput [2612140.444op/s; 2622670.355op/s] or [-0.201%; +0.201%] None None None
trace_buffer/2_senders/10us_delay execution_time [57.108ms; 57.167ms] or [-0.052%; +0.052%] None None None
trace_buffer/2_senders/10us_delay throughput [31487.027op/s; 31519.825op/s] or [-0.052%; +0.052%] None None None
trace_buffer/2_senders/1us_delay execution_time [50.110ms; 50.120ms] or [-0.010%; +0.010%] None None None
trace_buffer/2_senders/1us_delay throughput [35913.730op/s; 35920.691op/s] or [-0.010%; +0.010%] None None None
trace_buffer/2_senders/no_delay execution_time [925.111µs; 929.103µs] or [-0.215%; +0.215%] None None None
trace_buffer/2_senders/no_delay throughput [1937781.117op/s; 1946204.276op/s] or [-0.217%; +0.217%] None None None
trace_buffer/4_senders/10us_delay execution_time [57.442ms; 57.473ms] or [-0.027%; +0.027%] None None None
trace_buffer/4_senders/10us_delay throughput [62638.173op/s; 62672.217op/s] or [-0.027%; +0.027%] None None None
trace_buffer/4_senders/1us_delay execution_time [50.165ms; 50.174ms] or [-0.009%; +0.009%] None None None
trace_buffer/4_senders/1us_delay throughput [71749.636op/s; 71763.251op/s] or [-0.009%; +0.009%] None None None
trace_buffer/4_senders/no_delay execution_time [2.354ms; 2.376ms] or [-0.475%; +0.475%] None None None
trace_buffer/4_senders/no_delay throughput [1516633.172op/s; 1531288.294op/s] or [-0.481%; +0.481%] None None None
trace_buffer/8_senders/10us_delay execution_time [57.795ms; 57.845ms] or [-0.043%; +0.043%] None None None
trace_buffer/8_senders/10us_delay throughput [124472.136op/s; 124579.792op/s] or [-0.043%; +0.043%] None None None
trace_buffer/8_senders/1us_delay execution_time [50.296ms; 50.317ms] or [-0.021%; +0.021%] None None None
trace_buffer/8_senders/1us_delay throughput [143094.179op/s; 143153.235op/s] or [-0.021%; +0.021%] None None None
trace_buffer/8_senders/no_delay execution_time [6.374ms; 6.400ms] or [-0.206%; +0.206%] None None None
trace_buffer/8_senders/no_delay throughput [1125153.883op/s; 1129884.218op/s] or [-0.210%; +0.210%] None None None

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 79eff2f 1785245631 main
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.078µs 1.093µs ± 0.005µs 1.094µs ± 0.003µs 1.096µs 1.100µs 1.102µs 1.103µs 0.82% -0.552 -0.289 0.47% 0.000µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [1.092µs; 1.093µs] or [-0.065%; +0.065%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 79eff2f 1785245631 main
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 8.590ms 8.619ms ± 0.018ms 8.614ms ± 0.011ms 8.630ms 8.655ms 8.675ms 8.681ms 0.78% 1.006 0.671 0.21% 0.001ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [8.617ms; 8.622ms] or [-0.029%; +0.029%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 79eff2f 1785245631 main
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 15.675µs 16.062µs ± 0.471µs 16.003µs ± 0.106µs 16.118µs 16.381µs 16.734µs 21.956µs 37.20% 10.051 121.060 2.93% 0.033µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [15.997µs; 16.128µs] or [-0.407%; +0.407%] None None None

/// List of feature flags
pub feature_flags: Option<Vec<String>>,
#[serde(default)]
pub feature_flags: Vec<String>,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this related to the PR? Also, endpoints above is still an Option<Vec<String>>. Is that ok?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a pattern I used before previously for tags filter:
When we don't need to differentiate between a missing field or its default value, we might as well put

#[serde(default)]

to avoid an extra .is_some_and/.unwrap_or_default when reading it.

Here for example, if the agent doesn't send its feature_flags, it's the same as if there was no feature flags enabled.

As for endpoints, it could also be refactored to have it but it would be unrelated to this PR.

Comment thread libdd-data-pipeline/src/trace_exporter/stats.rs Outdated
Comment thread libdd-trace-stats/src/span_concentrator/aggregation.rs
Comment on lines +295 to +300
#[cfg(feature = "stats-obfuscation")]
let mut agg_key = agg_key;
#[cfg(feature = "stats-obfuscation")]
if target_bucket.obfuscated {
agg_key.truncate(self.big_resource);
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
#[cfg(feature = "stats-obfuscation")]
let mut agg_key = agg_key;
#[cfg(feature = "stats-obfuscation")]
if target_bucket.obfuscated {
agg_key.truncate(self.big_resource);
}
#[cfg(feature = "stats-obfuscation")]
{
let mut agg_key = agg_key;
if target_bucket.obfuscated {
agg_key.truncate(self.big_resource);
}
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't works because agg_key then becomes shadowed in the block, so the outer one is not actually truncated when used just below in target_bucket.insert

Comment thread libdd-trace-stats/src/span_concentrator/tests.rs Outdated
Comment thread libdd-trace-stats/src/span_concentrator/tests.rs Outdated
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 42045b9 into main Jul 29, 2026
154 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the oscarld/stats-string-length-limits branch July 29, 2026 12:38
hoolioh added a commit that referenced this pull request Aug 18, 2026
)

# Release proposal for libdd-data-pipeline, libdd-telemetry and their
dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-ddsketch
**Next version:** `1.1.1`
**Semver bump:** `patch`
**Tag:** `libdd-ddsketch-v1.1.1`

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- chore: moving to workspace-level dependencies, phase 2 (#2270)

## libdd-shared-runtime
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-shared-runtime-v3.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0
- `libdd-capabilities-impl`: ^3.0.0 → ^4.0.0

### Commits

- feat(shared-runtime): add block_on_with_timeout to BlockingRuntime
(#2333)
- chore(runtime): restart all workers on invalid state (#2262)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)

## libdd-dogstatsd-client
**Next version:** `5.0.0`
**Semver bump:** `major`
**Tag:** `libdd-dogstatsd-client-v5.0.0`

### Commits

- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(dogstatsd)!: add shared_runtime buffered sink (#2224)
- refactor(statsd)!: make client clonable (#2222)

## libdd-telemetry
**Next version:** `7.0.0`
**Semver bump:** `major`
**Tag:** `libdd-telemetry-v7.0.0`

### Commits

- refactor(rc)!: make conversion from RemoteConfigProduct back and forth
generally available (#2325)
- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- fix: drain the mailbox before stopping (#2258)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- fix(sidecar): don't double-encode file:// telemetry endpoints (#2230)

## libdd-trace-obfuscation
**Next version:** `6.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-obfuscation-v6.0.0`

### ⚠️ major bump forced due to:

- `libdd-trace-utils`: ^9.0.0 → ^10.1.0

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- chore(lint): update nightly (#2281)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- fix: new clippy lints (#2219)

## libdd-trace-stats
**Next version:** `7.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-stats-v7.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0
- `libdd-capabilities-impl`: ^3.0.0 → ^4.0.0
- `libdd-dogstatsd-client`: ^4.0.0 → ^5.0.0
- `libdd-telemetry`: ^6.0.0 → ^7.0.0
- `libdd-trace-utils`: ^9.0.0 → ^10.1.0

### Commits

- feat: add v1 isolated bricks for trace exporter (#2280)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- feat(data-pipeline)!: add compression option for agentless export
(#2205)
- feat(stats)!: per-field cardinality limits (#2211)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- feat(stats)!: string field length limit (#2267)
- feat(trace_exporter)!: add `restart_after_fork` configuration option
[APMSP-3843] (#2263)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)
- refactor(statsd)!: make client clonable (#2222)
- fix(stats-exporter): disable retries for stats payload sends (#2249)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- fix!: css obfuscation logic (#2203)

## libdd-data-pipeline
**Next version:** `8.0.0`
**Semver bump:** `major`
**Tag:** `libdd-data-pipeline-v8.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0
- `libdd-capabilities-impl`: ^3.0.0 → ^4.0.0
- `libdd-dogstatsd-client`: ^4.0.0 → ^5.0.0
- `libdd-telemetry`: ^6.0.0 → ^7.0.0
- `libdd-trace-stats`: ^6.0.0 → ^7.0.0
- `libdd-trace-utils`: ^9.0.0 → ^10.1.0

### Commits

- fix(trace-exporter): mark OTLP client-computed stats (#2245)
- feat(data-pipeline): adds new attributes to OTLP trace metrics export
(#2316)
- feat: add v1 isolated bricks for trace exporter (#2280)
- feat(data-pipeline)!: add flush_and_close to the trace buffer (#2313)
- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- feat(data-pipeline)!: add compression option for agentless export
(#2205)
- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- feat(stats)!: per-field cardinality limits (#2211)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- feat(stats)!: string field length limit (#2267)
- refactor(trace-utils)!: split generic TracerHeaderTags (#2279)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- feat(trace_exporter)!: add `restart_after_fork` configuration option
[APMSP-3843] (#2263)
- feat(data-pipeline): emit additional_metric_tags on OTLP span duration
metric (#2264)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(dogstatsd)!: add shared_runtime buffered sink (#2224)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)
- refactor(statsd)!: make client clonable (#2222)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- feat(trace_exporter)!: remove deprecated methods (#2250)
- feat(trace-utils)!: add v1 decoder (#2174)
- feat(trace-utils)!: add encoder v1 to v04 + refactor (#2145)
- feat(otlp): add instrumentation scope metadata (#2235)
- fix(trace-utils)!: serialize v0.5 span links and events into meta
(#980)
- fix!: css obfuscation logic (#2203)
- test(data-pipeline): gate telemetry-only tests behind the telemetry
feature (#2204)


[APMSP-3843]:
https://datadoghq.atlassian.net/browse/APMSP-3843?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants