Skip to content

feat: added file capability [APMSP-3780] - #2240

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 11 commits into
mainfrom
jwiriath/file-caps
Jul 22, 2026
Merged

gh-worker-dd-mergequeue-cf854d[bot] merged 11 commits into
mainfrom
jwiriath/file-caps

Conversation

@Aaalibaba42

Copy link
Copy Markdown
Contributor

What does this PR do?

Added Capability to read, write, and have metadata about files

Motivation

dd-trace-js needing to add info from the /proc in their requests, it's better to have libdatadog drive the call

Additional Notes

Nop

How to test the change?

check, tests, check for wasm32

@Aaalibaba42
Aaalibaba42 requested review from a team as code owners July 15, 2026 09:59
@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Jul 15, 2026

Copy link
Copy Markdown

Tests

🎉 All green!

🧪 All tests passed
❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 75.97%
Overall Coverage: 74.64% (-0.00%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: cbdc5a0 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
Artifact Baseline Commit Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so 8.13 MB 8.13 MB 0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a 88.18 MB 88.18 MB +0% (+1.28 KB) 👌
aarch64-unknown-linux-gnu
Artifact Baseline Commit Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so 10.93 MB 10.93 MB +0% (+160 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a 99.46 MB 99.46 MB +0% (+480 B) 👌
libdatadog-x64-windows
Artifact Baseline Commit Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll 26.59 MB 26.59 MB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib 89.18 KB 89.18 KB 0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb 191.30 MB 191.38 MB +.04% (+88.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib 1.04 GB 1.04 GB +.08% (+883.73 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll 8.66 MB 8.66 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib 89.18 KB 89.18 KB 0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb 25.36 MB 25.36 MB 0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib 50.55 MB 50.55 MB +0% (+260 B) 👌
libdatadog-x86-windows
Artifact Baseline Commit Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll 23.16 MB 23.16 MB -0% (-512 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib 90.58 KB 90.58 KB 0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb 195.94 MB 196.06 MB +.05% (+120.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib 1.03 GB 1.03 GB +.08% (+881.37 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll 6.68 MB 6.68 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib 90.58 KB 90.58 KB 0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb 27.26 MB 27.26 MB 0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib 48.13 MB 48.13 MB +0% (+302 B) 👌
x86_64-alpine-linux-musl
Artifact Baseline Commit Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a 78.64 MB 78.64 MB +0% (+1.88 KB) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so 9.05 MB 9.05 MB 0% (0 B) 👌
x86_64-unknown-linux-gnu
Artifact Baseline Commit Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a 94.14 MB 94.14 MB +0% (+1.25 KB) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so 11.02 MB 11.02 MB +0% (+144 B) 👌

@pr-commenter

pr-commenter Bot commented Jul 15, 2026

Copy link
Copy Markdown

Benchmarks

Comparison

Benchmark execution time: 2026-07-22 10:24:33

Comparing candidate commit cbdc5a0 in PR branch jwiriath/file-caps with baseline commit 63ecad5 in branch main.

Found 5 performance improvements and 0 performance regressions! Performance is the same for 137 metrics, 0 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:otlp/map_to_prost/1x1000

  • 🟩 execution_time [-111.503µs; -110.319µs] or [-6.582%; -6.512%]

scenario:vec_map/dedup/dup_1_in_10/8

  • 🟩 execution_time [-55.496ns; -49.276ns] or [-12.472%; -11.074%]

scenario:vec_map/dedup/dup_1_in_2/8

  • 🟩 execution_time [-58.654ns; -54.187ns] or [-9.541%; -8.815%]

scenario:vec_map/dedup/dup_1_in_4/8

  • 🟩 execution_time [-59.860ns; -55.929ns] or [-11.667%; -10.901%]

scenario:vec_map/dedup/no_duplicates/8

  • 🟩 execution_time [-75.547ns; -71.548ns] or [-17.675%; -16.740%]

Benchmark execution time: 2026-07-22 10:39:55

Comparing candidate commit cbdc5a0 in PR branch jwiriath/file-caps with baseline commit 63ecad5 in branch main.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 174 metrics, 10 unstable metrics.

Explanation

This is an A/B test comparing a candidate commit's performance against that of a baseline commit. Performance changes are noted in the tables below as:

  • 🟩 = significantly better candidate vs. baseline
  • 🟥 = significantly worse candidate vs. baseline

We compute a confidence interval (CI) over the relative difference of means between metrics from the candidate and baseline commits, considering the baseline as the reference.

If the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD), the change is considered significant.

Feel free to reach out to #apm-benchmarking-platform on Slack if you have any questions.

More details about the CI and significant changes

You can imagine this CI as a range of values that is likely to contain the true difference of means between the candidate and baseline commits.

CIs of the difference of means are often centered around 0%, because often changes are not that big:

---------------------------------(------|---^--------)-------------------------------->
                              -0.6%    0%  0.3%     +1.2%
                                 |          |        |
         lower bound of the CI --'          |        |
sample mean (center of the CI) -------------'        |
         upper bound of the CI ----------------------'

As described above, a change is considered significant if the CI is entirely outside the configured SIGNIFICANT_IMPACT_THRESHOLD (or the deprecated UNCONFIDENCE_THRESHOLD).

For instance, for an execution time metric, this confidence interval indicates a significantly worse performance:

----------------------------------------|---------|---(---------^---------)---------->
                                       0%        1%  1.3%      2.2%      3.1%
                                                  |   |         |         |
       significant impact threshold --------------'   |         |         |
                      lower bound of CI --------------'         |         |
       sample mean (center of the CI) --------------------------'         |
                      upper bound of CI ----------------------------------'

scenario:alloc_free/system/4096

  • 🟩 execution_time [-10.610ns; -10.454ns] or [-11.203%; -11.039%]

scenario:glob_matcher/ascii_wildcard_question_match/wall_time

  • 🟩 execution_time [-23.925ns; -23.895ns] or [-39.351%; -39.302%]

scenario:glob_matcher/ascii_wildcard_star_match/wall_time

  • 🟩 execution_time [-23.545ns; -23.527ns] or [-38.973%; -38.944%]

Candidate

Omitted due to size.

Baseline

Omitted due to size.

@Aaalibaba42 Aaalibaba42 changed the title feat: added file capability feat: added file capability [APMSP-3780] Jul 15, 2026
Comment thread libdd-capabilities-impl/src/file.rs Outdated
Comment thread libdd-capabilities-impl/src/file.rs Outdated
@Aaalibaba42

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 20, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-20 12:24:12 UTC ℹ️ Start processing command /merge


2026-07-20 12:24:19 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-20 13:17:10 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-07-20 13:44:06 UTC ℹ️ MergeQueue: Readding this merge request to the queue because another merge request processed with yours failed. No action is needed from your side.


2026-07-20 14:33:56 UTCMergeQueue: The checks failed on this merge request

Tests failed on this commit d24f70b:

What to do next?

  • Investigate the failures and when ready, re-add your pull request to the queue!
  • If your PR checks are green, try to rebase/merge. It might be because the CI run is a bit old.
  • Any question, go check the FAQ.

@Aaalibaba42

Copy link
Copy Markdown
Contributor Author

/merge

@Aaalibaba42

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 21, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-21 14:34:53 UTC ℹ️ Start processing command /merge


2026-07-21 14:35:00 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals. View in MergeQueue UI.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2026-07-21 19:32:09 UTC ⚠️ MergeQueue: This merge request was unqueued

devflow unqueued this merge request: It did not become mergeable within the expected time

@Aaalibaba42

Copy link
Copy Markdown
Contributor Author

/merge

@gh-worker-devflow-routing-ef8351

gh-worker-devflow-routing-ef8351 Bot commented Jul 22, 2026

Copy link
Copy Markdown

View all feedbacks in Devflow UI.

2026-07-22 10:45:46 UTC ℹ️ Start processing command /merge


2026-07-22 10:45:50 UTC ℹ️ MergeQueue: pull request added to the queue

The expected merge time in main is approximately 1h (p90).


2026-07-22 11:28:59 UTC ℹ️ MergeQueue: This merge request was merged

@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot merged commit 3081603 into main Jul 22, 2026
101 checks passed
@gh-worker-dd-mergequeue-cf854d
gh-worker-dd-mergequeue-cf854d Bot deleted the jwiriath/file-caps branch July 22, 2026 11:28
hoolioh added a commit that referenced this pull request Aug 7, 2026
…er-flare (#2332)

# Release proposal for libdd-ffe, libdd-http-client, libdd-tracer-flare
and their dependencies

This PR contains version bumps based on public API changes and commits
since last release.

## libdd-capabilities
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-v3.0.0`

### Commits

- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- feat(capabilities)!: Add streaming to http capabilities (#2251)
- feat: added file capability [APMSP-3780] (#2240)
- feat: added environment capability [APMSP-3780] (#2239)

## libdd-common
**Next version:** `5.1.1`
**Semver bump:** `patch`
**Tag:** `libdd-common-v5.1.1`

### Commits

- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- test: stabilize flaky tests (#2256)
- fix(sidecar): don't double-encode file:// telemetry endpoints (#2230)
- fix: last new clippy lint (#2221)

## libdd-tinybytes
**Next version:** `1.1.2`
**Semver bump:** `patch`
**Tag:** `libdd-tinybytes-v1.1.2`

### Commits

- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)

## libdd-trace-protobuf
**Next version:** `4.0.1`
**Semver bump:** `patch`
**Tag:** `libdd-trace-protobuf-v4.0.1`

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)

## libdd-capabilities-impl
**Next version:** `4.0.0`
**Semver bump:** `major`
**Tag:** `libdd-capabilities-impl-v4.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0

### Commits

- feat(telemetry)!: Add Installation signature and AppProduct changes
payloads (#2213)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- fix(telemetry)!: stop sending Connection: close to the Agent (#2286)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- feat(capabilities)!: Add streaming to http capabilities (#2251)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat: added file capability [APMSP-3780] (#2240)
- feat(telemetry)!: make telemetry worker wasm-compatible for the
TraceExporter (#2172)
- feat: added environment capability [APMSP-3780] (#2239)

## libdd-http-client
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-http-client-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-trace-normalization
**Next version:** `3.0.1`
**Semver bump:** `patch`
**Tag:** `libdd-trace-normalization-v3.0.1`

### Commits

- refactor: migrate to workspace dependencies, phase 4 (#2296)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)

## libdd-remote-config
**Next version:** `3.0.0`
**Semver bump:** `major`
**Tag:** `libdd-remote-config-v3.0.0`

### Commits

- refactor(rc)!: make conversion from RemoteConfigProduct back and forth
generally available (#2325)
- fix(wasm)!: finish the WASM port of remote-config (#2315)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- feat(rc): Handle expired config status (#2274)
- feat(remote-config)!: add AsmRawResponseBody capability (#2278)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- fix(rc): Make Target fields available again after eaf5ad0 (#2232)
- fix: new clippy lints (#2219)

## libdd-trace-utils
**Next version:** `10.0.0`
**Semver bump:** `major`
**Tag:** `libdd-trace-utils-v10.0.0`

### ⚠️ major bump forced due to:

- `libdd-capabilities`: ^2.1.0 → ^3.0.0

### Commits

- refactor(rc)!: make conversion from RemoteConfigProduct back and forth
generally available (#2325)
- fix(libdd-trace-utils): apply SpanLink flags masking when v0.5 json
encoding (#2314)
- refactor: migrate to workspace dependencies, phase 4 (#2296)
- feat(data-pipeline)!: add compression option for agentless export
(#2205)
- refactor: migrate to workspace dependencies, phase 3 (#2283)
- refactor(trace-utils)!: split generic TracerHeaderTags (#2279)
- chore(lint): update nightly (#2281)
- chore: moving to workspace-level dependencies, phase 2 (#2270)
- fix(remote-config)!: Expose HttpClientCapability in remote config
(#2252)
- refactor: consolidate core dependencies at workspace level (phase 1)
(#2253)
- feat(stats)!: implement additional metric tags in libdd-trace-stats
(#2170)
- feat(trace-utils)!: add v1 decoder (#2174)
- feat(trace-utils)!: add encoder v1 to v04 + refactor (#2145)
- feat(otlp): add instrumentation scope metadata (#2235)
- fix(trace-utils)!: serialize v0.5 span links and events into meta
(#980)

## libdd-ffe
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-ffe-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


## libdd-tracer-flare
**Next version:** `1.0.0`
**Semver bump:** `major`
**Tag:** `libdd-tracer-flare-v1.0.0`

**Warning:** this is an initial release. Please verify that the version
and commits included are correct.


[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
[APMSP-3780]:
https://datadoghq.atlassian.net/browse/APMSP-3780?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: hoolioh <107922352+hoolioh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants