test: cover null and empty targeting keys in shared fixtures - #41
Draft
leoromanovsky wants to merge 1 commit into
Draft
leoromanovsky wants to merge 1 commit into
leoromanovsky wants to merge 1 commit into
Conversation
Add sharding and id fallback regressions, including explicit id precedence. Environment: Datadog workspace
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The common fixtures' existing empty-targeting-key case uses a static flag with no shards or rules, so it cannot catch an evaluator treating
""as missing during sharding or implicitidresolution. This gap surfaced while updating DataDog/dd-trace-dotnet#8384.Changes
SPLIT) versus null (ERROR/TARGETING_KEY_MISSING).idrule and cases for empty-key fallback (TARGETING_MATCH), null-key fallback (DEFAULT), and explicitidattributes taking precedence.Decisions
evaluation-cases/*.jsonformat so current canonical-fixture runners discover the cases.^$to match only an emptyid.Validation
python3 ci/validate-fixtures.py: 313 cases across 42 files passed.dd-trace-dotnetat66c3df873c(fix(openfeature): accept empty string as valid targeting key dd-trace-dotnet#8384): all 571 FeatureFlags tests passed on .NET 10, including the six new cases. Temporary snapshot changes were restored afterward.Checklist
ufc-config.json.