Skip to content

Fix datadog/dd-appsec-php-ci - #4168

Merged
estringana merged 10 commits into
masterfrom
estringana/update-images
Sep 9, 2026
Merged

estringana merged 10 commits into
masterfrom
estringana/update-images

Conversation

@estringana

@estringana estringana commented Sep 8, 2026 •

Copy link
Copy Markdown
Contributor

Description

Current base image got EOL so this PR brings it to a newer debian version

Reviewer checklist

  • Test coverage seems ok.
  • Appropriate labels assigned.

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Pipelines  Tests

✨ Unblock PR with BitsAI

⚠️ Warnings

❌ Your PR has failed checks. Please review the issues below and take necessary action before merging.

🚦 52 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | appsec integration tests: [test8.4-release-zts] — ❌ 51 tests failed · 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

❌ POST request sets content type and length() from com.datadog.appsec.php.integration.FrankenphpClassicTests
Assertion failed: 

assert span.meta['http.request.headers.content-type'] == 'application/json'
       |    |   |                                     |
       |    |   null                                  false
       |    ['http.status_code':'200', 'http.endpoint':'/hello.php', '_dd.p.ksr':'1', 'span.kind':'server', '_dd.p.dm':'-1', 'http.url':'http://docker:32773/hello.php', 'runtime-id':'5c376e7c-d2a6-4d95-8320-9a5a93b042bd', 'env':'integration', 'http.method':'POST', 'http.useragent':'Java-http-client/17.0.20']
       com.datadog.appsec.php.model.Span@54387873

Assertion failed: 

...
❌ [1] file_get_contents, 19 from com.datadog.appsec.php.integration.FrankenphpClassicTests
Assertion failed: 

assert span.metrics."_dd.appsec.enabled" == 1.0d
       |    |       |                    |
       |    |       null                 false
       |    ['process_id':14.0, 'php.memory.peak_usage_bytes':542936.0, 'php.compilation.total_time_ms':0.204, 'php.memory.peak_real_usage_bytes':2097152.0, '_dd.agent_psr':1.0, '_sampling_priority_v1':1.0]
       com.datadog.appsec.php.model.Span@350342e0

Assertion failed: 

...
❌ [1] file_put_contents, /tmp/dummy, 9 from com.datadog.appsec.php.integration.FrankenphpClassicTests
Assertion failed: 

assert span.metrics."_dd.appsec.enabled" == 1.0d
       |    |       |                    |
       |    |       null                 false
       |    ['process_id':14.0, 'php.memory.peak_usage_bytes':541032.0, 'php.compilation.total_time_ms':0.177, 'php.memory.peak_real_usage_bytes':2097152.0, '_dd.agent_psr':1.0, '_sampling_priority_v1':1.0]
       com.datadog.appsec.php.model.Span@6b0325d0

Assertion failed: 

...
↳ and 48 more — View all
DataDog/apm-reliability/dd-trace-php | appsec integration tests: [test8.3-release] — ❄️ 1 known flaky test

View more details · View in GitLab

↳ ❄️ Known flaky: appsec is disabled and sidecar is not launched() from com.datadog.appsec.php.integration.SidecarFeaturesDisabledTests

DataDog/apm-reliability/dd-trace-php | benchmarks-tracer — 🔧 Needs a code fix, caused by this PR

View more details · View in GitLab

View all 52 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 55.04% (-0.01%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 6362a19 | Docs | View more details | Give us feedback!

@estringana
estringana marked this pull request as ready for review September 8, 2026 16:10
@estringana
estringana requested review from a team as code owners September 8, 2026 16:10
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-08T16:15:51.377347Z 2d5c679 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@estringana estringana changed the title Fix base Fix datadog/dd-appsec-php-ci Sep 8, 2026
@cataphract
cataphract requested a review from a team as a code owner September 8, 2026 17:03
@estringana
estringana merged commit 6202f54 into master Sep 9, 2026
2111 of 2163 checks passed
@estringana
estringana deleted the estringana/update-images branch September 9, 2026 14:37
@github-actions github-actions Bot added this to the 1.26.0 milestone Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants