Adds tags and types. by jcchavezs · Pull Request #4 · DataDog/dd-trace-php

jcchavezs · 2018-02-09T14:39:27Z

This PR adds tags and types.

palazzem · 2018-02-09T15:10:29Z

+
+const WEB_SERVLET = 'web';
+
+const SQL = 'sql';


Just to let you know: this span.type is the most critical one. If it's set, the span.resource (that is a SQL query) will be obfuscated through the Agent filter and lexer: https://github.com/DataDog/datadog-trace-agent/blob/master/quantizer/main.go#L21-L30

No actions here, but in the future we should take it in consideration.

Great feedback. This should be definitively in the description.

What do you mean "obfuscated"? As in, it'll be removed from the trace?

Replacing parameters with ? and similar - see https://github.com/DataDog/datadog-trace-agent/blob/master/obfuscate/sql.go. So that the same query with different parameters is recognized as the same and grouped, I believe.

maxcountryman · 2018-07-23T18:40:44Z

+
+const ENV = 'env';
+const SPAN_TYPE = 'span.type';
+const SERVICE_NAME = 'service.name';


What does service and resource name map to on the DataDog side of things?

A service is a particular webapp, or maybe microservice, or a database. A resource is a particular query handled by that resource, like a path (/myaccount) or a query (select params from users where id = ?). See https://help.datadoghq.com/hc/en-us/articles/115000702546-What-is-the-Difference-Between-Type-Service-Resource-and-Name- for more.

jcchavezs · 2018-07-25T18:04:05Z

Regarding SQL: Due to privacy issues and more important, to keep low cardinality in tags it is recommended to store the parameters but wildcards instead of the actual parameters. Den ons. 25. jul. 2018, 19:58 skrev Chuck Hagenbuch < notifications@github.com>:

***@***.**** commented on this pull request. ------------------------------ In src/DDTrace/Tags.php <#4 (comment)>: > @@ -0,0 +1,12 @@ +<?php + +namespace DDTrace\Tags; + +const ENV = 'env'; +const SPAN_TYPE = 'span.type'; +const SERVICE_NAME = 'service.name'; A service is a particular webapp, or maybe microservice, or a database. A resource is a particular query handled by that resource, like a path (/myaccount) or a query (select params from users where id = ?). See https://help.datadoghq.com/hc/en-us/articles/115000702546-What-is-the-Difference-Between-Type-Service-Resource-and-Name- for more. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#4 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AC7sAh5cBKbQTntllGIyEuSJ080nCOSXks5uKLHbgaJpZM4SAA_y> .

-- *José Carlos*

Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b) #1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560 #2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31 #3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053 #4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486 #5 0xffff8b16a70b (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b) SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s).

…nd trace sender (#2672) * Make use of the sidecar thread safe * Collect trace_api.{requests,responses,errors} in the background trace sender * Fix test * Fix memory leak: Direct leak of 24 byte(s) in 1 object(s) allocated from: #0 0xffff8dfed43b in malloc (/usr/lib/aarch64-linux-gnu/libasan.so.5+0xcf43b) #1 0xffff81eb8f4f in __cxa_thread_atexit_impl /home/circleci/datadog/tmp/build_extension/ext/ddtrace.c:560 #2 0xffff82ed7c8b in std::sys::unix::thread_local_dtor::register_dtor::ha7abe21b2e8f0491 library/std/src/sys/unix/thread_local_dtor.rs:31 #3 0xffff81ec332b in _dd_writer_loop /home/circleci/datadog/tmp/build_extension/ext/coms.c:1053 #4 0xffff8db7a7e3 in start_thread /build/glibc-tVuo8E/glibc-2.28/nptl/pthread_create.c:486 #5 0xffff8b16a70b (/lib/aarch64-linux-gnu/libc.so.6+0xcf70b) SUMMARY: AddressSanitizer: 24 byte(s) leaked in 1 allocation(s). * Update libdatadog * Fix tests * Try running system tests with sidecar sender Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Don't explicitly flush the bgs telemetry data * Improve test stability * Try to run system-tests from a fork * Fix telemetry tests * Shut up instrumentation telemetry in web tests * Fix flakiness Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> * Better flaky test check Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> --------- Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com> Co-authored-by: Bob Weinand <bob.weinand@datadoghq.com>

AI summary of the mechanism: > The crash is a cross-thread use-after-free: > > 1. gRPC executes a PHP CallCredentials callback directly on a native > EventEngine worker thread. > 2. In PHP NTS, executor globals—including the profiler VM > interrupt—are process-wide. The gRPC thread can therefore consume a > pending wall-time profiling interrupt. > > 3. The profiler stack-walks that foreign thread and caches raw ThinStr > pointers in Zend’s function runtime cache. > 4. Those strings are actually owned by a Rust thread_local StringSet > belonging to that specific gRPC worker. > 5. After the worker remains idle, gRPC retires it. Its TLS destructor > frees/unmaps the string arena, but Zend’s runtime cache still contains > the pointers. > 6. A later callback/sample retrieves one of those dangling pointers > and crashes in: > ``` > ThinStr::len > StringSet::get_thin_str > collect_time > zend_call_function > plugin_get_metadata > ``` > The deterministic reproducer is one sufficiently long callback, a > 25-second idle interval allowing worker retirement, then another > callback. > > Forking, AppSec, tracing, payload stress, and allocation profiling are > not required. The profiler must avoid sampling threads that never ran > PHP request initialization and must not store thread-local arena > pointers in runtime-cache slots accessible from other threads. Stacktrace: ``` \#0 0x00007742bf3ee95c in ?? () from /lib/x86_64-linux-gnu/libc.so.6 \#1 0x00007742bf399cc2 in raise () from /lib/x86_64-linux-gnu/libc.so.6 \#2 0x00007742b87c94ec in libdd_crashtracker::collector::signal_handler_manager::chain_signal_handler () at libdatadog/libdd-crashtracker/src/collector/signal_handler_manager.rs:125 \#3 libdd_crashtracker::collector::crash_handler::handle_posix_sigaction () at libdatadog/libdd-crashtracker/src/collector/crash_handler.rs:235 \#4 <signal handler called> \#5 read<[u8; 8]> () at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/ptr/mod.rs:1380 \#6 read<[u8; 8]> () at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/ptr/mut_ptr.rs:1356 \#7 len<u8> () at /project/libdatadog/libdd-profiling/src/profiles/collections/thin_str.rs:213 \#8 inline_string_ptr () at /project/libdatadog/libdd-profiling/src/profiles/collections/thin_str.rs:235 \#9 borrow () at /project/libdatadog/libdd-profiling/src/profiles/collections/thin_str.rs:470 \#10 deref () at /project/libdatadog/libdd-profiling/src/profiles/collections/thin_str.rs:453 \#11 get_thin_str () at components-rs/../profiling/src/string_set.rs:117 \#12 get_or_insert<datadog_php::profiling::profiler::stack_walking::detail::handle_function_cache_slot::{closure_env#0}> () at components-rs/../profiling/src/profiler/stack_walking.rs:209 \#13 handle_function_cache_slot () at components-rs/../profiling/src/profiler/stack_walking.rs:466 \#14 collect_call_frame () at components-rs/../profiling/src/profiler/stack_walking.rs:417 \#15 collect_stack_sample_cached () at components-rs/../profiling/src/profiler/stack_walking.rs:362 \#16 0x00007742bea25a55 in {closure#0} () at components-rs/../profiling/src/profiler/stack_walking.rs:393 \#17 {closure#0}<datadog_php::profiling::string_set::StringSet, datadog_php::profiling::profiler::stack_walking::detail::collect_stack_sample::{closure_env#0}, core::result::Result<datadog_php::profiling::profiler::backtrace::Backtrace, datadog_php::profiling::profiler::stack_walking::CollectStackSampleError>> () at components-rs/../profiling/src/lib.rs:533 \#18 map<core::cell::RefMut<datadog_php::profiling::string_set::StringSet>, core::cell::BorrowMutError, core::result::Result<datadog_php::profiling::profiler::backtrace::Backtrace, datadog_php::profiling::profiler::stack_walking::CollectStackSampleError>, datadog_php::profiling::{impl#2}::try_with_borrow_mut::{closure#0}::{closure_env#0}<datadog_php::profiling::string_set::StringSet, datadog_php::profiling::profiler::stack_walking::detail::collect_stack_sample::{closure_env#0}, core::result::Result<datadog_php::profiling::profiler::backtrace::Backtrace, datadog_php::profiling::profiler::stack_walking::CollectStackSampleError>>> () at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/core/src/result.rs:773 \#19 {closure#0}<datadog_php::profiling::string_set::StringSet, datadog_php::profiling::profiler::stack_walking::detail::collect_stack_sample::{closure_env#0}, core::result::Result<datadog_php::profiling::profiler::backtrace::Backtrace, datadog_php::profiling::profiler::stack_walking::CollectStackSampleError>> () at components-rs/../profiling/src/lib.rs:533 \#20 try_with<core::cell::RefCell<datadog_php::profiling::string_set::StringSet>, datadog_php::profiling::{impl#2}::try_with_borrow_mut::{closure_env#0}<datadog_php::profiling::string_set::StringSet, datadog_php::profiling::profiler::stack_walking::detail::collect_stack_sample::{closure_env#0}, core::result::Result<datadog_php::profiling::profiler::backtrace::Backtrace, datadog_php::profiling::profiler::stack_walking::CollectStackSampleError>>, core::result::Result<core::result::Result<datadog_php::profiling::profiler::backtrace::Backtrace, datadog_php::profiling::profiler::stack_walking::CollectStackSampleError>, core::cell::BorrowMutError>> () at /rustc/17067e9ac6d7ecb70e50f92c1944e545188d2359/library/std/src/thread/local.rs:311 \#21 try_with_borrow_mut<datadog_php::profiling::string_set::StringSet, datadog_php::profiling::profiler::stack_walking::detail::collect_stack_sample::{closure_env#0}, core::result::Result<datadog_php::profiling::profiler::backtrace::Backtrace, datadog_php::profiling::profiler::stack_walking::CollectStackSampleError>> () at components-rs/../profiling/src/lib.rs:532 \#22 collect_stack_sample () at components-rs/../profiling/src/profiler/stack_walking.rs:393 \#23 0x00007742bea2cf55 in collect_stack_sample_timed () at components-rs/../profiling/src/profiler/mod.rs:1158 \#24 0x00007742bea2d087 in collect_time () at components-rs/../profiling/src/profiler/mod.rs:1182 \#25 0x00007742bea35d9a in ddog_php_prof_interrupt_function_wrapper () at components-rs/../profiling/src/wall_time.rs:308 \#26 0x00005b150b5ba079 in zend_interrupt_helper_SPEC () at /root/php/sources/8.5.0/Zend/zend_vm_execute.h:4027 \#27 0x00005b150b69fb6f in execute_ex (ex=0x7742bf013590) at /root/php/sources/8.5.0/Zend/zend_vm_execute.h:116152 \#28 0x00005b150b57cea5 in zend_call_function (fci=0x5b15381ade70, fci_cache=0x5b1538220230) at /root/php/sources/8.5.0/Zend/zend_execute_API.c:1010 \#29 0x00007742be4d7e7e in plugin_get_metadata (ptr=0x7742bf003190, context=..., cb=<optimized out>, user_data=<optimized out>, creds_md=0x77427a7fb0a0, num_creds_md=0x77427a7fb068, status=0x77427a7fb064, error_details=0x77427a7fb058) at /tmp/grpc-php-8.5-release.EUD4iV/src/php/ext/grpc/call_credentials.c:169 \#30 0x00007742be03098f in grpc_plugin_credentials::GetRequestMetadata (this=0x5b153821d660, initial_metadata=..., args=<optimized out>) at /tmp/grpc-php-8.5-release.EUD4iV/src/core/credentials/call/plugin/plugin_credentials.cc:162 \#31 0x00007742be19c295 in grpc_core::ClientAuthFilter::GetMetadataFromCreds (this=<optimized out>, creds=..., md=...) at ./src/core/filter/auth/auth_filters.h:61 \#32 grpc_core::ClientAuthFilter::GetCallCredsMetadata(std::__1::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter>)::{lambda()#1}::operator()()::{lambda()#1}::operator()() const (this=<optimized out>) at ./src/core/filter/auth/auth_filters.h:80 \#33 grpc_core::promise_detail::PromiseLike<grpc_core::Map<grpc_core::ArenaPromise<absl::lts_20250512::StatusOr<std::__1::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter> > >, grpc_core::ClientAuthFilter::GetMetadataFromCreds(grpc_core::RefCountedPtr<grpc_call_credentials>, std::__1::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter>)::{lambda(absl::lts_20250512::StatusOr<std::__1::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter> >)#1}>, void>::PromiseLike<grpc_core::ClientAuthFilter::GetCallCredsMetadata(std::__1::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter>)::{lambda()#1}::operator()()::{lambda()#1}>(std::__1::in_place_t, grpc_core::ClientAuthFilter::GetCallCredsMetadata(std::__1::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter>)::{lambda()#1}::operator()()::{lambda()#1}&&) (this=0x77427a7fb270, f=...) at ./src/core/lib/promise/detail/promise_like.h:219 \#34 grpc_core::promise_detail::PromiseFactoryImpl<grpc_core::promise_detail::OnceToken, grpc_core::ClientAuthFilter::GetCallCredsMetadata(std::__1::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter>)::{lambda()#1}::operator()()::{lambda()#1}>(grpc_core::promise_detail::OnceToken, grpc_core::ClientAuthFilter::GetCallCredsMetadata(std::__1::unique_ptr<grpc_metadata_batch, grpc_core::Arena::PooledDeleter>)::{lambda()#1}::operator()()::{lambda()#1}&&) (f=...) at ./src/core/lib/promise/detail/promise_factory.h:221 ```

jcchavezs force-pushed the adds_tags_n_types branch from ceef98a to 00cecfa Compare February 9, 2018 14:40

Adds tags and types.

648230b

jcchavezs force-pushed the adds_tags_n_types branch from 00cecfa to 648230b Compare February 9, 2018 14:49

palazzem self-requested a review February 9, 2018 15:08

palazzem added the 🍏 core Changes to the core tracing functionality label Feb 9, 2018

palazzem added this to the 0.1.0 milestone Feb 9, 2018

palazzem approved these changes Feb 14, 2018

View reviewed changes

jcchavezs merged commit c5b097a into master Feb 14, 2018

jcchavezs deleted the adds_tags_n_types branch March 21, 2018 07:14

maxcountryman reviewed Jul 23, 2018

View reviewed changes

derickr mentioned this pull request Dec 7, 2023

[Bug]: Segmentation fault when running symfony/console help with Xdebug 3.3.0 enabled #2415

Closed

elzekool mentioned this pull request Apr 17, 2024

[Bug]: CLI PHP Processes do not stop and with Apache (mod_php) the connection is closed unexpectedly #2629

Closed

morrisonlevi mentioned this pull request Jan 11, 2026

experiment: detect re-entrancy in ddtrace_serialize_closed_spans #3562

Closed

2 tasks

ricdizio mentioned this pull request Jun 10, 2026

[Bug]: SIGBUS core dumps in Laravel Horizon on Alpine ARM64 with PHP 8.5 and dd_writer_loop in backtrace #3975

Open

Navigation Menu

Adds tags and types. - #4

Adds tags and types.#4
jcchavezs merged 1 commit into
masterfrom
adds_tags_n_types

jcchavezs commented Feb 9, 2018

Uh oh!

palazzem Feb 9, 2018

Uh oh!

jcchavezs Feb 14, 2018

Uh oh!

maxcountryman Jul 23, 2018

Uh oh!

chuck Jul 25, 2018

Uh oh!

maxcountryman Jul 23, 2018

Uh oh!

chuck Jul 25, 2018

Uh oh!

jcchavezs commented Jul 25, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jcchavezs commented Feb 9, 2018

Uh oh!

palazzem Feb 9, 2018

Choose a reason for hiding this comment

Uh oh!

jcchavezs Feb 14, 2018

Choose a reason for hiding this comment

Uh oh!

maxcountryman Jul 23, 2018

Choose a reason for hiding this comment

Uh oh!

chuck Jul 25, 2018

Choose a reason for hiding this comment

Uh oh!

maxcountryman Jul 23, 2018

Choose a reason for hiding this comment

Uh oh!

chuck Jul 25, 2018

Choose a reason for hiding this comment

Uh oh!

jcchavezs commented Jul 25, 2018 via email

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants