[CONTP-2114] send config in helm metadata as json vs yaml - #3500
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This comment has been minimized.
This comment has been minimized.
nlchung
marked this pull request as ready for review
September 22, 2026 18:41
gabedos
approved these changes
Sep 23, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the Helm release configuration fields in the operator's Helm metadata forwarder payload (
helm_provided_configuration,helm_full_configuration) from YAML-serialized strings to JSON-serialized strings.Motivation
CONTP-2114: the outbound
datadog_operator_helm_metadatapayload is JSON everywhere except these two fields, which were serialized withyaml.Marshalinstead ofjson.Marshal. This made the values harder to query/parse downstream (e.g. in Metabase) since consumers have to YAML-parse a string field instead of reading normal JSON.Additional Notes
ReleaseSnapshot/HelmReleaseData/HelmMetadatafieldsProvidedValuesYAML/FullValuesYAMLare renamed toProvidedValues/FullValues. They remainstring-typed; the change is in how the value itself is produced (json.Marshalinstead ofyaml.Marshal), sohelm_provided_configuration/helm_full_configurationare still emitted as JSON string fields in the payload, but the string content is now JSON-formatted instead of YAML-formatted.Describe your test plan
go test ./pkg/controller/utils/metadata/...— existing suite updated and passing.buildSnapshot/buildPayloaddirectly and prints the JSON, confirminghelm_provided_configuration/helm_full_configurationnow contain JSON-formatted content instead of YAML.Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel