Skip to content

[CONTP-2114] send config in helm metadata as json vs yaml - #3500

Merged
nlchung merged 4 commits into
mainfrom
nlchung/fix-yaml-json
Sep 23, 2026
Merged

nlchung merged 4 commits into
mainfrom
nlchung/fix-yaml-json

Conversation

@nlchung

@nlchung nlchung commented Sep 22, 2026 •

Copy link
Copy Markdown
Contributor

What does this PR do?

Changes the Helm release configuration fields in the operator's Helm metadata forwarder payload (helm_provided_configuration, helm_full_configuration) from YAML-serialized strings to JSON-serialized strings.

Motivation

CONTP-2114: the outbound datadog_operator_helm_metadata payload is JSON everywhere except these two fields, which were serialized with yaml.Marshal instead of json.Marshal. This made the values harder to query/parse downstream (e.g. in Metabase) since consumers have to YAML-parse a string field instead of reading normal JSON.

Additional Notes

ReleaseSnapshot/HelmReleaseData/HelmMetadata fields ProvidedValuesYAML/FullValuesYAML are renamed to ProvidedValues/FullValues. They remain string-typed; the change is in how the value itself is produced (json.Marshal instead of yaml.Marshal), so helm_provided_configuration/helm_full_configuration are still emitted as JSON string fields in the payload, but the string content is now JSON-formatted instead of YAML-formatted.

Describe your test plan

  • go test ./pkg/controller/utils/metadata/... — existing suite updated and passing.
  • Manually verified the outgoing payload shape via a local test that calls buildSnapshot/buildPayload directly and prints the JSON, confirming helm_provided_configuration/helm_full_configuration now contain JSON-formatted content instead of YAML.
  • Manually verified in PUP that the field is now appearing in json as intended

Checklist

  • PR has at least one valid label: bug, enhancement, refactoring, documentation, tooling, and/or dependencies
  • PR has a milestone or the qa/skip-qa label
  • All commits are signed (see: signing commits)

@nlchung
nlchung requested a review from a team September 22, 2026 15:13
@nlchung
nlchung marked this pull request as draft September 22, 2026 15:13
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-22T18:43:51.513993Z 12bf563 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@datadog-datadog-prod-us1

This comment has been minimized.

@nlchung nlchung self-assigned this Sep 22, 2026
@nlchung nlchung added this to the v1.31.0 milestone Sep 22, 2026
@nlchung nlchung added the enhancement New feature or request label Sep 22, 2026
@nlchung
nlchung marked this pull request as ready for review September 22, 2026 18:41
@nlchung
nlchung merged commit 55bb4bc into main Sep 23, 2026
40 checks passed
@nlchung
nlchung deleted the nlchung/fix-yaml-json branch September 23, 2026 19:16
gh-worker-dd-mergequeue-cf854d Bot pushed a commit that referenced this pull request Sep 23, 2026
)

[CONTP-2114] send config in helm metadata as json vs yaml (#3500)

* switched from yaml to json within helm metadata fields

(cherry picked from commit 55bb4bc)

Co-authored-by: nlchung <nchung@live.com>
Co-authored-by: nicole.chung <nicole.chung@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants