Test floating constants in IDL_Test

[jwillemsen]

Summary

• Add float and double IDL constants to interface and valuetype scopes.
• Check module, interface, and valuetype floating constants against C++ literals of the matching type.

The double values use decimal literals whose float-rounded value differs, so this test catches a generator that adds an F suffix to a declared double constant. This extends the IDL input also used by TAOX11 regeneration.

Verification

• Reviewed the two-file diff against current ACE_TAO master.
• Full ACE/TAO build and IDL_Test run were not available in this workspace.

Summary by CodeRabbit

• Tests
  • Added coverage for floating-point constants in root, interface, and valuetype declarations.

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 7826c170-4a7c-4c06-a2d8-40107d7f54d6

📥 Commits

Reviewing files that changed from the base of the PR and between 15f775d and 7b0e339.

📒 Files selected for processing (2)

• TAO/tests/IDL_Test/constants.idl
• TAO/tests/IDL_Test/main.cpp

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

Walkthrough

The IDL test adds floating-point constants to an interface and a valuetype. A new test checks generated floating-point constants in root, interface, and valuetype scopes.

Changes

Floating-Point Constant Tests

Layer / File(s)	Summary
Declare and check floating-point constants TAO/tests/IDL_Test/constants.idl, TAO/tests/IDL_Test/main.cpp	The IDL adds float and double constants to the interface and a float constant to the valuetype. The new test checks root, interface, and valuetype floating-point constants. ACE_TMAIN runs the test after test_expressions.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 7b0e3

The added tests check floating-point IDL constants across scopes and detect accidental narrowing of the tested doubles. No actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 …	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the main change: adding tests for floating-point constants in IDL_Test.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks each constant’s place
Float and double pass the test
Root and interface join the race
Valuetype values do their best
Then hops away, its work complete}

_{Comment @coderabbitai help to get the list of available commands.}

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}