Cleanup/ace hex dump constants

[jwillemsen]

Summary by CodeRabbit

• Refactor
  • Clarified the internal formatting logic for hexadecimal output. The displayed layout and behavior remain unchanged.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 223ab388-29cf-4b19-b027-0ffe3dad7634

📥 Commits

Reviewing files that changed from the base of the PR and between 3cbb30e and fceb267.

📒 Files selected for processing (1)

• ACE/ace/ACE.cpp

Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review.

---

Walkthrough

ACE::format_hexdump now uses named constants for line and group sizes in its full-line and partial-line formatting loops. The emitted output remains unchanged.

Changes

Hexdump formatting

Layer / File(s)	Summary
Full-line and partial-line formatting ACE/ace/ACE.cpp	The formatter uses named constants for byte indexing, line bounds, and group spacing. It renames maxlen to max_input_bytes. The output layout remains unchanged.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to fceb2

This cleanup preserves the hexdump output, and no actionable merge-blocking risk is evident.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly identifies the cleanup of constants in the ACE hex dump implementation. It is concise and matches the main change.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{A rabbit checks the bytes in rows
And counts the groups as each one goes
Named constants mark the line
The output stays in place and fine
Then off through clover, soft and slow}

_{Comment @coderabbitai help to get the list of available commands.}

[mergify]

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

• Queue this pull request

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity

Metric	Results
Complexity	0

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}