Template quality m1.md - #240
Open
PUSHPAK-JAISWAL wants to merge 12 commits into
Open
PUSHPAK-JAISWAL wants to merge 12 commits into
PUSHPAK-JAISWAL wants to merge 12 commits into
Conversation
- Put pre-commit under [dependency-groups].dev so uv-workspace virtual roots do not get a nameless [project] table - Align fastapi-opentelemetry with fastapi-sentry (helper + docs wire-up; no config/main overwrite); fix import order; honor OTLP endpoint - Fix README flags (--no-interactive) and bump ruff-pre-commit pin Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #233
Expanded
docs/TEMPLATE_QUALITY_M1.mdfrom a FastAPI-only quality reference into a complete quality coverage document for all nine templates.Changes include:
QUALITY.mdand formal M1 status.celery-worker,cli-starter,glue-etl-job, anduv-workspace-starter.glue-etl-jobas the newest template requiring a formal M1 bar.No runtime dependencies were added.
Type of Change
How Has This Been Tested?
python scripts/ci/validate-registry.pypython scripts/ci/generate-matrix.py --layer validate-profilesuvx create-awesome-python-app --template file://...)uv run ruff check ./uv run mypy ./uv run pytestin generated project (if applicable)Checklist
slugintemplates.jsonurlpoints to the correct path on themainbranchslugis globally unique across templates and extensionsname,slug,description,url,type,category,labelstypeis an array if it supports multiple template types