Repository navigation
chore(deps): take nextcloud-vue 3.2.0 and drop the local connection formatters - #710
Merged
Merged
Conversation
…ormatters nextcloud-vue 3.2.0 ships connectionStatus and connectionSettingsLabel as built-ins, including the seventh status, disabled (Switched off). The local copy knew six statuses and would have shadowed the built-in, so it goes, and so do the tests that only covered it. One test now proves App.vue passes no formatter of its own and the built-in labels disabled as Switched off. Refs ConductionNL/hydra#677, ConductionNL/nextcloud-vue#1173, #1175
Contributor
Quality Report — ConductionNL/zaakafhandelapp @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ❌ | ||||
| format | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 651/651 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ✅ | ||||
| Hydra gates (axe) | ✅ |
Quality workflow — 2026-09-15 19:29 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Zaakafhandelapp now takes
@conduction/nextcloud-vue3.2.0, which ships the Integrations page's two formatters as built-ins. The local copies are gone. A connection an admin switched off now reads "Switched off" instead of the raw worddisabled.Part of hydra#677 (connection-registry design D8). The library side is nextcloud-vue#1173, released through #1175.
Version
@conduction/nextcloud-vue^2.38.0(lockfile 2.38.0) to^3.2.0(lockfile 3.2.0).npm installran without--legacy-peer-depsand without peer warnings.8b39100f, matching the release run) before bumping.builtInFormatters.jsmapsdisabledto "Switched off", andl10n/nl.jsoncarries "Uitgeschakeld".What changed
src/services/connectionRegistry.jskeeps only the Add integration handler.CONNECTION_STATUS_LABELSandcreateConnectionFormattersare deleted.src/App.vueno longer passes:formatterstoCnAppRoot. Zaakafhandelapp has no other formatter, so the built-ins answer every column.tests/vitest/connectionRegistry.spec.js: the four tests that only covered the local copy are removed. The l10n test keeps the labels the page itself declares and drops the status labels the app no longer translates. The column name check resolves againstBUILT_IN_FORMATTERS, and the wiring check keeps only the handler.App.vuepasses no:formattersof its own, since an app formatter wins over a built-in. The built-in mapsdisabledto "Switched off".@vitest-environment jsdom), because@nextcloud/l10nreads the browser session on import.l10n/. Nothing reads them now, and removing catalogue entries is its own change.Mutation check. On the committed code I restored the previous
App.vueand six-statusconnectionRegistry.js. The new test went red on its assertion line (App.vue passes its own formatters, spec line 39). Restored, green.What 3.x touches here
CnNewsWidget,CnNewsWidgetFormand thenewswidget type are gone. Zaakafhandelapp uses none of them: no import, no"news"type in any manifest.CHANGELOG.md. I read it from nextcloud-vuemaininstead.tilewidget.headerActionsmove into the Actions menu. No detail page declaresheaderActions.navigateactions now open as links. The manifests declare nonavigateaction.marked,dompurifyanddexieare required peers again. Zaakafhandelapp already declares all three.Verification
npm run build: exit 0.npm run lint: exit 0, 0 errors, 257 warnings. The diff check finds none in a file this PR touches.npx vitest run: exit 0, 5 files, 40 tests.npm test(jest): exit 0, 24 suites, 43 tests.hydra/scripts/diff-check.sh --base origin/developmentwithHYDRA_GATES_HOMEon the vendored gates: exit 0, GREEN. Gates, phpunit, eslint and stylelint report 0 new and 0 inherited findings.COMPOSER_PROCESS_TIMEOUT=0 composer check:strict(per-laneTMPDIRandHOME): exit 0, "ALL CHECKS PASSED", PHPUnit 328 tests.Not verified
occ. I did not see the Integrations page render with 3.2.0, nor any other page after a major version bump.Inherited
None on the lines this PR touches. The 257 lint warnings sit in files this PR does not change.
🤖 Generated with Claude Code