Skip to content

chore(deps): take nextcloud-vue 3.2.0 and drop the local connection formatters - #710

Merged
rubenvdlinde merged 1 commit into
developmentfrom
chore/built-in-connection-formatters
Sep 16, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
chore/built-in-connection-formatters

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Zaakafhandelapp now takes @conduction/nextcloud-vue 3.2.0, which ships the Integrations page's two formatters as built-ins. The local copies are gone. A connection an admin switched off now reads "Switched off" instead of the raw word disabled.

Part of hydra#677 (connection-registry design D8). The library side is nextcloud-vue#1173, released through #1175.

Version

  • @conduction/nextcloud-vue ^2.38.0 (lockfile 2.38.0) to ^3.2.0 (lockfile 3.2.0).
  • npm install ran without --legacy-peer-deps and without peer warnings.
  • I unpacked the published 3.2.0 tarball (shasum 8b39100f, matching the release run) before bumping. builtInFormatters.js maps disabled to "Switched off", and l10n/nl.json carries "Uitgeschakeld".

What changed

  • src/services/connectionRegistry.js keeps only the Add integration handler. CONNECTION_STATUS_LABELS and createConnectionFormatters are deleted.
  • src/App.vue no longer passes :formatters to CnAppRoot. Zaakafhandelapp has no other formatter, so the built-ins answer every column.
  • tests/vitest/connectionRegistry.spec.js: the four tests that only covered the local copy are removed. The l10n test keeps the labels the page itself declares and drops the status labels the app no longer translates. The column name check resolves against BUILT_IN_FORMATTERS, and the wiring check keeps only the handler.
  • One new test checks two things. App.vue passes no :formatters of its own, since an app formatter wins over a built-in. The built-in maps disabled to "Switched off".
  • The spec now runs in jsdom (@vitest-environment jsdom), because @nextcloud/l10n reads the browser session on import.
  • The status labels stay in l10n/. Nothing reads them now, and removing catalogue entries is its own change.

Mutation check. On the committed code I restored the previous App.vue and six-status connectionRegistry.js. The new test went red on its assertion line (App.vue passes its own formatters, spec line 39). Restored, green.

What 3.x touches here

  • 3.0.0 breaking change. CnNewsWidget, CnNewsWidgetForm and the news widget type are gone. Zaakafhandelapp uses none of them: no import, no "news" type in any manifest.
  • The tarball has no CHANGELOG.md. I read it from nextcloud-vue main instead.
  • Untinted tiles. Zaakafhandelapp declares no tile widget.
  • Detail page headerActions move into the Actions menu. No detail page declares headerActions.
  • External navigate actions now open as links. The manifests declare no navigate action.
  • marked, dompurify and dexie are required peers again. Zaakafhandelapp already declares all three.

Verification

  • npm run build: exit 0.
  • npm run lint: exit 0, 0 errors, 257 warnings. The diff check finds none in a file this PR touches.
  • npx vitest run: exit 0, 5 files, 40 tests.
  • npm test (jest): exit 0, 24 suites, 43 tests.
  • hydra/scripts/diff-check.sh --base origin/development with HYDRA_GATES_HOME on the vendored gates: exit 0, GREEN. Gates, phpunit, eslint and stylelint report 0 new and 0 inherited findings.
  • COMPOSER_PROCESS_TIMEOUT=0 composer check:strict (per-lane TMPDIR and HOME): exit 0, "ALL CHECKS PASSED", PHPUnit 328 tests.

Not verified

  • No browser, no instance, no occ. I did not see the Integrations page render with 3.2.0, nor any other page after a major version bump.

Inherited

None on the lines this PR touches. The 257 lint warnings sit in files this PR does not change.

🤖 Generated with Claude Code

…ormatters

nextcloud-vue 3.2.0 ships connectionStatus and connectionSettingsLabel as
built-ins, including the seventh status, disabled (Switched off). The local
copy knew six statuses and would have shadowed the built-in, so it goes, and
so do the tests that only covered it. One test now proves App.vue passes no
formatter of its own and the built-in labels disabled as Switched off.

Refs ConductionNL/hydra#677, ConductionNL/nextcloud-vue#1173, #1175
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/zaakafhandelapp @ eed34a7

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ❌
format ❌
composer ✅ ✅ 100/100
npm ✅ ✅ 651/651
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ✅
Newman ✅
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test.
Hydra gates ✅
Hydra gates (axe) ✅

Quality workflow — 2026-09-15 19:29 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 774c595 into development Sep 16, 2026
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant