Skip to content

Bump @nextcloud/stylelint-config from 2.4.0 to 3.0.1 - #1

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/nextcloud/stylelint-config-3.0.1
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/nextcloud/stylelint-config-3.0.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 11, 2024

Copy link
Copy Markdown
Contributor

Bumps @nextcloud/stylelint-config from 2.4.0 to 3.0.1.

Release notes

Sourced from @​nextcloud/stylelint-config's releases.

v3.0.1

v3.0.1 (2024-05-07)

Fixed

  • fix: Remove stylistic rules also for scss

v3.0.0

v3.0.0 (2024-04-15)

Full Changelog

Breaking changes 💥

stylelint was updated to version 16.0 which drops all stylistic changes. The means stylelint only will check for code quality but not for stylistic rules. So it is now recommended to instead use prettier with @nextcloud/prettier-config for stylistic rules. See also Nextcloud prettier setup.

Changed

  • Updated stylelint and require stylelint version 16.2.0 or later.
Changelog

Sourced from @​nextcloud/stylelint-config's changelog.

v3.0.1 (2024-05-07)

Fixed

  • fix: Remove stylistic rules also for scss

v3.0.0 (2024-04-15)

Full Changelog

Breaking changes 💥

stylelint was updated to version 16.0 which drops all stylistic changes. The means stylelint only will check for code quality but not for stylistic rules. So it is now recommended to instead use prettier with @nextcloud/prettier-config for stylistic rules. See also Nextcloud prettier setup.

Changed

  • Updated stylelint and require stylelint version 16.2.0 or later.
Commits
  • 2021fc9 Merge pull request #104 from nextcloud-libraries/chore/3-0-1
  • 9a55b02 chore: Prepare 3.0.1
  • a910b74 Merge pull request #102 from nextcloud-libraries/core/workflows
  • affe632 Merge pull request #103 from nextcloud-libraries/dependabot/npm_and_yarn/styl...
  • 390c1f6 chore(deps-dev): Bump stylelint from 16.4.0 to 16.5.0
  • d067ae3 Merge pull request #101 from nextcloud-libraries/fix/stylistic-rules
  • c8b4324 fix(ci): Update workflows from organization
  • 5e228d7 fix: Remove stylistic rules
  • b10dfcd Merge pull request #99 from nextcloud-libraries/chore/prepare-3-0-0
  • c147c13 chore: Prepare 3.0.0 release
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@nextcloud/stylelint-config](https://github.com/nextcloud/stylelint-config) from 2.4.0 to 3.0.1.
- [Release notes](https://github.com/nextcloud/stylelint-config/releases)
- [Changelog](https://github.com/nextcloud-libraries/stylelint-config/blob/main/CHANGELOG.md)
- [Commits](nextcloud-libraries/stylelint-config@v2.4.0...v3.0.1)

---
updated-dependencies:
- dependency-name: "@nextcloud/stylelint-config"
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jun 11, 2024
@remko48 remko48 closed this Jun 11, 2024
@dependabot @github

dependabot Bot commented on behalf of github Jun 11, 2024

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/nextcloud/stylelint-config-3.0.1 branch June 11, 2024 12:43
rubenvdlinde added a commit that referenced this pull request Sep 8, 2026
…k` (#663)

Creating a zaakinformatieobject 500s where dossiq is installed:

  ZGWLogicService::createOio(): Argument #1 ($objectUrl) must be of type
  string, null given

Two producers write a ZIO and they disagree about the property name. This app's
own ZaakInformatieObjectenController requires `zaak`. Dossiq's
ZgwZrcZaakinformatieobjectRules stores `case` (storedKey: 'case'). Reading only
`zaak` therefore handed null into a parameter typed string, and the error named
createOio's argument rather than the property that was missing.

It reproduces only where both apps are installed, which is why CI does not see
it and why it survived this long.

A single zioCaseUrl() helper now resolves either key, and both ZIO sites use it:
createObjectInformatieObjectZaak, and the ZIO branch of
deleteObjectInformatieObject, which would otherwise have left the OIO behind
instead of failing loudly. When neither key is present it throws naming both,
because that is a broken record rather than a producer disagreement.

createZaakBesluit reads a besluit's own `zaak` and is untouched: dossiq ships no
besluit rules.

Verified: three new tests cover the dossiq key, this app's key, and the
neither-key case. Reverting the fix makes the dossiq one fail, so the guard is
real. Full suite 290 tests exit 0 at 46 MB; phpcs exit 0 with 37 pre-existing
warnings on untouched lines.

Co-authored-by: Conduction Release Bot <release-bot@conduction.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant