Skip to content

ci(quality): unpin hydra-gates — a pin cannot carry a fix made after it was cut - #233

Closed
rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/unpin-hydra-gates
Closed

rubenvdlinde wants to merge 1 commit into
developmentfrom
chore/unpin-hydra-gates

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Reopens the work from #230, which I closed by accident while batch-merging the fleet sweep. The branch is unchanged and rebased onto current development.

nldesign is the last repo still carrying hydra-gates-ref, and the pin now actively costs more than it buys.

Why unpin rather than bump again

development moved v1.3.0 → v1.5.0 while this branch was open, which fixes the symptom that opened it: v1.5.0 satisfies #177's capability probe, so Hydra Gates no longer fails before a gate runs.

But v1.5.0 carries a fleet-wide falsely-RED gate. gate-28 license-triangle reported a structural coverage gap whenever the diff scope was empty — i.e. on every PR that does not touch lib/**/*.php, which is most of them. With hydra-gates-require-full-coverage defaulting TRUE, that is exit 98. Fixed in ConductionNL/.github#182, on main. A repo pinned to v1.5.0 cannot see that fix, and the tag will not move.

That is the whole argument for #177's contract in one branch: pinned at v1.3.0, bumped to v1.5.0 to clear one breakage, and a third commit would have been needed for the next.

Measured here, against the real runner

diff before after
.github/workflows/code-quality.yml SKIPPED (structural) → exit 98 NOT APPLICABLE
3 files under lib/ PASS PASS
a lib/*.php declaring AGPL vs composer's EUPL-1.2 — FAIL — 1 file(s)

Verified on this branch's own run after the unpin: Hydra Gates PASS in 20s, 58 applicable gates green, 5 correctly NOT APPLICABLE.

Rollback for this repo alone stays available: set hydra-gates-ref: explicitly. An escape hatch, not a resting state.

…it was cut

development moved from v1.3.0 to v1.5.0 while this branch was open, which
fixes the symptom that opened it: v1.5.0 satisfies #177's capability probe,
so Hydra Gates no longer fails before a gate runs. Unpinning entirely still
matters, and the reason is now sharper than when this branch started.

v1.5.0 carries a fleet-wide falsely-RED gate. gate-28 license-triangle
reported a `structural` coverage gap whenever the diff scope was empty —
that is, on every PR that does not touch lib/**/*.php, which is most of
them — because "no file in scope" and "files in scope, none carried a
licence declaration" reached the same branch. With
hydra-gates-require-full-coverage defaulting TRUE, that is exit 98.

It is fixed in ConductionNL/.github#182, on main. A repo pinned to v1.5.0
cannot see that fix, and the tag will not move. Measured here against the
real runner, three arms:

    diff = .github/workflows/code-quality.yml   before SKIPPED(structural)
                                                after  NOT APPLICABLE
    diff = 3 files under lib/                   PASS, both
    diff = a lib/*.php declaring AGPL while
           composer.json declares EUPL-1.2      FAIL — 1 file(s)

That is the whole argument for #177's contract in one branch: this repo was
pinned at v1.3.0, bumped to v1.5.0 to clear one breakage, and would have
needed a third commit to clear the next one. A pin is a silent expiry date
on every upstream fix.

Verified on this PR's own run after the unpin: Hydra Gates PASS in 20s,
58 applicable gates green, 5 correctly NOT APPLICABLE.

Rollback for this repo alone stays available: set hydra-gates-ref
explicitly. An escape hatch, not a resting state.
@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/nldesign @ 4d9b71f

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ✅
composer ✅ ✅ 100/100
npm ✅ ✅ 2/2
PHPUnit ✅
Newman ❌
Playwright ❌
Hydra gates ✅

Quality workflow — 2026-08-06 08:14 UTC

Download the full PDF report from the workflow artifacts.

@github-actions

github-actions Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/nldesign @ 4d9b71f

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ✅
composer ✅ ✅ 100/100
npm ✅ ✅ 2/2
PHPUnit ✅
Newman ❌
Playwright ❌
Hydra gates ✅

Quality workflow — 2026-08-06 08:32 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Already applied. development no longer carries hydra-gates-ref — verified at , where grep -cP '^\s+hydra-gates-ref:' .github/workflows/code-quality.yml returns 0. The rebase conflicts precisely because the change is already in.

All 17 gate-enabled repos in the fleet are now unpinned and tracking main, so they receive ConductionNL/.github#182 (the gate-28 empty-diff-scope fix) without a further commit each — which was the point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant