Skip to content

feat(tokens): ship Sittard-Geleen and Vidar, built from their upstream generators - #1719

Open
rubenvdlinde wants to merge 9 commits into
developmentfrom
feat/token-sync-generated-themes
Open

rubenvdlinde wants to merge 9 commits into
developmentfrom
feat/token-sync-generated-themes

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Sittard-Geleen and Vidar are in nl-design-system/themes but were never in thematiq. Upstream generates both in TypeScript (src/build-theme.mts, Vidar on top of Sittard-Geleen) and keeps no token files for them, so the sync skipped them with "no *.tokens.json files upstream". Stacked on #1714; it contains that PR's commits and should merge after it.

Change

  • The nightly job runs on Node 24 (the themes workspace requires ^24.22.3; thematiq's engines allow ^24). A new step finds every proprietary/*/src/build-theme.mts, installs only those workspaces (pnpm install --frozen-lockfile --ignore-scripts, filtered), and runs each build. A failed install or build is a warning: that theme stays skipped as before and the rest of the sync goes on.
  • readUpstreamTokens() reads a generated theme's tmp/generated.tokens.json, and when the build did not run it says so in the report instead of "no token files".
  • sittard-geleen and vidar ship as restricted sets. Neither has a licence file of its own: the EUPL-1.2 in the npm package is the themes repository's own licence, copied in at publish. So they get the same "No licence text published" note as Purmerend and Riddeliemers, an entry in the restricted list and the licence table, and a logo allowlist entry (no vendored logo).
  • Both name Roobert (Displaay), a retail typeface with no @fontsource release, so each carries a font block that asks the administrator for an upload.
  • Names are "Gemeente Sittard-Geleen" and "Vidar" rather than the generator's "NL Design System ... Thema"; later syncs keep a name set by hand.
  • Golden fixtures and the shell catalogue are re-recorded for the two sets.

Verified locally

Not verified: the step itself in Actions. It only runs from development (the job checks out development), so the first nightly after merge is its first real run.

Assisted-by: ClaudeCode:claude-opus-5-5

…aan Zee

Upstream builds a theme from src/tokens.json as well as src/*.tokens.json,
and Voorne aan Zee keeps its Tokens Studio export there (its figma/ export
is an empty file). The reader now takes src/tokens.json too, and reads any
file carrying $metadata.tokenSetOrder as a Tokens Studio export.

Voorne aan Zee joins as a restricted set: its LICENSE.md reserves logo and
house style to the municipality, the same text Epe ships. No logo is
vendored, so the coverage allowlist records why the Nextcloud logo stays.
The golden fixtures and the shell catalogue are re-recorded for the new set.

The upstream "example" theme is kept out: thematiq ships its own example-*
sets.

Assisted-by: ClaudeCode:claude-opus-5-5
…m generators

Upstream generates both themes in TypeScript (src/build-theme.mts) and keeps
no token files for them, so the sync skipped them. The nightly job now
installs the themes workspace (Node 24, lifecycle scripts off) and runs each
generated theme's build; the reader takes its tmp/generated.tokens.json, and
names a theme whose build did not run. A failed install or build leaves the
theme skipped and the rest of the sync going.

Neither theme ships a licence file of its own (the EUPL in their npm package
is the themes repository's), so both join as restricted sets with the same
"No licence text published" note as Purmerend. Both name Roobert, a retail
typeface, so each carries a font block asking for an upload. No logo is
vendored; the coverage allowlist says why.

Assisted-by: ClaudeCode:claude-opus-5-5
…c-src-tokens-json

# Conflicts:
#	scripts/sync-upstream-tokens.mjs
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/thematiq @ 68aafa8

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ✅
format ❌
test-fonts ✅
test-token-set-coverage ✅
composer ❌ ✅ 111/111
npm ✅ ✅ 2/2
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ 2938/2945
Newman ✅ 182/182
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 14:53 UTC

Download the full PDF report from the workflow artifacts.

…kip ci]

The upstream theme builds run third-party code, so they now run in their
own job with contents: read and no checkout of this repository. That job
hands only the generated token files to the sync job as an artifact; the
sync job clones the same upstream commit and converts as before.

Assisted-by: ClaudeCode:claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant