Skip to content

chore(openspec): live pass, archive action-menu-links-keep-text-colour and openproject-in-the-app-menu - #1709

Merged
rubenvdlinde merged 3 commits into
developmentfrom
quality/livepass-thematiq-3
Nov 17, 2026
Merged

rubenvdlinde merged 3 commits into
developmentfrom
quality/livepass-thematiq-3

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Second batch from the thematiq live pass on NC 34.0.6.

Live checks that passed

  • action-menu-links-keep-text-colour 2.1. Setup: dossiq 0.4.54-unstable release, a seeded case, set epe. In the case Actions menu, all 13 action buttons and the 3 action links read #2e2e33 (the main text) and none is underlined. The set's link colour #01699d does not appear in the menu.
  • openproject-in-the-app-menu 6. Checked against OpenProject 17.9.1 (image openproject-thematiq:pl, a throwaway container that is now removed). All nine OpenProjectModules::MODULES paths are known routes, and without a session they answer 302 to the login; an unknown path answers 404.
    • Eight of the keys are items of OpenProject's top menu. my_page is not: My page sits in the account menu. The link works either way.

Archived

action-menu-links-keep-text-colour, which folds into css-architecture. openproject-in-the-app-menu becomes a new main spec, with a Purpose and screens. The @spec tags and parity rows point at the main specs.

Verified locally

  • PHPUnit (phpunit-unit.xml): OK (2900 tests, 66748 assertions)
  • vitest on the touched files: actionMenuLinkText 4 passed, appMenu 6 passed.
  • npm run lint: exit 0.
  • openspec validate --specs --strict: the same 19 inherited failures, and the new spec passes.
  • composer check:strict once: phpstan OK. cs:check (50 files), phpmd and psalm fail exactly as they do on development; this PR changes only docblock tags in PHP.

Assisted-by: ClaudeCode:claude-opus-5-5

… live check

On NC 34 with dossiq 0.4.54 and the epe set, every entry of the case Actions menu, the three action links included, reads the main text and none is underlined. The requirement moves into openspec/specs/css-architecture; the vitest @SPEC and the parity row follow it.

Assisted-by: ClaudeCode:claude-opus-5-5
…ts paths on OpenProject

On OpenProject 17.9.1 every module path routes and answers 302 to the login (an unknown path 404). The requirement moves into openspec/specs/openproject-in-the-app-menu; the @SPEC tags and the parity row follow it.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 06f0b5b into development Nov 17, 2026
4 of 6 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/thematiq @ 391731d

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ✅
format ❌
test-fonts ✅
test-token-set-coverage ✅
composer ❌ ✅ 111/111
npm ✅ ✅ 2/2
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ 2905/2912
Newman ✅ 182/182
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 11:38 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant