Repository navigation
chore(openspec): live pass, archive action-menu-links-keep-text-colour and openproject-in-the-app-menu - #1709
Merged
Merged
Conversation
… live check On NC 34 with dossiq 0.4.54 and the epe set, every entry of the case Actions menu, the three action links included, reads the main text and none is underlined. The requirement moves into openspec/specs/css-architecture; the vitest @SPEC and the parity row follow it. Assisted-by: ClaudeCode:claude-opus-5-5
…ts paths on OpenProject On OpenProject 17.9.1 every module path routes and answers 302 to the login (an unknown path 404). The requirement moves into openspec/specs/openproject-in-the-app-menu; the @SPEC tags and the parity row follow it. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/thematiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| test-fonts | ✅ | ||||
| test-token-set-coverage | ✅ | ||||
| composer | ❌ | ✅ 111/111 | |||
| npm | ✅ | ✅ 2/2 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 2905/2912 | ||||
| Newman | ✅ 182/182 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-17 11:38 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second batch from the thematiq live pass on NC 34.0.6.
Live checks that passed
epe. In the case Actions menu, all 13 action buttons and the 3 action links read #2e2e33 (the main text) and none is underlined. The set's link colour #01699d does not appear in the menu.openproject-thematiq:pl, a throwaway container that is now removed). All nineOpenProjectModules::MODULESpaths are known routes, and without a session they answer 302 to the login; an unknown path answers 404.my_pageis not: My page sits in the account menu. The link works either way.Archived
action-menu-links-keep-text-colour, which folds into
css-architecture. openproject-in-the-app-menu becomes a new main spec, with a Purpose and screens. The@spectags and parity rows point at the main specs.Verified locally
phpunit-unit.xml): OK (2900 tests, 66748 assertions)npm run lint: exit 0.openspec validate --specs --strict: the same 19 inherited failures, and the new spec passes.composer check:strictonce: phpstan OK. cs:check (50 files), phpmd and psalm fail exactly as they do on development; this PR changes only docblock tags in PHP.Assisted-by: ClaudeCode:claude-opus-5-5