Repository navigation
feat(shillinq): build budget-known-costs - #3178
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Round 2: the operator-triggered run design.md §12 promises had no entry point; nothing called KnownCostBudgetWriter::run(), so the live e2e pass found no derived budget line to show. - POST /api/v1/budgets/known-costs/regenerate (KnownCostController): runs the writer for the named or active administration; the caller must be allowed to post in it, anyone else gets a masked 404. In openapi.json. - "Regenerate known costs" header action on Budget Line Derivations opens RegenerateKnownCostsModal, which shows created / updated / overridden counts and the fiscal years skipped for want of a default budget. - Tests: KnownCostControllerTest (3), tests/vitest/knownCosts.spec.js (8), and an e2e test that runs it through the dialog first. - en/nl strings added and the l10n .js rebuilt. Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Round 2 build of
openspec/changes/budget-known-costs. Design §12 says the change ships an operator-triggered run, but nothing calledKnownCostBudgetWriter::run(): no route, no job and no button. The live e2e pass skipped 3 of its 4 tests for that reason ("KnownCostBudgetWriter has not run for the administration").Tasks done
POST /api/v1/budgets/known-costs/regenerate(KnownCostController::regenerate,#[NoAdminRequired]): runs the writer for theadministrationIdgiven, or the caller's active administration. The caller must be allowed to post in that administration; anyone else gets a masked 404, an anonymous caller a 401, and a failed run a generic 500 that is logged. Documented inopenapi.json(tagknown-cost).openRegenerateKnownCostsinsrc/manifestActions.js) openssrc/modals/RegenerateKnownCostsModal.vue. The dialog shows how many lines were created and updated, how many were left alone because they had been changed by hand, and which fiscal years were skipped for lack of a default budget.l10n/*.jsonand the.jsrebuilt.tests/e2e/budget-known-costs.spec.tsnow opens with a test that runs the regeneration through the dialog, checks the 200 summary and the text it renders, and goes first so the existing row tests can find derived lines.Tasks left, and why
npx playwright test tests/e2e/budget-known-costs.spec.tsagainst a live instance is not run here; no instance is reachable.Tests
KnownCostControllerTest: 3 tests, 11 assertions. Inverting the access check fails all 3.tests/vitest/knownCosts.spec.js: 8 tests. A deliberate break of the summary logic is caught.dunningNextRun.spec.js"switches it on by the property the job reads". It fails the same way on development.check-l10n,l10n-parity,dutch-tokens,check:l10n-js,validate-manifestandvalidate-manifest-shellpass.routes.phpstays at its baseline count.check:manifest-budget(over its budget before this PR; this fragment adds 343 B) andcheck:nav-reachability(CustomRecords).Generated by Claude Code