Repository navigation
feat(shillinq): build reporting-cash-flow-statement - #3177
Open
rubenvdlinde wants to merge 6 commits into
Open
rubenvdlinde wants to merge 6 commits into
rubenvdlinde wants to merge 6 commits into
Conversation
The cash flow calculator by the indirect method over the statement calculator (task 2.1), GET /api/statements/cash-flow with the statement endpoints' checks (task 2.2), and Account.cashFlowCategory (task 1.1, schema part). Assisted-by: ClaudeCode:claude-opus-5-5
Record the Account 0.5.0 register move under app version 0.5.7-unstable.20261117153000 and document GET /api/statements/cash-flow in openapi.json. Assisted-by: ClaudeCode:claude-opus-5-5
The annual accounts gain a kasstroomoverzicht from the cash flow calculator and keep it as the annual report's CashFlowStatement with method indirect (task 3.2). Assisted-by: ClaudeCode:claude-opus-5-5
The cash flow statement page with its Reports card and the account check page (tasks 1.1, 3.1 in part), Dutch and English strings (task 4.2), and the tasks ticked. Assisted-by: ClaudeCode:claude-opus-5-5
Write the Playwright spec of task 4.1: the reconciliation on the statement endpoint, the page and its account check, and a figure click. Assisted-by: ClaudeCode:claude-opus-5-5
Task 3.1: every cash flow figure opens the posted ledger lines behind it. Each row carries a linesKey (account, result or depreciation, and the range); GET /api/statements/cash-flow/lines returns the lines, which add up to the figure, behind the same administration check as the statement. The new CashFlowLines page reads it from its route and opens each line's transaction. Unit tests for the calculator and controller, a vitest contract over the manifest, and the e2e figure step follows the new page. Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/reporting-cash-flow-statement: a cash flow statement by the indirect method from posted ledger lines, shown as its own page and carried into the annual accounts.Tasks done
Account.cashFlowCategory(cash,working-capital,fixed-assets,financing,equity) inlib/Settings/register.d/zz-reporting-cash-flow-statement.json, Account 0.5.0. The fragment is namedzz-so its schema version is the last one merged. The app version moves to 0.5.7-unstable.20261117153000 and the lock records it. PageCashFlowAccountChecklists the balance accounts without a category and opens each one on its account page. Seed: account 1000 inbookkeeping-sbr-xbrl-reporting.jsonisworking-capital. The three seed accounts inshillinq_register.jsonstay unclassified, because ADR-037 says not to edit that file. 1300 Debiteuren is the spec's own example for the check page.lib/Reporting/CashFlowCalculator.php::between()over two newStatementCalculatormethods,cashFlowMovements()andaccountsByNumber():journalType: closing) are left out on both sides.GET /api/statements/cash-flow?from&to&administrationIdonFinancialStatementController, with the same checks as the other statements: 401 without a user, 400 for a bad range or no administration, and a masked 404 for another administration before anything is read. It is documented inopenapi.json.FinancialStatementCashFlowdashboard (/reports/cash-flow, with a date range) and its card on the Reports page.AnnualAccountsReportGeneratoradds a kasstroomoverzicht from the same calculator. It is followed by a reconciliation table.CashFlowStatementRecordstores the figures as the annual report'sCashFlowStatementwithmethod: indirect. A draft is updated and a final record is left alone. Without anAnnualReportfor that year, nothing is stored.l10n/*.json; the.jsfiles are regenerated).Tasks left, and why
LedgerLinesForAccountpage belongs toreporting-financial-statementstask 2.3, which is not built yet. Every row already carriesaccountNumber,fromandtofor it.Tests
CashFlowCalculatorTest(7): the design's seed (operating 48,000, investing -12,000, financing -8,000, cash +28,000, opening 20,000 and closing 48,000), the row shape, an unclassified 500, a closing entry inside the period, no depreciation without a fixed asset, and the opening cash.CashFlowStatementRecordTest(4),AnnualAccountsCashFlowTest(4), andFinancialStatementControllerTest(+2: the endpoint and its refusals).dunningNextRun.spec.js) fails on development too.check:manifest,check:manifest-shell,check:registers,check:seeds,test:l10n,test:l10n-parity,check:l10n-jsandopenspec validate --strictpass. phpcs and phpstan are clean on the touched lib files.check:nav-reachability: the new page has a Reports-card entry in the baseline. The two orphans it still reports are on development too.check:manifest-budgetandcheck:schema-l10nalready fail on development; the four new schema strings are covered.Generated by Claude Code