Repository navigation
feat(shillinq): build people-ib47-statement - #3176
Open
rubenvdlinde wants to merge 5 commits into
Open
rubenvdlinde wants to merge 5 commits into
rubenvdlinde wants to merge 5 commits into
Conversation
Task 1.1: mark a payee as an IB47 recipient and prepare the year's IB47 records from the payment runs the bank confirmed, one record per payee and year, updated on a rerun. Assisted-by: ClaudeCode:claude-opus-5-5
Task 1.2: a Prepare action on the IB47 annual batch page, through a route open to the payroll officer within the caller's administration. Assisted-by: ClaudeCode:claude-opus-5-5
Document the IB47 prepare route in openapi.json. Assisted-by: ClaudeCode:claude-opus-5-5
Task 2.1: an ib47 report in the catalogue whose generator writes the prepared batch as the statement file. Assisted-by: ClaudeCode:claude-opus-5-5
Write the live pass of task 2.2 as a Playwright spec: both REQ-DPA-021 scenarios through the prepare route and the ib47 statement download. Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build of
openspec/changes/people-ib47-statement(REQ-DPA-021): the annual IB47 batch is filled from the books, and the batch produces the statement file.Tasks done
lib/Settings/register.d/people-ib47-statement.json:Payee.ib47Recipient, plusPayee.bsn(11-proef, masked, payroll officer only) andPayee.ib47PaymentTypeCode, which the record requires.IB47Record.payeeIdlets a rerun find its record.lib/Service/Ib47/Ib47BatchService.php:reconciled, i.e. confirmed by the bank. The year is the line's requested execution date, else the run's.incompleteand gets no record. Nothing is written with an invented value.POST /api/ib47/batches/prepare(Ib47Controller):shillinq_payroll_officer(403 otherwise), within an administration the caller holds a membership of (404 otherwise).taxYeardefaults to last year andadministration_idto the active administration, so the batch page's new "Prepare last year's batch" header action needs no form.openapi.json.ib47(IB47-opgaaf, csv) inReportCatalogue.Ib47StatementReportGeneratorwrites the year's final records (no dry runs) and computes nothing itself..jscatalogues rebuilt.Decisions to review
IB47Record.recipientBSN), because the record requires it and nothing else carried it.InboundPayable(markPaid) are not counted yet. Supplier invoices are paid through payment runs, which is what the batch reads.Tasks left
Tests
Ib47BatchServiceTest(7: both scenarios with their numbers, confirmed runs only, line date, other administration, incomplete recipient, refusals),Ib47ControllerTest(9),Ib47StatementReportGeneratorTest(3: prepare then file shows EUR 2,000.00). Mutations of the update-in-place, the year filter, both controller guards and the dry-run filter each turn a test red.test:l10n,test:l10n-parity,check:l10n-jsandcheck:manifestpass.Generated by Claude Code