Skip to content

feat(shillinq): build platform-custom-record-types - #3171

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-platform-custom-record-types
Open

rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-platform-custom-record-types

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Builds the one open task of openspec/changes/platform-custom-record-types, which is round 2 for this change. Every code task was already on development.

Tasks done

  • 3.1: wrote tests/e2e/platform-custom-record-types.spec.ts with 4 tests, one per scenario in the change's spec:

    • an administrator's own schema shows up in the admin settings and a shipped one does not; the switch shows it (REQ-CRT-001)
    • a user opens the card, adds a record (nummer, huurder) and opens its detail page (REQ-CRT-002)
    • a typed URL for Invoice shows the not-available state (REQ-CRT-003)
    • a bookkeeper without admin rights gets 403 on PUT and PATCH (REQ-CRT-003). This uses a separate request context with an empty storage state and basic auth.

    The spec creates its fixtures on each run, each with a unique suffix: the schema, its entry in the register, the shown switch and the bookkeeper account. It removes them all in afterAll. The base URL comes from tests/e2e/base-url.ts.

Tasks left

  • 3.1 is still unticked because the spec has not been run yet. Running it needs a live instance.

Tests: eslint is clean on the new file, and playwright test --list lists the 4 tests. No production code changed, so the PHP and vitest suites are not affected.
Suite before/after: unchanged. The change adds one e2e spec file and edits tasks.md.


Generated by Claude Code

Add the Playwright spec task 3.1 names: an administrator adds a schema
to the shillinq register and shows it, a user adds and opens a record,
a typed URL for a shipped schema shows the not-available state, and a
non-admin change is refused with 403. Fixtures are created per run and
removed afterwards.

Assisted-by: ClaudeCode:claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant