Skip to content

feat(shillinq): build banking-fx-at-booking - #3167

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-banking-fx-at-booking
Open

rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-banking-fx-at-booking

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Round 2 of openspec/changes/banking-fx-at-booking. Tasks 1.1 to 3.2 and 5.1 were already on development. This PR adds the Playwright spec that task 4.1 names.

Done

  • tests/e2e/banking-fx-at-booking.spec.ts (3 tests, driven over the API on real objects). It creates its own manual rates, scoped to the admin's administration, and runs the real postDirect transition.
    • REQ-BFX-001: a USD 1,000.00 entry dated Sunday 2026-09-27 books at EUR 915.00. The GL line shows rate 0.9150, source manual and rate date 2026-09-25.
    • REQ-BFX-002: a GBP entry with only a 2026-09-18 rate is refused. The message names GBP and 2026-09-27, and the entry stays a draft with no GL transaction.
    • REQ-BFX-003: a typed rate of 0.9102 with a reason books USD 20,000.00 at EUR 18,204.00, source manual.

Left

  • 4.1 stays unticked until the spec has passed against an instance with ledger-posting-path merged; it has not been run yet. It skips, with the reason, when no administration is configured for the admin.

Tests

  • eslint is clean, and playwright test --list compiles the file (3 tests). Tests only; no production code changed.

Generated by Claude Code

Playwright spec for task 4.1: a Sunday USD entry books at Friday's scoped
rate, a GBP entry with only a stale rate is refused and stays a draft, a
typed rate wins and is recorded as manual.

Assisted-by: ClaudeCode:claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant