Skip to content

[OpenSpec] contacts-kvk-lookup #1925

Open

Description

@github-actions

⚠️ OpenSpec-managed issue — this content is automatically synced
from the openspec/ directory. Manual edits will be overwritten on next sync.

Artifacts

Summary

A user adding a customer or a supplier types a company name or KvK number,
picks the company from the KvK Handelsregister, and the legal name, trade name
and address fill in. Shillinq declares the lookup on two properties and turns
the KvK connection on. The lookup itself is integriq's and the key is
openregister's; both already ship.

Specs

Tasks

  • 1.1 Add x-openregister-property-source with the customer fill map of design D2 to CustomerMaster.kvkNumber in lib/Settings/register.d/add-shillinq-bookkeeping-compliance.json, and with the supplier fill map to Payee.kvkNumber in lib/Settings/register.d/bookkeeping-accounts-payable-core.json; regenerate shillinq_register.json if the build merges fragments (REQ-KVKL-001, REQ-KVKL-002). Verify: npm run check:registers; a PHPUnit test that reads both fragments and asserts provider kvk, mode default and every fill target is a declared property of its schema.
  • 1.2 Import the register on a dev instance and read both schemas from openregister (REQ-KVKL-001). Verify: propertyMetadata.kvkNumber names kvk on both; grep 'PARTIAL IMPORT' in the log finds nothing; record the output in the PR body.
  • 2.1 Switch the kvk entry in lib/Settings/connections.json on per design D3 (REQ-KVKL-003). Verify: the existing connections test (ConnectionReportService tests) passes with the entry available; integriq's connections overview lists it as not set up yet on the dev instance.
  • 3.1 With the KvK source linked (sandbox or the integriq seed), add a supplier from the KvK and read the filled name and address; type a name first and confirm the replace question (REQ-KVKL-002). Verify: Playwright test tagged with @e2e references to the scenarios; skipped with a stated reason while the renderer is absent.
  • 3.2 With no source linked, add a customer with a typed number and confirm it saves with the not-set-up message (REQ-KVKL-003). Verify: Playwright, same tagging.
  • 4.1 Add "Look a company up in the KvK" to the customers and suppliers user guide pages in docs/, and the unconfigured message string with its Dutch translation in l10n/ (REQ-KVKL-003). Verify: npm run test:l10n.

Design

See design.md for technical design details.


Synced from openspec/changes/contacts-kvk-lookup by OpenSpec workflow
App: shillinq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions