Repository navigation
feat(pipelinq): build products-quote-from-lead - #3954
Open
rubenvdlinde wants to merge 5 commits into
Open
rubenvdlinde wants to merge 5 commits into
rubenvdlinde wants to merge 5 commits into
Conversation
Send quote on a lead: filinq renders the lead's lines to a PDF and files
a copy in the sender's Files, pipelinq mails it to the contact (else the
client) and logs an outbound contact moment on the lead.
- QuoteController: POST /api/leads/{id}/quotes and the recipient preview,
the lead read as the caller (404), 503 without filinq, 422 without a
recipient, 502 when the render or the mail fails.
- QuoteSender and QuoteMailer; the letter adapter passes filinq's
adHocData (quote, totals per VAT rate, the frozen lines).
- SendQuoteModal behind a send-quote header action, hidden without filinq.
- nl/en strings, docs/Features/quotes.md, openapi.json.
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 17, 2026 15:03
… ci] Keep both sides' new l10n keys (quote strings and the Outlook add-in strings) and regenerate the browser catalogues from the json. Assisted-by: ClaudeCode:claude-opus-5-5
…test arguments QuoteSender reads the lead's lines through an injected ObjectServiceInterface instead of a container lookup (ADR-083 rule 1). QuoteController parses the valid-until date without static access. The new tests name their arguments and document their methods. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/pipelinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| check-vue-demi | ✅ | ||||
| test-l10n | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-e2e-nav | ✅ | ||||
| check-lib-link | ✅ | ||||
| composer | ✅ | ✅ 109/109 | |||
| npm | ✅ | ✅ 646/646 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-20 04:32 UTC
Download the full PDF report from the workflow artifacts.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
openspec/changes/products-quote-from-lead(round 2): Send quote on a lead. filinq renders the lead's lines to a PDF and files a copy in the sender's Files; pipelinq mails it to the lead's contact (else the client) and logs an outbound contact moment on the lead.Tasks done
QuoteController:POST /api/leads/{id}/quotes(bodytemplateId, optionalvalidUntil, default 30 days) andGET /api/leads/{id}/quotes/recipient, both#[NoAdminRequired]. The lead is read as the caller and checked againstObjectOwnerAccessPolicy(assignee or privileged group), so an unreadable lead is 404. 503 without filinq, 422 without a recipient, 502 when the render or the mail fails. Routes andopenapi.jsonupdated.QuoteSenderreads the client, contact, lines and their products as the caller, works out the totals per VAT rate (QuoteService), takes the nextOFF-YYYY-NNNNnumber and renders throughFilinqLetterAdapter. The adapter gained an optional trailingadHocData(filinq's own option) for the quote, the totals and the frozen lines.QuoteMailermails throughIMailerwith the PDF attached. The contact moment (channelquote; lead, client and contact; number, total, validity and the file) is saved throughTicketService. When the mail fails nothing is logged and the copy stays in Files. With no recipient nothing is numbered, rendered or sent.SendQuoteModal(template, valid-until date, the recipient before sending) behind asend-quoteheader action onLeadDetail. It is hidden, not disabled, when/api/letters/templatesanswersavailable: false.FileSendOutlineregistered.l10n/*.json, catalogues rebuilt);docs/Features/quotes.md, including how to write the template in filinq.Tasks left, and why
CnChildRecordsField(lead.lines.addFrom). It copies the product's ownunitPriceand has no hook to callresolve-pricefor the entered quantity, so the tier or variant price needs that hook in@conduction/nextcloud-vuefirst (2.181.0 has none).Tests
QuoteControllerTest(every status, the recipient preview, the validity date),QuoteSenderTest(realQuoteService,ProductCatalogServiceandCallerObjectReaderoverObjectEntityrows; the exact contact-moment payload; 21% and 9% lines give VAT 210.00 and 45.00 and 1755.00 incl.; no recipient; failed mail; refused render; the second send takes the next number),QuoteMailerTest,FilinqLetterAdapterTest::testAdHocDataReachesFilinq. Removing the access check or the recipient guard turns a test red.sendQuoteFromLead.spec.js(shown and hidden, send, no recipient, a refused send, axe on the dialog, date helpers).myWorkPage,notificationLabels,reportSectionPeriod), none added. phpcs, phpstan and eslint clean on the touched files.Generated by Claude Code