Repository navigation
refactor(store): build the OpenRegister StoreDescriptor from its two parts - #3258
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
…parts OpenRegister now builds a StoreDescriptor from a StoreListing (app id, remote schema, default register, card fields) and an optional StoreSharing (shareable types, publish fields, publish groups) instead of seven constructor parameters. Migrate pipelinq's construction site and the OpenRegister test stubs to the new form. Readers are unchanged: the descriptor keeps its flat readonly properties. Merge together with openregister #9817 (coordinated). Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
November 10, 2026 22:38
1 of 4 tasks
Contributor
Author
|
CI is red, but the failures are not from this change. Every workflow run on head Generated by Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge together with openregister #9817 (coordinated)
Coordinated set
StoreDescriptoris built fromStoreListing+StoreSharing(merge first)fix/or-storedescriptorin eachWhat changes in pipelinq
OpenRegister's
StoreDescriptorno longer takes seven parameters. It takeslisting: new StoreListing(appId, schema, defaultRegister, cardFields)and an optionalsharing: new StoreSharing(types, publishFields, publishGroups). Every reader stays the same, because the descriptor keeps its flat readonly properties.lib/Controller/StoreController.php:descriptor()uses the two-part form, with the publish fields and groups onStoreSharing.tests/Stubs/AppHost/Service/: theStoreDescriptorstub mirrors the new constructor; newStoreListingandStoreSharingstubs.Tests
phpunit --filter StoreController: 17 tests OK; php -l on touched files.This PR does not work on its own: against an OpenRegister without #9817 the new named arguments do not exist. Merge it in the same window as the openregister PR.
Generated by Claude Code