Skip to content

refactor(store): build the OpenRegister StoreDescriptor from its two parts - #3258

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
fix/or-storedescriptor
Open

rubenvdlinde wants to merge 1 commit into
developmentfrom
fix/or-storedescriptor

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Merge together with openregister #9817 (coordinated)

Coordinated set

What changes in pipelinq

OpenRegister's StoreDescriptor no longer takes seven parameters. It takes listing: new StoreListing(appId, schema, defaultRegister, cardFields) and an optional sharing: new StoreSharing(types, publishFields, publishGroups). Every reader stays the same, because the descriptor keeps its flat readonly properties.

  • lib/Controller/StoreController.php: descriptor() uses the two-part form, with the publish fields and groups on StoreSharing.
  • tests/Stubs/AppHost/Service/: the StoreDescriptor stub mirrors the new constructor; new StoreListing and StoreSharing stubs.

Tests

  • phpunit --filter StoreController: 17 tests OK; php -l on touched files.

This PR does not work on its own: against an OpenRegister without #9817 the new named arguments do not exist. Merge it in the same window as the openregister PR.


Generated by Claude Code

…parts

OpenRegister now builds a StoreDescriptor from a StoreListing (app id,
remote schema, default register, card fields) and an optional
StoreSharing (shareable types, publish fields, publish groups) instead
of seven constructor parameters. Migrate pipelinq's construction site and
the OpenRegister test stubs to the new form. Readers are unchanged: the
descriptor keeps its flat readonly properties.

Merge together with openregister #9817 (coordinated).

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

CI is red, but the failures are not from this change. Every workflow run on head 1f7d268 ends as failure about one second after it starts, with 0 jobs. The whole coordinated set shows this, and so does openregister main, so it is an Actions problem across the account or the workflows. See ConductionNL/openregister#9817.


Generated by Claude Code

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant