Skip to content

chore: pipelinq integration batch 2 - #2565

Open
rubenvdlinde wants to merge 70 commits into
developmentfrom
integration/pl-batch-2
Open

rubenvdlinde wants to merge 70 commits into
developmentfrom
integration/pl-batch-2

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Pipelinq integration batch 2: the PL1 record pages, PL3 marketing and PL5 admin, merged on development and resolved. Batch 1 was #2560, so this one is numbered 2.

What is in it

Branch Head What it does
feature/pl-abstract-pl1-party-actions e680b9d Warnings, Add a warning, Call, Call from my extension, Mail and Directions in one party-actions band on client and contact pages. Indicators come loudest first from the server; click-to-dial uses the agent profile's extension (agentProfile 1.1.0).
feature/pl-abstract-pl1-activity-timeline dfd96e5 The client's activity is the library timeline over /api/timeline, with type chips, Load more, channel icons and an empty sentence.
feature/pl-abstract-pl1-resident-view 32eb2b6 What the resident sees is three facts cards over rows the server builds (ResidentViewRows).
feature/pl-abstract-pl1-conversation 44f2d6d Answers and saved replies on the server (/api/tickets/{id}/answer, /api/saved-replies). Ticket, client and contact messages are the library conversation, with the latest thread status and the template composer on a closed WhatsApp session.
feature/pl-abstract-pl1-contact-channels 10843b2 Emails, phones and social profiles are tabs of field lists, with a preferences card. Stacked on pl1-server-listeners (1980bc6): the server keeps the primary email and phone and the relationship inverses.
feature/pl-abstract-pl1-relationships ce1ba37 Relationships are an object list. The type table, the create and its refusals are on the server (/api/relationship-types, /api/relationships); the list says Active or Ended (relationship schema 1.2.0).
feature/pl-abstract-pl1-party-forms 5e34553 The new client and new contact dialogs are the library form over the Clients and Contacts page config.
feature/pl-abstract-pl3-marketing 7887aeb Marketing, reporting, forecast and loyalty pages as library widgets and dashboards.
feature/pl-abstract-pl5-admin-managers d609ab7 Admin lists as embedded index pages, the tenant picker and a server-side vocabulary refusal. It already holds pl5-admin-lists (5e57164).

Components these branches replace are removed, with their tests ported to config specs. In all: 320 files, 15,443 lines added and 25,393 removed.

Resolved while merging

  • src/registry.js: the branches each removed different entries. The merge keeps every removal and every addition.
  • src/services/forecastMath.js, src/views/forecast/ForecastDashboard.vue and ForecastTrend.vue: PL3 removed them and PL5 changed a comment in them. They stay removed.
  • tests/vitest/structureProfile.spec.js: PL3 took 3 pages out and PL5 took 1, so the count is 90.
  • l10n/en and l10n/nl: merged key by key. A key a branch removed is gone and a key it added is in. The .js catalogues are rebuilt from the .json ones.

Needs a nextcloud-vue release

pipelinq still runs on nextcloud-vue 2.117. These pages need batch 24h (pl1-handoff, pl1-field-list) and batch 24q (the five PL1 branches and pl1-form-pattern-message). 24q must carry feature/pl-abstract-pl1-party-actions at 2ba4e34: that commit lets the manifest schema accept the @object.<field>|tel, |mailto and |geo link targets. The nextcloud-vue bump lands on this branch once that release is out.

Checks run

  • composer check:strict: passed (3,840 tests).
  • npm run lint: passed.
  • vitest: 975 of 983 passed on be33c58. Two failures were in this batch, and they are fixed in the head commit: phoneOnTheRoad and wideTablesFit read components that are now removed, and now read the config instead. The other six need the new library: five check the manifest against the installed schema (the link targets), and libraryImports names CnConditionTreeEditor and CnBlockListEditor, which come with 24g2.
  • Manifest validation and libraryImports stay red until nextcloud-vue ships 24g2 and 24q. That is expected.

Ready for review once that release is in.

Disclosure

Prepared with Claude Code (Opus 5.5) as the pipelinq integration lane. A person reviews and merges it.

…tes gone

The admin page's Lead Management, Shillinq, BI export, marketing
intelligence and provision-data forms are CnSettingsFieldsSection
declarations in src/views/settings/adminSections.json. Each saves only
the settings it changed; the page keeps its config copy in step so the
register mapping does not write an older value back.

- "Run the setup wizard again" is the admin shell's own showSetup action.
- The BRP monitor is a read-only section on the admin page instead of
  the unlinked in-app route /admin/brp-monitor (ADR-004, audit bug 13).
- The sync settings page saved nothing and said it did; it and its
  duplicate section are deleted (audit bug 12), with the unreferenced
  PipelineManagerView registry key.
- Deleting a skill or an agent profile asks in CnDeleteDialog, not the
  browser's confirm().
- Marketing intelligence gets its Dutch translations.

Assisted-by: ClaudeCode:claude-opus-5-5
…stomer lookup on the admin page

Needs the nextcloud-vue release with settings-fields-lists (checkboxes,
select multiple, pairs, path, scope and action texts).

- Menu structure, VAT rates, forecast, prospect discovery, CTI and xWiki
  are CnSettingsFieldsSection declarations.
- The POS customer lookup settings move from the unlinked in-app route
  /admin/pos-customer-link to a section on the admin page (ADR-004,
  audit bug 13).
- Prospect discovery read and saved /api/prospects/settings, which no
  route serves; the section uses /api/prospect-settings.
- xWiki is no longer probed on every load: Detected integrations shows
  the connection once, and Test connection says whether xWiki answers.
- The BRP monitor's certificate note no longer needs an empty JSON key.

Assisted-by: ClaudeCode:claude-opus-5-5
…unt follows the two removed pages

json/no-empty-keys refused the textMap entry for a missing certificate,
so that case is its own status note. The simple profile builds 95 pages
now that /admin/brp-monitor and /sync-settings are gone.

Assisted-by: ClaudeCode:claude-opus-5-5
…-pl5-admin-lists

# Conflicts:
#	src/views/settings/adminSections.json
#	tests/vitest/structureProfile.spec.js
…nnel figures

/api/rapportage/channels answers one row per channel with the share, the
first-contact resolution rate and the SLA attainment counted from the
contact moments. The channel comparison table used to fill FCR with 0 and
SLA with the target itself, so every channel read green at its target.
/api/rapportage/agents answers rows with the agent's display name and the
handling time in seconds, plus team totals. /api/satisfaction/response-rate
answers its per-channel figures as rows too. The CSV export, a 501 stub,
now downloads the contact moments of the requested period.

Assisted-by: ClaudeCode:claude-opus-5-5
…, stat and table widgets

The three report sections become manifest widgets on the row arrays the
endpoints now answer: a bar-list chart on the channel rows, an object-table
comparing channels with an SLA status badge, and two stat tiles over an
agent table whose handling time sorts as a number. Export CSV is a header
action that downloads the report of the chosen period. The granularity
filter on Channel analytics is gone: it never changed the table.

Assisted-by: ClaudeCode:claude-opus-5-5
…dgets on one read

The funnel, source table, aging donut and win/loss pie were one section
that fetched pipeline-stats and fanned it out to four pipelinq widgets.
They are now manifest widgets reading their own part of the same answer,
which the shared endpoint source sends as one request. The pipeline
selector is a page filter with its options from the pipeline objects, and
the win/loss range is the page date range, so the range now also narrows
source performance on screen as it did on the server. The server words
the win/loss slices.

Assisted-by: ClaudeCode:claude-opus-5-5
The per-group table was a section that fetched the attainment endpoint
itself. It is now an object-table on details.byGroup, headed by the
grouping the server names in labels.group and showing the per-row
attainmentPercent the server adds. The headline figures take their colour
from the success, error and primary variants instead of hex values.

Assisted-by: ClaudeCode:claude-opus-5-5
… library widgets

The Operational dashboard's response rate is a stat tile with the
answered and not-delivered counts as its caption and note, beside a
per-channel table on the rows the endpoint now answers. Its own period
select gives way to the dashboard's date range, which the endpoint reads
as a from/to window. The client page's satisfaction panel is a facts card
on the client endpoint, with its empty state, and the three latest
comments a record list on the same read.

The tile's note template needs the nextcloud-vue widgets branch
(feature/pl-abstract-pl3-widgets), the facts card the pl2-facts branch.

Assisted-by: ClaudeCode:claude-opus-5-5
… email/phone

Editing a relationship saved through a full PUT with eight fields, which wiped
fromContact, toContact, fromType and toType on the row and on its inverse, and
the inverse was a second browser write, so a half-failed save left a one-way
link and the API and imports got no inverse at all (PL-ABSTRACT bug 1).

- RelationshipInverseListener queues the inverse work (ADR-078) on create,
  update, purge and soft delete; RelationshipInverseService creates the
  inverse, patches only the fields that differ (a type change moves it), and
  deletes it. The work settles: the inverse of the inverse is the original.
- ContactChannelMirrorListener fills email/phone from the primary (else the
  first) entry of a changed emails[]/phones[] before the save, for every
  writer. A writer that changes only email keeps working.
- The detail page saves only the row, edits with PATCH, and no longer mirrors
  the channel fields itself.

Assisted-by: ClaudeCode:claude-opus-5-5
…ries

The widget read objectTypeRegistry.timeEntry, a type that does not
exist (the schema is billingTimeEntry), so it always said no hours were
recorded; it did not filter on approved despite its title, and it linked
to a route that does not exist. It is now a donut chart whose data source
sums the hours of approved billingTimeEntry objects per category on the
server, labelled and coloured by the category.

Assisted-by: ClaudeCode:claude-opus-5-5
…d question editor; social sections read their post id from the section context

LoyaltyAccountCreation was a routed page nothing linked to, with the
register slug written into it. QuestionEditor had no importer. The social
variants and publications sections read the section context without
unwrapping its ref, so their fallback never found the post.

Assisted-by: ClaudeCode:claude-opus-5-5
…nt comes back as a form

The reporting view read the programmes through a hard-coded register slug
and worked out the period in the browser. It is now a dashboard: the
programme is a page filter with its options from the loyaltyProgramme
objects, the period is the page date range, the eight figures and the
tier distribution read the existing reporting endpoints, and Download
exports the figures through a new CSV endpoint.

The board draws enrolment on this page. The unreached enrolment page is
gone, so Enrol a customer is a header form that posts to a new
/api/loyalty/accounts endpoint, which refuses an account without the
customer's opt-in (REQ-LOY-010-01) as LoyaltyAccountService already did.

Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
…brary widgets

ArticleDetail shows the hero image and the markdown body as image and
markdown widgets on the record's fields, the summary, links and agent mark
as a facts card on GET /api/articles/{id} (which now answers the links as
rows), and where the article is used as two stat tiles and a table on the
usages endpoint. The five lifecycle moves are api-call header actions shown
by status; publish and archive keep their own endpoints, so the server
still stamps publishedAt. The status reads in words through x-enum-labels.
New article opens ArticleEditModal from the index, and a created article
opens on its detail page, so the /articles/new route and its wrapper go.

Needs the nextcloud-vue widgets branch (feature/pl-abstract-pl3-widgets)
for content.field on the markdown and image widgets.

Assisted-by: ClaudeCode:claude-opus-5-5
…ens the composer

Submit for approval, Reject and Approve are api-call header actions shown
by the post's status, posting to the same /api/social-posts endpoints that
record who decided. New post opens SocialPostComposeModal from the index,
and a new post opens on its detail page, so the /social-posts/new route
and its wrapper go.

Assisted-by: ClaudeCode:claude-opus-5-5
…s modal host

Needs the nextcloud-vue releases with index-page-embedded (and
settings-fields-lists, through the branch this stacks on).

- Product categories, skills, agent profiles and the POS tender types,
  staff and roles are CnIndexPage declarations in adminLists.js. A row
  opens in place: its form dialog, which the admin page mounts through
  cnOpenModal, or the built-in form dialog for register objects. Closing
  a dialog reads the lists again.
- An agent profile's user is picked from the Nextcloud users instead of
  a browser prompt; its skills are picked from the skills.
- A staff member's role shows the role's name.
- Deleting a tender type asks in CnActionDialog and shows the refusal.
- The POS section descriptions lose their em-dashes.
- Deleted: the three POS managers and lists, ProductCategoryManager,
  SkillSettings, AgentProfileSettings.

Assisted-by: ClaudeCode:claude-opus-5-5
…asons

The audit is an object-table on the connection-audit endpoint: the handle
links to the profile, the two answers are badges in words (Yes, No,
Cannot be checked) and the reason sits beside them. Check again is a
header action that reads the networks anew.

Assisted-by: ClaudeCode:claude-opus-5-5
…ents read

The watches and what they saw are two object-tables on the one
watch-events endpoint: the competitor resolves to its name, the kind,
schedule and outcome read in the register's words, the reason sits under
the outcome, and Run now is a row action posting to that watch's run
endpoint. When no egress source is set a card says so, with the server's
reason. Needs the nextcloud-vue widgets branch for the @Row token.

Assisted-by: ClaudeCode:claude-opus-5-5
…ted read; report tables sort by header

Search queries is a dashboard: the period is the page date range, which
the server now reads by its days when it comes as ISO moments; a tile
counts the queries and names the last import; the table shows the
click-through in percent from a new ctrPercent field and sorts by header.
The agent and channel tables sort by header too.

Assisted-by: ClaudeCode:claude-opus-5-5
…ockListEditor

The palette, the reorderable list with its keyboard moves and live
region, the properties panel and the footer that always stays last with
its two compliance tokens are now CnBlockListEditor. What is mail-specific
stays here as configuration: the block types, their fields, the footer
tokens and the empty block of each type (mailBlockTypes, newBlock). The
list rules moved with the component and are tested there.

Needs the nextcloud-vue branch feature/pl-abstract-pl3-block-list.

Assisted-by: ClaudeCode:claude-opus-5-5
…ws it

Assisted-by: ClaudeCode:claude-opus-5-5
…tract-pl3

# Conflicts:
#	l10n/en.json
#	l10n/nl.json
#	src/registry.js
Assisted-by: ClaudeCode:claude-opus-5-5
…tor; three pages fewer in the structure count

The validator asks every open-form for a schema; the endpoint form ignores
it, so naming customerLoyaltyAccount satisfies it without changing the form.
The structure test counts 91 pages now that the /articles/new,
/social-posts/new and /loyalty/enroll wrappers are gone.

Assisted-by: ClaudeCode:claude-opus-5-5
…summary

The forecast view summed the snapshots in the browser, worked out the
current quarter there, and drew its trend as inline SVG. A new
GET /api/forecast/summary (ForecastSummaryService) does that on the
server with the same rules: the latest snapshot per owner one level
down, quota, won, committed and still to get, the progress, the at-risk
warning, owners by display name, and the weekly trend with what moved
into or out of commit. The page is a dashboard on it: a level filter,
four figures, the progress, the warning, a per-owner table whose Override
row action opens ForecastOverrideModal with that row's values, the trend
chart and the movements, and Download exports the latest snapshot per
owner as CSV. The standalone trend page shows the signed-in seller's own
trend, which the access policy lets a seller read.

Needs the nextcloud-vue widgets branch for the @Row token in the override.

Assisted-by: ClaudeCode:claude-opus-5-5
…tract-pl5-admin-managers

# Conflicts:
#	l10n/en.js
#	l10n/en.json
#	l10n/nl.js
#	l10n/nl.json
#	openspec/changes/pl-abstract-admin-sections/proposal.md
#	openspec/changes/pl-abstract-admin-sections/specs/admin-settings/spec.md
#	openspec/changes/pl-abstract-admin-sections/tasks.md
#	src/components/admin/AgentProfileSettings.vue
#	src/components/admin/SkillSettings.vue
#	src/manifest.json
#	src/registry.js
#	src/views/settings/Settings.vue
#	src/views/settings/adminSections.json
#	tests/e2e/spec-coverage/visual-coverage-spa-pages.spec.ts
#	tests/vitest/adminBoardShell.spec.js
#	tests/vitest/adminSections.spec.js
ClientDetail and ContactDetail show the warnings, Add a warning, Call, Call
from my extension, Mail and Directions in one party-actions band before
the body. The server orders indicators loudest first and click-to-dial
dials from the agent profile's extension (agentProfile 1.1.0). Removed
PartyIndicatorPanel, ContactLinks, the unmounted CtiClickToDialButton and
their helpers; tap-link tests move to nextcloud-vue.

Assisted-by: ClaudeCode:claude-opus-5-5
ClientDetail's Activity is a timeline body widget over /api/timeline with
type chips, Load more and the empty sentence; ActivityTimeline is removed.

Assisted-by: ClaudeCode:claude-opus-5-5
…ma version

Assisted-by: ClaudeCode:claude-opus-5-5
…a closed WhatsApp session are back

Assisted-by: ClaudeCode:claude-opus-5-5
…rder per kind of record

Assisted-by: ClaudeCode:claude-opus-5-5
… rows

GET /api/tickets/{id}/resident-view also answers the panels as translated
rows (ResidentViewRows); TicketDetail and the simple ticket page draw them
as three facts cards on request tickets. ResidentViewSection is removed.

Assisted-by: ClaudeCode:claude-opus-5-5
…r the library form

ClientCreateDialog and ContactCreateDialog are CnFormDialog over the fields
and checks the Clients and Contacts pages declare, saved through the
contacts-sync create. ClientForm, ContactForm and clientFormFields are
removed.

Assisted-by: ClaudeCode:claude-opus-5-5
…st of the languages pipelinq offers

GET /api/correspondence-languages also answers named options; the client
form lists those, starting with the reader's language.

Assisted-by: ClaudeCode:claude-opus-5-5
…channels' into integration/pl-batch-2

# Conflicts:
#	src/registry.js
…ships' into integration/pl-batch-2

# Conflicts:
#	src/registry.js
…g' into integration/pl-batch-2

# Conflicts:
#	src/registry.js
…nagers' into integration/pl-batch-2

# Conflicts:
#	l10n/en.js
#	l10n/en.json
#	l10n/nl.js
#	l10n/nl.json
#	src/registry.js
#	src/services/forecastMath.js
#	src/views/forecast/ForecastDashboard.vue
#	src/views/forecast/ForecastTrend.vue
#	tests/vitest/structureProfile.spec.js
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/pipelinq @ 33edcaa

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
check-e2e-nav ✅
check-lib-link ✅
composer ❌ ✅ 109/109
npm ✅ ✅ 747/747
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-21 20:53 UTC

Download the full PDF report from the workflow artifacts.

ContactLinks is the party-actions band and the competitors page is
library object-tables, so the specs read the config instead of the
removed components.

Assisted-by: ClaudeCode:claude-opus-5-5
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/pipelinq @ 433765b

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
check-vue-demi ✅
test-l10n ✅
format ❌
check-schema-l10n ❌
check-l10n-js ✅
check-e2e-nav ✅
check-lib-link ✅
composer ❌ ✅ 109/109
npm ✅ ✅ 747/747
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-10-22 05:35 UTC

Download the full PDF report from the workflow artifacts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant