Skip to content

chore(nc35): declare Nextcloud 35 support in info.xml - #28

Merged
rubenvdlinde merged 1 commit into
developmentfrom
claude/nc35-support
Oct 6, 2026
Merged

rubenvdlinde merged 1 commit into
developmentfrom
claude/nc35-support

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Summary

Part of the fleet-wide Nextcloud 35 rollout (see ConductionNL/decidiq#1616). appinfo/info.xml max-version 34 -> 35. The CI matrix is already derived from info.xml.

Validation and open risks

AppAPI 35 validates info.xml routes/env vars more strictly; checked against AppAPI stable35's own helpers: OK. Still needs a real occ app_api:app:register on NC35.

🤖 Generated with Claude Code

https://claude.ai/code/session_01M7DxSg7d7wqqZsUppLWf7J


Generated by Claude Code

Raise max-version from 34 to 35 in appinfo/info.xml. min-version is
unchanged. The <external-app> block (docker-install, routes,
environment-variables) was checked against AppAPI stable35 route and
environment-variable validation and needs no changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01M7DxSg7d7wqqZsUppLWf7J
@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown

Quality Report — ConductionNL/opentalk @ ca9d4a9

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ⏭️
stylelint ⏭️
build ⏭️
composer ❌ ✅ 71/71
npm ✅ ✅
app:check-code ⏭️
info.xml ❌
REUSE ❌
lockfile sync ⏭️
PHPUnit ⏭️
Newman ⏭️
Playwright ⏭️
Hydra gates ⏭️

Quality workflow — 2026-10-06 10:26 UTC

Download the full PDF report from the workflow artifacts.

Copy link
Copy Markdown
Contributor Author

CI note: the red checks in quality run 37448894077 are pre-existing and not caused by this PR. The diff is one line in appinfo/info.xml (max-version 34 -> 35).

  • quality / Security (composer): composer audit flags squizlabs/php_codesniffer 3.13.5 (CVE-2026-67434 / GHSA-hmqg-cxww-wqhq, published 2026-08-05, fixed in 3.13.6). That version is pinned in composer.lock on development, and this PR does not change the lock.

    • There is no comparable development run since the advisory was published. The 2026-08-12 push run 31594012180 has a workflow-file error and ran 0 jobs, and the last green run (2026-08-05 18:34) came before the advisory.
    • The same lock version fails this job on development in the sibling repos (openklant run 31173087702, openzaak run 31173106978).
    • Fix: a separate lock refresh (composer update squizlabs/php_codesniffer) on development.
  • quality / info.xml lint: appinfo/info.xml already fails the appstore info.xsd on development. I reproduced this locally with xmllint --schema on the unmodified base file:

    1. <documentation> sits after <screenshot>, but the XSD requires it before <category>.
    2. Once that is reordered, <external-app><routes> fails next. The appstore XSD's external-app type only allows docker-install, scopes, system and environment-variables. AppAPI needs <routes> for proxying, so it cannot be dropped.

    So this check cannot go green in-repo for an ExApp with routes. It needs the shared workflow in ConductionNL/.github to tolerate or skip <routes> for ExApps, or an upstream appstore XSD update. The element order (1) can be fixed in a small follow-up.

  • quality / Quality Report: only aggregates the two failures above.

The Nextcloud test matrix and all other quality jobs passed or were skipped by path filters.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit b573b32 into development Oct 6, 2026
31 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants