Repository navigation
refactor(independence): hide SyncRecordStatus, RegisterSlugAliases and RegisterObjectEntity behind constant interfaces - #7582
Conversation
…d RegisterObjectEntity behind constant interfaces Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite failed in its PHPUnit step, and I don't think this PR causes it. The failing tests are exactly the same 22 that fail on #7501, #7571 and #7572: environment and golden differences in the CI Nextcloud ( Generated by Claude Code |
|
quality / PHP Quality (phpcs) failed, and it is not caused by this PR. phpcs reports errors in the same 8 files as on #7501, #7571 and #7572 ( Generated by Claude Code |
|
quality / Hydra Gates failed. Seven of the eight failing gates (3, 7, 12, 17, 40, 46, 49) are the same full-repo findings as on the other K24 PRs and are not this PR's. Gate 16 (spec-coverage) is this PR's: "1 changed method(s) missing @SPEC". The job log does not name the method. The most likely one is Fix: add Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 17:44 UTC
Download the full PDF report from the workflow artifacts.
Lane K24 (round 10c), SIG component independence.
What changed: three concrete classes are now named from outside their component only through an interface. Each interface holds constants only, so no container binding is needed and DI semantics are unchanged.
Service/Sync/SyncRecordStatusInterface: the status vocabulary and the transition table.SyncRecordStatusimplements it, soSyncRecordStatus::PENDINGetc. still resolve.Db/SyncRecordMappernow readsSyncRecordStatusInterface::PENDINGandTRANSITIONS[$current]. That is equivalent tocanTransition(): every listed target is a valid status, and an unknown$fromhas no entry.Support/RegisterSlugAliasesInterface: the declared alias map.Service/RegisterSlugResolverreadsALIASES[$key] ?? [$key]on the key it has already normalised and empty-checked, which is exactlycandidatesFor().WorkflowEngine/RegisterObjectEntityInterface extends IEntity, withENTITY_ID(the Flow entity id is the class name).Listener/FlowEngineRegistrationListenerresolves the entity by that id.tests/Unit/Architecture/K24InterfaceBindingsTest.phppins that each class implements its interface, that the table and the map answer exactly whatcanTransition()andcandidatesFor()answer over every status pair / alias key, and that the listener registers the entity by its id.What ran (branch merged with current development): tests/Unit/Architecture, Contract, Kernel, Service/Rules, ControllerServicesWiringTest, ControllerSessionWiringTest, plus Db/SyncRecordMapperGoldenTest, Service/Sync, RegisterSlugResolverTest, Support, Listener: green. phpcs: no new findings in lib. phpstan on touched files: OK.
Numbers: exposed LOC of the lane's target classes is 261 before. This PR hides RegisterObjectEntity (57), SyncRecordStatus (52) and RegisterSlugAliases (36), so 145 of it.
AI disclosure: written by Claude Code (claude-opus-5-5) in an automated lane.
Generated by Claude Code