Repository navigation
[access] refactor(schema): revalidation engine and configuration drafts reached through interfaces - #7562
Conversation
…e through SchemaRevalidatorInterface Assisted-by: ClaudeCode:claude-opus-5-5
… through ConfigurationDraftsInterface Types only: the controller and its service bundle name the interface; the four-eyes approval and every refusal stay in ConfigurationDraftService. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite: the red is not from this PR. The job's PHPUnit step finishes with 11 errors and 11 failures. Those 22 failures come from these test classes:
This PR touches none of the classes those tests cover. The same 22 failures appear on #7561's Newman job (129002082935), and #7561 has already merged. The failures depend on where the suite runs. The suite runs inside the Nextcloud container, where real server classes replace the test stubs. Some examples:
Locally, all 75 tests in those classes pass at this PR's head, on No fix exists yet, and it doesn't belong in this PR. I didn't re-run the job: the failures are deterministic, so a re-run would fail the same way. Generated by Claude Code |
|
quality / Vue Quality (eslint): the red is not from this PR. This PR changes only PHP and adds no
The same check failed on #7561, which also changed only PHP and has already merged. No fix belongs in this PR. Fixing those files is frontend work for whoever owns them. A re-run would fail the same way, so I didn't re-run the job. Generated by Claude Code |
|
quality / PHP Quality (phpcs) and Frontend Check (test:l10n): neither red is from this PR.
Both checks also failed on #7561, which changed only PHP and has already merged. Neither fix belongs in this PR, and a re-run would fail the same way. Generated by Claude Code |
|
Frontend Check (test:l10n:parity): this red is not from this PR either. This PR doesn't touch Generated by Claude Code |
|
quality / PHP Quality (phpstan): this red is not from this PR. phpstan reports 24 errors. All of them are in files this PR doesn't touch:
None of the files this PR changes appear. The same check failed on #7561, which changed only PHP and has already merged. A re-run would fail the same way. Generated by Claude Code |
|
Frontend Check (format): this red is not from this PR. This PR changes no frontend files. The same check failed on #7561, which changed only PHP and has already merged. A re-run would fail the same way. Generated by Claude Code |
|
quality / PHP Quality (psalm): this red is not from this PR. Psalm reports 60 errors, mostly in files this PR doesn't touch. The worst is The one error that reaches this PR's area is The same check failed on #7561, which has already merged. A re-run would fail the same way. Generated by Claude Code |
|
quality / PHP Quality (phpmd): this red is not from this PR. phpmd reports findings in 348 The same check failed on #7561, which has already merged. A re-run would fail the same way. Generated by Claude Code |
|
quality / Hydra Gates: this red is not from this PR. Seven gates fail, and #7561 (already merged) failed exactly the same seven with the same counts:
Gate 46 also reports two unresolved targets on #7561, which added no
A re-run would fail the same way. Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 17:30 UTC
Download the full PDF report from the workflow artifacts.
Summary
Lane K29 (round 10c, SIG component independence). Two concrete
lib/Serviceclasses are now named from outside their component only through interfaces. Only types change. The four-eyes approval, every refusal, and the revalidation run logic stay exactly where they were. Each interface is bound inSchemasBindings, as an alias to the same shared instance.Changes
lib/Service/Schema/SchemaRevalidatorInterface.php(new):start()andprocessBatch(), implemented bySchemaRevalidationService.SchemaMigrationDomain(type hint only),SchemaRunServicesandSchemaRunJobnow name the interface.lib/Service/ConfigurationDeployment/ConfigurationDraftsInterface.php(new): the draft-set workflow (requiresFourEyes,openSet,loadSet,draftValue,draftRemoval,draftsIn,approveSet,discardSet,listSets), implemented byConfigurationDraftService.ConfigDeploymentControllerServicesandConfigurationDeploymentController(use line and property type only, since that file is in feat(config): the settings screen, bundles and seeding join the deployment lifecycle #3860) now name the interface.lib/Service/Bindings/SchemasBindings.php: two bindings.tests/Unit/Architecture/K29InterfaceBindingsTest.php(new): checks that each binding is present and that each class implements its interface.Test Coverage
development: tests/Unit/Architecture, Contract, Kernel, Service/Rules, ControllerServicesWiringTest, ControllerSessionWiringTest, plus the tests of every touched directory: 14,809 tests OK.SchemaRevalidationServiceand both also present ondevelopment.Numbers (lane_measure.py, K29, both K29 branches merged on origin/development)
SchemaRevalidationService(106) andConfigurationDraftService(204) are now hidden.Quality checklist
Written with AI assistance (Claude Code).
Generated by Claude Code