Repository navigation
[access] refactor(integration): bundle CaseTokenService and FlowLinkService constructors - #7518
Conversation
…nstructors CaseTokenService takes a CaseTokenIssuance bundle (mapper, secure random, URL generator); FlowLinkService takes a FlowLinkPlatform bundle (link mapper, db, app manager). The user session and group manager (access guards) stay direct constructor parameters. BuiltinIntegrationServices builds the bundles; the factory golden records the new read order for CaseTokenService. Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite is red, but the failures are not from this PR. This PR is based on development No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not porting one here. The CaseToken*, FlowLink*, integration-wiring and architecture guard tests that this PR does touch pass. Generated by Claude Code |
|
quality / Frontend Check (test:l10n) is red, but the failure is not from this PR. The check reports 14 keys used in No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here. Generated by Claude Code |
|
quality / PHP Quality (phpstan) is red, but the failure is not from this PR. The check reports 24 errors in 12 files: No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here. Generated by Claude Code |
|
quality / PHP Quality (psalm) is red, but the failure is not from this PR. The check reports 60 errors. The base commit, development One error mentions FlowLink: No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here. Generated by Claude Code |
|
quality / PHP Quality (phpcs) and quality / Frontend Check (format) are red, but neither failure is from this PR.
No fix on development exists yet for either one. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here. Generated by Claude Code |
|
quality / Vue Quality (eslint) is red, but the failure is not from this PR. This PR changes only PHP files, with no No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here. Generated by Claude Code |
|
quality / Hydra Gates is red, but the failure is not from this PR. The same 7 gates fail on the base commit, development
The two runs differ only in the names of their temporary directories. This PR changes no controllers and no frontend files. Its new No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here. Generated by Claude Code |
|
quality / PHP Quality (phpmd) is red, but the failure is not from this PR. The check reports 615 findings. The base commit, development No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here. Generated by Claude Code |
|
quality / Integration Tests (Newman) is red, but the failure is not from this PR. The same three assertions fail on the base commit, development
None of these collections exercises the case-token or Flow-link endpoints. The only mentions of those classes in the log are composer autoload notices, which the base run prints as well. No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here. Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 13:05 UTC
Download the full PDF report from the workflow artifacts.
Lane K28, round 10c (SIG unit interfacing, P1).
What changed
CaseTokenService::__construct6 → 4 parameters: the mapper, secure random source and URL generator move into a newfinal readonlybundle,CaseTokenIssuance.IUserSession(the minter check), the logger and the container stay direct parameters.FlowLinkService::__construct6 → 4 parameters: the link mapper, DB connection and app manager move into a new bundle,FlowLinkPlatform, built the same way asLeafProviderPlatform.IUserSessionandIGroupManager(the admin gate) stay direct parameters.BuiltinIntegrationServicesbuilds both bundles through its existing nested-bundle form. This file is not owned by any lane in this round. I changed only the two entries for these classes.CaseTokenServiceTest,CaseTokenServiceGoldenTest,FlowLinkServiceTestandFlowLinkServiceOperationsGoldenTestnow build the bundles.BuiltinIntegrationProviderRegistrationTestpins the order of container reads. Its CaseTokenService entry now expectsIURLGeneratorbeforeIUserSession. This is a deliberate change: it reads the same entries, and the order changes because the bundle is resolved first.CaseTokenServicefrom the container and calls its methods; no other app constructs either class.What ran (branch merged with current origin/development)
@specon FlowLinkService).Numbers (lane_measure.py, K28)
AI-assisted: written by Claude Code (claude-opus-5-5) and reviewed through the lane pipeline.
Generated by Claude Code