Skip to content

[access] refactor(integration): bundle CaseTokenService and FlowLinkService constructors - #7518

Merged
rubenvdlinde merged 1 commit into
mainfrom
cloud/k28-ctor-bundles
Nov 9, 2026
Merged

rubenvdlinde merged 1 commit into
mainfrom
cloud/k28-ctor-bundles

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Lane K28, round 10c (SIG unit interfacing, P1).

What changed

  • CaseTokenService::__construct 6 → 4 parameters: the mapper, secure random source and URL generator move into a new final readonly bundle, CaseTokenIssuance. IUserSession (the minter check), the logger and the container stay direct parameters.
  • FlowLinkService::__construct 6 → 4 parameters: the link mapper, DB connection and app manager move into a new bundle, FlowLinkPlatform, built the same way as LeafProviderPlatform. IUserSession and IGroupManager (the admin gate) stay direct parameters.
  • The bundle values are assigned one by one to the existing private properties, so no method body changes and allowed/refused outcomes stay the same.
  • BuiltinIntegrationServices builds both bundles through its existing nested-bundle form. This file is not owned by any lane in this round. I changed only the two entries for these classes.
  • Tests: CaseTokenServiceTest, CaseTokenServiceGoldenTest, FlowLinkServiceTest and FlowLinkServiceOperationsGoldenTest now build the bundles. BuiltinIntegrationProviderRegistrationTest pins the order of container reads. Its CaseTokenService entry now expects IURLGenerator before IUserSession. This is a deliberate change: it reads the same entries, and the order changes because the bundle is resolved first.
  • Public method signatures are unchanged. A cross-repo search found that dossiq only resolves CaseTokenService from the container and calls its methods; no other app constructs either class.

What ran (branch merged with current origin/development)

  • phpunit: tests/Unit/Architecture, Contract, Kernel, Service/Rules, Controller/ControllerServicesWiringTest.php, ControllerSessionWiringTest.php, AppInfo, Service/Integration, Service/Interaction, plus the CaseToken*/FlowLink* tests. Result: 3405 tests OK, 1 skipped.
  • php -l: clean. phpstan on the touched files: no errors. phpcs: no errors; the 2 warnings were already there (missing @spec on FlowLinkService).

Numbers (lane_measure.py, K28)

  • Over 4 parameters: 418 → 400 (target ≤ 400)
  • Over 6 parameters: 129 → 129 (target ≤ 129)

AI-assisted: written by Claude Code (claude-opus-5-5) and reviewed through the lane pipeline.


Generated by Claude Code

…nstructors

CaseTokenService takes a CaseTokenIssuance bundle (mapper, secure random,
URL generator); FlowLinkService takes a FlowLinkPlatform bundle (link mapper,
db, app manager). The user session and group manager (access guards) stay
direct constructor parameters. BuiltinIntegrationServices builds the bundles;
the factory golden records the new read order for CaseTokenService.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde rubenvdlinde changed the title refactor(integration): bundle CaseTokenService and FlowLinkService constructors [access] refactor(integration): bundle CaseTokenService and FlowLinkService constructors Nov 9, 2026

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite is red, but the failures are not from this PR.

This PR is based on development a1fd993f8. The same check fails there too (run), and the list of failing PHPUnit tests is the same on both runs (23 entries). They are in JobRunMapperNarrowGoldenTest, FileVersioningHandlerGoldenTest (an IVersionManager double is declared twice), TextExtractionJobsGoldenTest, EndpointsControllerAnswersGoldenTest, SchemaConfigValidatorsGoldenTest, ProcessingLogServiceGoldenTest, A18InterfaceBindingsTest and SearchReferenceResolverGoldenTest. This PR changes none of those classes.

No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not porting one here. The CaseToken*, FlowLink*, integration-wiring and architecture guard tests that this PR does touch pass.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde changed the base branch from development to main November 9, 2026 06:56

Copy link
Copy Markdown
Contributor Author

quality / Frontend Check (test:l10n) is red, but the failure is not from this PR.

The check reports 14 keys used in src/ that are missing from l10n/en.js. It fails the same way on the base commit, development a1fd993f8 (run), and test:l10n:parity is red there too. This PR changes only PHP files, with no frontend or l10n/ changes. The missing keys come from development; the repository's CLAUDE.md records test:l10n as red at HEAD for that reason, and the fix belongs in its own commit.

No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpstan) is red, but the failure is not from this PR.

The check reports 24 errors in 12 files: FileTextExtractionJob, EndpointsController, RegisterStatistics, TaskNotesController, WebhooksController, TenancyIdentityTrait, NotesController, GraphQLService, FlowService, ImportPreviewService, NotesProvider and TaskSequenceService. None of them is touched by this PR. The base commit, development a1fd993f8, reports the same list of files and the same error count (run). A local phpstan run on this PR's five changed production files reports no errors.

No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (psalm) is red, but the failure is not from this PR.

The check reports 60 errors. The base commit, development a1fd993f8, reports the same errors, line for line (run). Most of them are UnusedBaselineEntry and baseline drift in files this PR does not touch.

One error mentions FlowLink: FindLinksByObjectUuidTrait (LessSpecificImplementedReturnType). This PR does not change that trait or FlowLinkMapperInterface, and the same error appears on the base commit.

No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpcs) and quality / Frontend Check (format) are red, but neither failure is from this PR.

  • phpcs: it reports errors in 8 files: ContractBindings, MagicObjectSearchInterface, FlowTokenRouter, RelationCascadeHandler, CaseItem, EntityRelation, ImportPreviewRow and RuleRun. This PR touches none of them. The base commit, development a1fd993f8, fails on the same files (run). A local phpcs run on this PR's five changed files reports 0 errors.
  • format: this is a frontend formatter check, and this PR changes no frontend files. The check fails on the same base commit as well (run).

No fix on development exists yet for either one. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Vue Quality (eslint) is red, but the failure is not from this PR.

This PR changes only PHP files, with no .vue or .js changes. The same check fails on the base commit, development a1fd993f8 (run).

No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Hydra Gates is red, but the failure is not from this PR.

The same 7 gates fail on the base commit, development a1fd993f8, with the same finding counts (run):

Gate Findings
gate-3 stub-scan 1
gate-7 no-admin-idor 113
gate-12 nc-input-labels 1
gate-17 redundant-controller 1
gate-40 form-label-association 1
gate-46 spec-anchor-existence 2
gate-49 controller-exception-translation 19

The two runs differ only in the names of their temporary directories. This PR changes no controllers and no frontend files. Its new @spec tags point to existing spec files, and the gate-46 count is the same as on the base commit.

No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / PHP Quality (phpmd) is red, but the failure is not from this PR.

The check reports 615 findings. The base commit, development a1fd993f8, reports the same 615 findings for the same files and rules (run). The diff of the two lists, ignoring line numbers, is empty. None of the findings is in a file this PR changes. The one that names BuiltinIntegrationServices is a StaticAccess finding in IntegrationWiring.php, which this PR does not touch, and it appears on the base commit as well.

No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here.


Generated by Claude Code

Copy link
Copy Markdown
Contributor Author

quality / Integration Tests (Newman) is red, but the failure is not from this PR.

The same three assertions fail on the base commit, development a1fd993f8 (run), with the same totals on both runs (55, 207 and 374 assertions, one failing in each collection):

  • Restore endpoint responds
  • contact destruction date follows the client
  • notify-on-change: no step failed

None of these collections exercises the case-token or Flow-link endpoints. The only mentions of those classes in the log are composer autoload notices, which the base run prints as well.

No fix on development exists yet. The lane rules forbid pushing to this PR after it was opened, so I am not adding one here.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit e6cefcd into main Nov 9, 2026
37 of 49 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ fcde6ec

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ cancelled — no verdict
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 13:05 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants