Skip to content

refactor(integration,mcp): drop derivable constructor parameters - #7516

Merged
rubenvdlinde merged 2 commits into
developmentfrom
cloud/k09-derivable-params
Nov 9, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
cloud/k09-derivable-params

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What changed

SIG unit interfacing, lane K09 (round 10c). Two constructors drop a derivable parameter, going from 5 parameters to 4:

  • LeafRegistry::__construct no longer takes the optional trailing ?LeafBundle $leafBundleService. No construction site passed it (IntegrationWiring::registerLeafRegistry, both test builders). LeafBundle is stateless over the IAppManager the registry already holds, so the registry always builds its own. Behaviour is unchanged.
  • DerivedToolDefinition no longer carries string $id. The id is always {appId}.{slug}.{verb}, and it is now derived by the new private SchemaDerivedToolProvider::toolId(), because that provider owns the app id. Emitted descriptors are unchanged.

No public signatures changed. A code search across the org finds LeafRegistry in other repos only in comments, and no other repo uses DerivedToolDefinition.

Note: open release-sync PR #5398 (beta → development) rewords the comment above the removed LeafRegistry parameter. That file is not in this round's HELD list. The conflict is comment-only: keep this side.

What ran (on this branch merged with current origin/development)

  • Guards: tests/Unit/Architecture tests/Unit/Contract tests/Unit/Kernel tests/Unit/Service/Rules tests/Unit/Controller/ControllerServicesWiringTest.php tests/Unit/Controller/ControllerSessionWiringTest.php: OK (2658 tests).
  • Touched areas: tests/Unit/Mcp tests/Unit/Service/Integration tests/Unit/Capabilities tests/Unit/AppInfo/AttributeMcpDiscoveryTest.php tests/Unit/Tool/McpProviderBridgeTest.php: OK (949 tests). This includes the existing SchemaDerivedToolProviderCharacterisationTest, LeafRegistryTest and LeafRegistryRefusalGoldenTest.
  • php -l, phpcs (no new warnings), phpstan: clean on the touched files.

Numbers (lane_measure.py, lane K09)

before after target
LOC over 4 params 502 485 432
LOC over 6 params 269 269 256

The remaining units are fixed signatures, have builders in files other lanes own, or are held by open PRs. They are listed in the lane's final report.

AI disclosure: written by Claude Code (claude-opus-5-5) as an automated lane run. Assisted-by: ClaudeCode:claude-opus-5-5


Generated by Claude Code

LeafRegistry no longer takes an optional LeafBundle: no construction site
passed one and LeafBundle is stateless over the app manager the registry
already holds. DerivedToolDefinition no longer carries the tool id: it is
{appId}.{slug}.{verb}, derived by the provider that owns the app id.

Assisted-by: ClaudeCode:claude-opus-5-5

Copy link
Copy Markdown
Contributor Author

Newman API Test Suite failed in its in-container PHPUnit step (Errors: 11, Failures: 11). This PR doesn't cause it:

  • The failing tests are unrelated to the diff: JobRunMapperNarrowGoldenTest, FileVersioningHandlerGoldenTest (an IVersionManager redeclare fatal), EndpointsControllerAnswersGoldenTest, ProcessingLogServiceGoldenTest, SchemaConfigValidatorsGoldenTest, TextExtractionJobsGoldenTest and A18InterfaceBindingsTest (ObjectRetentionHandler). None of them touches LeafRegistry, DerivedToolDefinition or SchemaDerivedToolProvider.
  • Every recent completed api-test-coverage run on cloud/* branches fails. The Vue-only PR on cloud/k36-busy-button (run 42568091384) fails on the same tests with identical totals (Tests: 49064, Assertions: 161393, Errors: 11, Failures: 11).

I found no fix for these suites to port in this round's scope, and the lane's rules keep this PR's diff to its own files. I didn't re-run the job, because the failure already reproduces outside this PR. The MCP and Integration suites this PR touches pass locally on the branch merged with current development.


Generated by Claude Code

@rubenvdlinde
rubenvdlinde merged commit 24bdc99 into development Nov 9, 2026
32 of 42 checks passed
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/openregister @ 76e7106

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ✅
eslint ❌
stylelint ✅
build ✅
check-specs ✅
test-l10n ❌
test-l10n-parity ❌
format ❌
check-schema-l10n ✅
test-coverage-ratchet ✅
composer ✅ ✅ 168/168
npm ✅ ✅ 641/641
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌ cancelled — no verdict
Newman ❌ 1625/1628
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-09 13:05 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants