Repository navigation
refactor(integration,mcp): drop derivable constructor parameters - #7516
Merged
Merged
Conversation
LeafRegistry no longer takes an optional LeafBundle: no construction site
passed one and LeafBundle is stateless over the app manager the registry
already holds. DerivedToolDefinition no longer carries the tool id: it is
{appId}.{slug}.{verb}, derived by the provider that owns the app id.
Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Author
|
Newman API Test Suite failed in its in-container PHPUnit step (
I found no fix for these suites to port in this round's scope, and the lane's rules keep this PR's diff to its own files. I didn't re-run the job, because the failure already reproduces outside this PR. The MCP and Integration suites this PR touches pass locally on the branch merged with current development. Generated by Claude Code |
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 13:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
SIG unit interfacing, lane K09 (round 10c). Two constructors drop a derivable parameter, going from 5 parameters to 4:
LeafRegistry::__constructno longer takes the optional trailing?LeafBundle $leafBundleService. No construction site passed it (IntegrationWiring::registerLeafRegistry, both test builders).LeafBundleis stateless over theIAppManagerthe registry already holds, so the registry always builds its own. Behaviour is unchanged.DerivedToolDefinitionno longer carriesstring $id. The id is always{appId}.{slug}.{verb}, and it is now derived by the new privateSchemaDerivedToolProvider::toolId(), because that provider owns the app id. Emitted descriptors are unchanged.No public signatures changed. A code search across the org finds
LeafRegistryin other repos only in comments, and no other repo usesDerivedToolDefinition.Note: open release-sync PR #5398 (beta → development) rewords the comment above the removed
LeafRegistryparameter. That file is not in this round's HELD list. The conflict is comment-only: keep this side.What ran (on this branch merged with current origin/development)
tests/Unit/Architecture tests/Unit/Contract tests/Unit/Kernel tests/Unit/Service/Rules tests/Unit/Controller/ControllerServicesWiringTest.php tests/Unit/Controller/ControllerSessionWiringTest.php: OK (2658 tests).tests/Unit/Mcp tests/Unit/Service/Integration tests/Unit/Capabilities tests/Unit/AppInfo/AttributeMcpDiscoveryTest.php tests/Unit/Tool/McpProviderBridgeTest.php: OK (949 tests). This includes the existingSchemaDerivedToolProviderCharacterisationTest,LeafRegistryTestandLeafRegistryRefusalGoldenTest.php -l, phpcs (no new warnings), phpstan: clean on the touched files.Numbers (lane_measure.py, lane K09)
The remaining units are fixed signatures, have builders in files other lanes own, or are held by open PRs. They are listed in the lane's final report.
AI disclosure: written by Claude Code (claude-opus-5-5) as an automated lane run. Assisted-by: ClaudeCode:claude-opus-5-5
Generated by Claude Code