Repository navigation
[access] refactor(retention): the destruction check, retention recalculation and webhook retry jobs take at most four parameters per unit - #7504
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
…object it is about sendObjectNotification took six parameters, five of them read off one object's retention block by its only caller. It now takes the object and the logger and reads the subject, title, action date and category itself, each through a typed helper so a mistyped category is refused exactly as before. Assisted-by: ClaudeCode:claude-opus-5-5
… the rest follow Assisted-by: ClaudeCode:claude-opus-5-5
…e place they live in recalculateBatch took the source uuid, the relation, the register and the schema beside the batch. Those four describe one place: where the dependants of one source live. RetentionDependantPlace carries them through the batch, the per-candidate step and the store step, so no unit takes more than two. Assisted-by: ClaudeCode:claude-opus-5-5
…s one bundle WebhookDeliveryStores holds the two tables a delivery is retried from; the constructor drops from five parameters to four. Wired by DI autowiring. Assisted-by: ClaudeCode:claude-opus-5-5
|
No fix exists for this yet, and it is outside this PR's scope, so nothing is pushed here. Generated by Claude Code |
|
Three frontend checks are red here as well. None of them comes from this PR, which changes only PHP files under
The same format, l10n and l10n-parity checks fail on docs-only PR #7484 (run 42564559789), so this is the state of development. I haven't found a fix for any of them, and they're out of this PR's scope, so nothing is pushed here. Generated by Claude Code |
|
Two more checks have failed since my last comment:
I haven't pushed anything for these, because a fix belongs outside this PR. Generated by Claude Code |
|
Running phpcs locally on the five production files this PR changes reports no errors. Fixing the eight flagged files belongs to the lanes that own them, so I've pushed nothing here. Generated by Claude Code |
|
A local phpstan run on the five production files this PR changes reports Generated by Claude Code |
|
Generated by Claude Code |
|
No fix for this belongs in this PR, so I have pushed nothing here. Generated by Claude Code |
|
Nothing to push here. Generated by Claude Code |
|
The second one exercises the job this PR touches, The unit tests of the job also pass on this branch, with the characterisation added first: I haven't pushed anything for this. Generated by Claude Code |
|
This PR's tests ( Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49038/49048 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 12:08 UTC
Download the full PDF report from the workflow artifacts.
Lane K13, round 10c (SIG unit interfacing).
What changed
DestructionCheckJob::sendObjectNotification(6 params) now takes the approaching object and the logger; it reads the subject, title, action date and category off the object itself through small typed helpers (subjectOf,titleOf,classificationOf). A category that isn't a string is still refused the way the old typed parameter refused it. The payload sent to the archivist group is unchanged.RelatedRetentionRecalculationJob::recalculateBatch(5 params) now takes the batch and aRetentionDependantPlace: the source uuid, the relation, the register and the schema of the dependants. That place goes through the batch, the per-candidate step (recalculateOne) and the store step (storeFollowed). The reference check, the failure logging and the counting are unchanged.WebhookRetryJob::__construct(5 params) takes the webhook and webhook-log mappers as oneWebhookDeliveryStoresbundle, wired by DI autowiring.No access decision changed: retention reads stay
_rbac: false, _multitenancy: falseexactly as before, and the hold check still runs before any notification.Tests
DestructionCheckJobNotificationPayloadTestpins the full notification payload (destruction subject vs e-Depot subject, name vs uuid fallback, category vs empty) and the case where there is no archivist group. A mutation (title always the uuid) makes it fail.RelatedRetentionRecalculationJobTestgains a test where a dependant fails to store: it is skipped and the others still follow.Numbers (lane_measure.py, lane K13)
AI disclosure: this PR was written by Claude Code (claude-opus-5-5) running as an automated lane.
Generated by Claude Code