Repository navigation
[access] refactor(objects): the deleted-object bundle and destruction jobs reach RenderObject and SaveObject through their contracts - #7394
Conversation
…list Assisted-by: ClaudeCode:claude-opus-5-5
…ch RenderObject and SaveObject through their contracts DeletedAccess types its render handler as RenderObjectInterface, and DestructionCheckJob and DestructionListRun resolve the save handler as SaveObjectWriterInterface. Both contracts are already bound in ContractBindings as aliases of the same shared instances, so the resolved objects are unchanged. RenderObject and SaveObject are no longer named outside lib/Service. D2's kept list for RenderObject shrinks to nothing; G10InterfaceBindingsTest pins both bindings. Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite (api-test-coverage) is red, and the failures are not from this PR. The job's unit-test step reports 11 errors and 11 failures, all in tests this diff does not touch:
Each of these depends on the real Nextcloud server the job runs against. This PR only changes The api-test-coverage runs on Generated by Claude Code |
|
quality / Frontend Check (test:l10n:parity) is red because of I reproduced it locally with This PR only changes The fix is the §6.15 procedure in Generated by Claude Code |
|
quality / Frontend Check (format) is red because of Prettier reports code-style issues in 116 frontend files under The fix is a repo-wide Generated by Claude Code |
|
quality / Vue Quality (eslint) and quality / Frontend Check (test:l10n) are also red because of Both checks lint or scan only the frontend (
No fix to port exists in this lane's scope, and the lane rules forbid more commits on this branch. Generated by Claude Code |
|
quality / PHP Quality (phpstan) is red because of phpstan reports 24 errors, and none of them is in a file this PR changes. The files with errors are:
Most errors are calls to methods that are missing from narrowed interfaces, for example The four lib files this PR touches ( Those interfaces are owned by other lanes, and the lane rules forbid more commits on this branch, so I have not ported a fix here. Generated by Claude Code |
|
quality / PHP Quality (phpcs) is red because of phpcs reports errors in 8 files, all of which this PR leaves untouched:
Almost all are lines over 150 characters. I ran phpcs locally on the four lib files this PR touches: 0 errors, and only the two pre-existing The lane rules forbid more commits on this branch, so I have not ported a fix here. Generated by Claude Code |
|
quality / PHP Quality (psalm) is red because of Psalm reports 54 errors, none of them in a file this PR changes. They include:
I ran The lane rules forbid more commits on this branch, so I have not ported a fix here. Generated by Claude Code |
|
quality / PHP Quality (phpmd) is red because of I ran the repo's phpmd commands locally against the four lib files this PR touches ( The lane rules forbid more commits on this branch, so I have not ported a fix here. Generated by Claude Code |
|
quality / Hydra Gates is red because of 7 gates fail, all on repo-wide counts:
This PR adds no controller method, Vue component, form, The lane rules forbid more commits on this branch, so I have not ported a fix here. Generated by Claude Code |
|
quality / Integration Tests (Newman): 1625 of 1628 assertions pass, across all 39 collections, with 0 request or script errors. The failing assertion I can see in the log is in the flow collection:
That is a flow step calling an external source. This PR does not touch flows, sources or notifications. The only paths this PR changes are the destruction jobs and the deleted-objects bundle. The destruction-list requests in the run return I have not re-run this job. A re-run of failed jobs would also repeat the static-analysis jobs, which fail deterministically on Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-08 21:58 UTC
Download the full PDF report from the workflow artifacts.
Lane G10, round 10, phase A1 (Objects core). This PR raises SIG component independence.
What changed
lib/Controller/Support/DeletedAccess.php:$renderObjectis now typed asRenderObjectInterfaceinstead ofRenderObject. Its only caller,DeletedController, callsredactWriteOnlyFromRows(), and that method is on the interface.lib/Controller/DeletedController.php: removed the unuseduse ...\RenderObject;.lib/BackgroundJob/DestructionListRun.phpandlib/BackgroundJob/DestructionCheckJob.php: the save handler is now resolved and typed asSaveObjectWriterInterfaceinstead ofSaveObject. Both call onlysaveObject().ContractBindingsas aliases. Each one resolves to the same shared instance as before, so DI behaves exactly as it did. There are no new interfaces and no new bindings, soObjectsBindingsis unchanged.::classlookups were edited. No logic changed.Tests
tests/Unit/BackgroundJob/DestructionCheckJobListCreationTest.php. It pins three cases: an eligible set is saved as one list (register and schema,_rbac/_multitenancyoff, persisted, silent) and announced to the archivists; nothing eligible saves nothing; a list that could not be built saves nothing. It passes before and after the change.tests/Unit/BackgroundJob/DestructionExecutionJobGoldenTest.phpand its fixture record the container lookup ids. The idSaveObjectbecameSaveObjectWriterInterface, which is a DI-equivalent alias. Everything else in the golden is identical.tests/Unit/Architecture/D2InterfaceBindingsTest.php: theKEPTallowlist entry forRenderObject(DeletedController, DeletedAccess) is removed, so the allowlist only shrinks.tests/Unit/Architecture/G10InterfaceBindingsTest.phpchecks, for both contracts, that the class implements it, the binding is present and the alias is registered.What ran (on the branch merged with current origin/development)
php -lis clean.phpcsshows only the 2 warnings that were already there before (missing@spectag on the class).phpstanon the touched lib files: no errors.Numbers (component independence, exposed PHP LOC)
These come from a local re-implementation of the hydra-gates
php_dependencies/component_of_factorylogic. Executing the external script itself was blocked in this session. The totals therefore differ slightly from the brief's base, but the delta is exact.Not done, and why
lib/Service/Object/DeleteObject.php, and that file is in open PR fix(delete): permanent delete now dispatches ObjectDeletedEvent #5497, which is outside this round. Skipped per the brief.new) or call them statically. Those callers arelib/Db/MagicMapper.php,MagicSearchHandlerandMagicRbacHandler(fix(search): refuse a sort on an encrypted property #6108),MagicBulkHandler(fix(db): normalise date/date-time properties in bulk writes #4773),ObjectsController(fix(objects): an administrator reads an object's log on a slug route #6219/refactor(objects): delete, delete analysis and contracts in small units #6179/refactor(objects): batched counts and object logs in small units #6178/refactor(kernel): ObjectEntity and Webhook get a Kernel interface; Kernel is a leaf (K3) #5116/refactor(contract): five more services get a contract their callers type-hint #5046) andDeferredObjectEventJob. Most are in open PRs from outside this round. Hiding these classes needs call-site changes, which go beyond "use lines and type hints only".AI disclosure: this change was made by Claude Code (an AI assistant) in an automated lane and has not yet been reviewed by a human.
Generated by Claude Code