Repository navigation
refactor(db): FlowMapper and ConfigurationMapper are reached through an interface - #6746
Conversation
…an interface Callers outside the Db component now type against FlowMapperInterface and ConfigurationMapperInterface, bound in DbRegistrar. The mappers' own fan-in drops from 28 and 13 to a handful; the remaining namers are files in open pull requests or resolved by name through a shared test harness, pinned in A04InterfaceBindingsTest so the list cannot grow. No behaviour changes: the alias resolves to the same shared instance. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5 # Conflicts: # lib/Service/ObjectAction/ObjectActionStepsFlow.php
…-config-interfaces
TaskFormResolver now takes its readers through TaskFormResolverServices (from development); the conflict is resolved on that side and the bundle types the flow reader as FlowMapperInterface instead. Assisted-by: ClaudeCode:claude-opus-5-5
|
Newman API Test Suite (workflow
There is no fix on Generated by Claude Code |
|
quality / Frontend Check (test:l10n) fails on
The missing keys come from Generated by Claude Code |
|
Three more frontend checks fail on
All three come from Generated by Claude Code |
|
Three more checks are red on
This PR only changes PHP types: interfaces, DbRegistrar bindings, caller type hints and one architecture test. Running phpstan, psalm and phpcs locally on those files gives no new findings. The red checks come from Generated by Claude Code |
|
PHP Quality (phpcs) also fails on There is one error in each of seven files: Run locally, phpcs on every file this PR changes is clean. These errors come from Generated by Claude Code |
…e mirrors ConfigurationMapperInterface repeats the $_multitenancy and $systemLookup flags of ConfigurationMapper's public signature, which the baseline already carries for the mapper. The interface gets the same entry instead of a suppression annotation. Assisted-by: ClaudeCode:claude-opus-5-5
…lass's FlowMapperInterface::findAllFlows and ConfigurationMapperInterface::findAll repeated the one-parameter-per-line layout of the signatures they mirror, which the SIG ratchet (gate-122) counts as a new 6-line clone. The parameters are grouped instead; the signatures are unchanged. Assisted-by: ClaudeCode:claude-opus-5-5
|
Hydra Gates on
Generated by Claude Code |
development retyped other dependencies on the same constructor lines (FlowRunStepMapperInterface, FlowVersionMapperInterface, AppConfigurationImporterInterface, ConfigurationTransferInterface) and added many DbRegistrar bindings. Each conflict takes development's side and keeps the FlowMapperInterface / ConfigurationMapperInterface types; DbRegistrar keeps both sets of bindings in order. Assisted-by: ClaudeCode:claude-opus-5-5
|
quality / Integration Tests (Newman) failed on
None of the three goes through code this PR changes in behaviour. The PR only retypes I can't yet compare with Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ⏭️ | ||||
| phpcs | ⏭️ | ||||
| phpmd | ⏭️ | ||||
| psalm | ⏭️ | ||||
| phpstan | ⏭️ | ||||
| phpmetrics | ⏭️ | ||||
| eslint | ⏭️ | ||||
| stylelint | ⏭️ | ||||
| build | ⏭️ | ||||
| composer | ⏭️ | ⏭️ | |||
| npm | ⏭️ | ⏭️ | |||
| app:check-code | ⏭️ | ||||
| info.xml | ⏭️ | ||||
| REUSE | ⏭️ | ||||
| lockfile sync | ⏭️ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ cancelled — no verdict | ||||
| Playwright | ❌ cancelled — no verdict | ||||
| Hydra gates | ❌ cancelled — no verdict |
Quality workflow — 2026-11-08 20:45 UTC
Download the full PDF report from the workflow artifacts.
development retyped FlowSemanticVersion, FlowTriggerIndex and PrincipalResolverRegistry on the same Repair lines and added the ConfigurationDeployment/Draft mapper bindings. Each conflict takes development's side and keeps the FlowMapperInterface type; DbRegistrar keeps both sets of bindings in order. Assisted-by: ClaudeCode:claude-opus-5-5
|
Follow-up on Integration Tests (Newman). On the current head I still can't compare against
When the Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 48933/48943 · 20 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-08 22:06 UTC
Download the full PDF report from the workflow artifacts.
What changed
FlowMapper(fan-in 28) andConfigurationMapper(fan-in 13) get a narrow interface next to them,FlowMapperInterfaceandConfigurationMapperInterface, bound inDbRegistrar(alphabetical). Constructor-injected callers and container lookups by class constant switch to the interface; the alias resolves to the same shared instance, so nothing changes at runtime.A few callers keep naming the class, on purpose:
ExportHandlerandImportHandler(ConfigurationMapper): both are touched by open pull requests.ExampleSetFlows,FlowRunService,FlowDelegationCheck,FlowRunVersionPin,FlowRunAttribution(FlowMapper): they resolve the mapper from the container by name, and a shared test harness or a golden test keys its container fake on that name.tests/Unit/Architecture/A04InterfaceBindingsTest.phppins the bindings and the implementations, and makes sure no file outside Db names either class beyond that known list. After the change, FlowMapper has 6 incoming dependencies and ConfigurationMapper has 4.No behaviour, route, migration, stored data or public signature changes.
What ran
phpunit -c phpunit.xml --no-coverageon these paths: tests/Unit/Service/Flow (1,867), tests/Unit/Repair (178), tests/Unit/AppHost/Scheduling, tests/Unit/BackgroundJob, tests/Unit/Listener, tests/Unit/WorkflowEngine, tests/Unit/Service/{ObjectAction,Task,Config}, every test that names ConfigurationMapper or ConfigurationService (87 files), plus tests/Unit/Contract, Architecture, Kernel, Service/Interaction and Controller/ControllerServicesWiringTest.php. All green.php -l,phpcs(no new findings) andphpstanon every touched file. phpstan's only messages are two "only written" property notes on ConfigurationMapper, and those also show up at base.Rating (my area: lib/Db outside the entities and the MagicMapper and SchemaMapper directories;
check_sig_maintainabilityfive-star profile, fan-in measured across the whole app)AI-assisted: this change was written by Claude Code (claude-opus-5-5) in an automated session and is not merged; it needs a human review.
Generated by Claude Code