Repository navigation
fix(register): LearnerProfile imports on OpenRegister development; rename-to-learniq upgrade verified - #1466
Merged
Merged
Conversation
…calculations ageYears, hasPartialSelfServiceRights and hasFullSelfServiceRights carried `expression` and `materialise` directly on the property. Neither is an OpenRegister property-vocabulary key, so OpenRegister (development) refused the whole LearnerProfile schema on import: Failed to import schema: Unknown property key(s) 'expression, materialise' at '/ageYears' PARTIAL IMPORT: 1 of 147 schema(s) were rejected ... learner-profile Seen live on a throwaway instance (:8090) upgrading from scholiq 0.2.13 to learniq development. The declaration now sits under `calculation`, the property-level form of x-openregister-calculations, and reads `birthDate` by name: `@self.` only reaches system fields. The new test is red on the old shape (2 failures) and green on this one.
…ed on a throwaway instance
…elopment and green with the LearnerProfile fix
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 747/747 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-09-29 16:05 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Quality Report — ConductionNL/learniq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| format | ✅ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 107/107 | |||
| npm | ✅ | ✅ 747/747 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it on any branch from the Actions tab, or locally with npx playwright test. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-09-29 17:57 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live checks for rename-to-learniq on a throwaway instance: Nextcloud 34 on :8090 with its own Postgres and bind-mounted data, OpenRegister development. The shared :8080 instance was not touched.
Product fix
LearnerProfile's
ageYears,hasPartialSelfServiceRightsandhasFullSelfServiceRightsputexpressionandmaterialisedirectly on the property. Neither is an OpenRegister property-vocabulary key, so OpenRegister development refused the whole schema:Unknown property key(s) 'materialise, expression' at '/ageYears', thenPARTIAL IMPORT: 1 of 147 ... learner-profile. On a clean install the register came up without its learner schema.They now sit under
calculation(the property-level form ofx-openregister-calculations) and readbirthDateby name.@self.only reaches system fields, so@self.birthDatedid not work.LearnerProfileAgeCalculationRegisterTestfails on the old shape (2 failures) and passes on the new one.A second cause was in OpenRegister: it refused
authorization.auditonpersonalNumber. That fix is in ConductionNL/openregister#4177. A clean install needs both fixes before LearnerProfile imports.Boxes ticked (evidence under each in tasks.md)
v0.2.13-dev.20260818065757(app id scholiq) to learniq development. Register row 20 was renamed in place tolearniq. The 12 sampled objects come back with the same ids and identical property values. The 118 shard tables are all still there with identical row counts, and all 60 rows match apart from_versionand_updated.scholiq.actionsvalues come back unchanged fromocc config:app:get learniq actions.Evidence added, box left open
learniq. The start-screen render was not checked.Not done: the lane stopped because C: fell under 10 GB free
The rest of the brief could not run: the e2e route smoke against :8090 (task 12), manifest-fragment-split TC-2, the leaf screenshots and the hermiq-absent check. The instance state is kept in bind mounts, so it can be resumed from
~/memcap-work/lq-throwaway/RESUME.md. The C: space is going somewhere else: my containers wrote about 75 KB of logs and all their data sits on the Linux disk.Found, not fixed
On an instance already upgraded before these fixes,
learner-profilestays in its 0.2.13 shape (16 properties) even after a forcedPOST /api/settings/loadwith both fixes in, and nothing is logged. The first failed import is what left it there. The learner objects are not affected.Verified before push
COMPOSER_PROCESS_TIMEOUT=0 composer check:strict: exit 0 (ALL CHECKS PASSED)npm run lint: exit 0 (0 errors)npm run check:specs: exit 0npm run check:schema-l10nreports 3 fewer uncovered strings than its baseline, both on development and on this branch.🤖 Generated with Claude Code