Skip to content

fix(l10n): the eight manifest strings that render English to a Dutch user - #364

Merged
rubenvdlinde merged 2 commits into
developmentfrom
fix/manifest-strings-need-dutch-keys
Aug 28, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
fix/manifest-strings-need-dutch-keys

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Fixes gate-99 manifest-l10n-coverage, failing on development.

What is wrong

Eight strings the manifest renders have no key in l10n/nl.json, so a Dutch user sees the English source:

manifest string where now translated as
launchpad.menu.dashboards menu label Dashboards
launchpad.menu.adminTemplates menu label Sjablonen
launchpad.menu.adminSettings menu label Instellingen
launchpad.pages.dashboard page title Dashboard
launchpad.pages.adminTemplates page title Sjablonen
launchpad.pages.adminSettings page title Instellingen
Flow page title Flow
Flows menu label Flows

Flow and Flows stay untranslated — that is what opencatalogi, dossiq, openregister and integriq all already do, so this follows the fleet rather than inventing a fourth answer.

Why nothing else caught it

From the gate's own message: check:l10n-js compares nl.json to nl.js, and a string absent from both is in sync. Only this gate looks at what the manifest actually renders.

Both files, together

nl.js is updated alongside nl.json. Adding to nl.json alone would simply trade this gate for check:l10n-js.

There is pre-existing drift between the two files (26 keys in nl.js only, plus plural-shape differences). I have not touched it — the 8 keys are added identically to both, so the drift is not widened. check:l10n-js passes today and still will.

Verification

check_manifest_l10n_coverage.py run locally against this tree: no FAIL lines, checked 9 manifest string(s). Before the change it reported all 8 by name, matching CI's count exactly.

nl.js was additionally evaluated as real JavaScript (stubbing OC.L10N.register) to confirm it still parses and that all 8 new keys carry values identical to nl.json.

Why it reached development

Every Code Quality run on development since was cancelled rather than completed — fixed by ConductionNL/.github#597, which is what surfaced this.

…user

gate-99 manifest-l10n-coverage fails on development: eight strings the
manifest renders have no key in l10n/nl.json, so a Dutch user sees the
English source. Nothing else reports it -- check:l10n-js compares nl.json
to nl.js, and a string absent from BOTH is in sync.

Flow and Flows are kept untranslated, which is what opencatalogi, dossiq,
openregister and integriq all already do.

Both files are updated together: adding to nl.json alone would trade this
gate for check:l10n-js.
…user

gate-99 manifest-l10n-coverage fails on development: eight strings the
manifest renders have no key in l10n/nl.json, so a Dutch user sees the
English source. Nothing else reports it -- check:l10n-js compares nl.json
to nl.js, and a string absent from BOTH is in sync.

Flow and Flows are kept untranslated, which is what opencatalogi, dossiq,
openregister and integriq all already do.

Both files are updated together: adding to nl.json alone would trade this
gate for check:l10n-js.
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 9e7ab62

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ✅
check-schema-l10n ✅
composer ✅ ✅ 104/104
npm ✅ ✅ 538/538
app:check-code ⏭️
info.xml ✅
REUSE ❌
PHPUnit ✅
Newman ✅
Playwright ✅
Hydra gates ✅

Quality workflow — 2026-08-28 06:13 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde merged commit 0dff49f into development Aug 28, 2026
35 checks passed
@rubenvdlinde
rubenvdlinde deleted the fix/manifest-strings-need-dutch-keys branch August 28, 2026 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant