Repository navigation
fix(l10n): the eight manifest strings that render English to a Dutch user - #364
Merged
Merged
Conversation
…user gate-99 manifest-l10n-coverage fails on development: eight strings the manifest renders have no key in l10n/nl.json, so a Dutch user sees the English source. Nothing else reports it -- check:l10n-js compares nl.json to nl.js, and a string absent from BOTH is in sync. Flow and Flows are kept untranslated, which is what opencatalogi, dossiq, openregister and integriq all already do. Both files are updated together: adding to nl.json alone would trade this gate for check:l10n-js.
…user gate-99 manifest-l10n-coverage fails on development: eight strings the manifest renders have no key in l10n/nl.json, so a Dutch user sees the English source. Nothing else reports it -- check:l10n-js compares nl.json to nl.js, and a string absent from BOTH is in sync. Flow and Flows are kept untranslated, which is what opencatalogi, dossiq, openregister and integriq all already do. Both files are updated together: adding to nl.json alone would trade this gate for check:l10n-js.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
August 28, 2026 05:47
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 104/104 | |||
| npm | ✅ | ✅ 538/538 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| PHPUnit | ✅ | ||||
| Newman | ✅ | ||||
| Playwright | ✅ | ||||
| Hydra gates | ✅ |
Quality workflow — 2026-08-28 06:13 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gate-99 manifest-l10n-coverage, failing on
development.What is wrong
Eight strings the manifest renders have no key in
l10n/nl.json, so a Dutch user sees the English source:launchpad.menu.dashboardslaunchpad.menu.adminTemplateslaunchpad.menu.adminSettingslaunchpad.pages.dashboardlaunchpad.pages.adminTemplateslaunchpad.pages.adminSettingsFlowFlowsFlowandFlowsstay untranslated — that is what opencatalogi, dossiq, openregister and integriq all already do, so this follows the fleet rather than inventing a fourth answer.Why nothing else caught it
From the gate's own message:
check:l10n-jscomparesnl.jsontonl.js, and a string absent from both is in sync. Only this gate looks at what the manifest actually renders.Both files, together
nl.jsis updated alongsidenl.json. Adding tonl.jsonalone would simply trade this gate forcheck:l10n-js.There is pre-existing drift between the two files (26 keys in
nl.jsonly, plus plural-shape differences). I have not touched it — the 8 keys are added identically to both, so the drift is not widened.check:l10n-jspasses today and still will.Verification
check_manifest_l10n_coverage.pyrun locally against this tree: no FAIL lines,checked 9 manifest string(s). Before the change it reported all 8 by name, matching CI's count exactly.nl.jswas additionally evaluated as real JavaScript (stubbingOC.L10N.register) to confirm it still parses and that all 8 new keys carry values identical tonl.json.Why it reached development
Every Code Quality run on
developmentsince was cancelled rather than completed — fixed by ConductionNL/.github#597, which is what surfaced this.