Skip to content

feat(launchpad): build drill-down-cross-widget-filter - #1302

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-drill-down-cross-widget-filter
Open

rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-drill-down-cross-widget-filter

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Second pass on openspec/changes/drill-down-cross-widget-filter: the Playwright specs the tasks name.

Done

  • tests/e2e/support/filterBus.ts: throwaway non-admin accounts with their own dashboard, and the f encoder that matches useDashboardFilter.js. Specs open a dashboard with a known filter state, a pinned clause included, without a widget click.
  • tests/e2e/cross-widget-filter.spec.ts covers Tasks 22 (URL half), 25 and 26: restore in a fresh login, reset keeps only the pinned clause and f shrinks to it, an unfiltered dashboard has no panel or f, and the panel's lock, source note and remove behaviour.
  • tests/e2e/cross-widget-filter-saved-views.spec.ts covers Task 27: save, restore over another filter, share, and read-only for a second user the dashboard is shared with.
  • tests/e2e/cross-widget-filter-telemetry.spec.ts covers Task 28: with the switch on, the bookmark and reset rows carry no values; with it off, no rows are written.

Left open

  • Task 7: charts publishing on click is blocked on @conduction/nextcloud-vue (CnChartWidget emits no selection event). Because of that, the click halves of Tasks 22, 26 and 28 and all of Tasks 23 and 24 cannot be tested end to end yet.
  • Task 9 (findings in the widget config UI) and Task 29 depend on the library's widget config modal.
  • Tasks 10 and 35 need profiling on production; Task 32's toast and tooltip have no call site until Task 7 lands.
  • The new specs are not ticked because they have not run against a live instance. They lint and list 8 tests.

Tests

  • Test files only, no production code changed. Vitest is unaffected.

Generated by Claude Code

Round 2: Playwright specs for the URL restore, reset, active-filters
panel, saved views and telemetry (Tasks 22, 25-28), seeded through the
f parameter as throwaway non-admin accounts.

Assisted-by: ClaudeCode:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant