Repository navigation
feat(launchpad): build drill-down-cross-widget-filter - #1302
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
Round 2: Playwright specs for the URL restore, reset, active-filters panel, saved views and telemetry (Tasks 22, 25-28), seeded through the f parameter as throwaway non-admin accounts. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn and
remko48
as code owners
November 17, 2026 14:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second pass on
openspec/changes/drill-down-cross-widget-filter: the Playwright specs the tasks name.Done
tests/e2e/support/filterBus.ts: throwaway non-admin accounts with their own dashboard, and thefencoder that matchesuseDashboardFilter.js. Specs open a dashboard with a known filter state, a pinned clause included, without a widget click.tests/e2e/cross-widget-filter.spec.tscovers Tasks 22 (URL half), 25 and 26: restore in a fresh login, reset keeps only the pinned clause andfshrinks to it, an unfiltered dashboard has no panel orf, and the panel's lock, source note and remove behaviour.tests/e2e/cross-widget-filter-saved-views.spec.tscovers Task 27: save, restore over another filter, share, and read-only for a second user the dashboard is shared with.tests/e2e/cross-widget-filter-telemetry.spec.tscovers Task 28: with the switch on, the bookmark and reset rows carry no values; with it off, no rows are written.Left open
@conduction/nextcloud-vue(CnChartWidgetemits no selection event). Because of that, the click halves of Tasks 22, 26 and 28 and all of Tasks 23 and 24 cannot be tested end to end yet.Tests
Generated by Claude Code