Repository navigation
feat(launchpad): add an "Add widget" entry to the More menu - #1295
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
The widget picker (app catalogue, office tile pack, apps discovered on this server) had no way in from the start page since the edit toolbar was trimmed on 3 May. The More menu's "This dashboard" group now offers "Add widget", which enters edit mode and opens WidgetPickerModal; the custom-widget modal stays one entry below as "Add custom widget…". The "Add widget" frontend key was missing from every locale but nl; it is added to all of them, harvested from each locale's "Add Widget". Tests: DashboardMoreMenu spec covers both entries and their events; Views wiring spec asserts the entry opens the picker with the discovered and catalogue apps; a new WidgetPickerModal sections spec asserts the three sections render and place; a new e2e spec opens the picker from the More menu and checks the three sections. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an Add widget entry to the start page's More menu ("This dashboard" group) that enters edit mode and opens
WidgetPickerModal. The picker holds the app catalogue, the office tile pack and the apps discovered on this server, and had no entry point since the edit toolbar was trimmed (9ad1613). The custom-widget modal stays available as Add custom widget… right below it.Changes
DashboardMoreMenu.vue:add-widgetnow emitsaddWidget; newadd-custom-widgetentry emitsaddCustomWidget(both gated oncanEdit).Views.vue:@addWidget="openWidgetModal".l10n/*.js: theAdd widgetkey was missing from every frontend locale except nl; added to all, harvested from each locale's existingAdd Widgetvalue.Tests
DashboardMoreMenu.spec.js: both entries, order and emitted events.Views.templateWiring.coverage.spec.js: the entry takes the edit lock and opens the picker with the discovered and catalogue apps (seen to fail with the wiring removed).WidgetPickerModal.sections.spec.js: catalogue, office and discovered sections render in order and each places through its own event.tests/e2e/more-menu-add-widget.spec.ts: opens the picker from the More menu and checks the three sections (not run here; needs a live instance).Suite: vitest 2737 passed, 1 failed before and after (
propDefinitions.golden.spec.js, fails on development as well). ESLint clean on touched files.After this lands, launcher-discover-server-services, launcher-app-catalogue and integrations-office-tiles can be live-checked.
Generated by Claude Code