Skip to content

feat(launchpad): add an "Add widget" entry to the More menu - #1295

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/gap-launchpad-addwidget
Open

rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/gap-launchpad-addwidget

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Adds an Add widget entry to the start page's More menu ("This dashboard" group) that enters edit mode and opens WidgetPickerModal. The picker holds the app catalogue, the office tile pack and the apps discovered on this server, and had no entry point since the edit toolbar was trimmed (9ad1613). The custom-widget modal stays available as Add custom widget… right below it.

Changes

  • DashboardMoreMenu.vue: add-widget now emits addWidget; new add-custom-widget entry emits addCustomWidget (both gated on canEdit).
  • Views.vue: @addWidget="openWidgetModal".
  • l10n/*.js: the Add widget key was missing from every frontend locale except nl; added to all, harvested from each locale's existing Add Widget value.

Tests

  • DashboardMoreMenu.spec.js: both entries, order and emitted events.
  • Views.templateWiring.coverage.spec.js: the entry takes the edit lock and opens the picker with the discovered and catalogue apps (seen to fail with the wiring removed).
  • New WidgetPickerModal.sections.spec.js: catalogue, office and discovered sections render in order and each places through its own event.
  • New e2e tests/e2e/more-menu-add-widget.spec.ts: opens the picker from the More menu and checks the three sections (not run here; needs a live instance).

Suite: vitest 2737 passed, 1 failed before and after (propDefinitions.golden.spec.js, fails on development as well). ESLint clean on touched files.

After this lands, launcher-discover-server-services, launcher-app-catalogue and integrations-office-tiles can be live-checked.


Generated by Claude Code

The widget picker (app catalogue, office tile pack, apps discovered on
this server) had no way in from the start page since the edit toolbar
was trimmed on 3 May. The More menu's "This dashboard" group now offers
"Add widget", which enters edit mode and opens WidgetPickerModal; the
custom-widget modal stays one entry below as "Add custom widget…".

The "Add widget" frontend key was missing from every locale but nl; it
is added to all of them, harvested from each locale's "Add Widget".

Tests: DashboardMoreMenu spec covers both entries and their events;
Views wiring spec asserts the entry opens the picker with the discovered
and catalogue apps; a new WidgetPickerModal sections spec asserts the
three sections render and place; a new e2e spec opens the picker from
the More menu and checks the three sections.

Assisted-by: ClaudeCode:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant