Skip to content

fix(launchpad): join a community through Talk; e2e for communities and launch tiles; two archives - #1284

Merged
rubenvdlinde merged 5 commits into
developmentfrom
quality/livepass-launchpad-4
Nov 17, 2026
Merged

rubenvdlinde merged 5 commits into
developmentfrom
quality/livepass-launchpad-4

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Third live-pass batch for launchpad: two defects in the Communities widget fixed, two new e2e specs, and two changes archived.

Defects

  • Nobody could join a community. joinCommunity() posted to Talk's room/{token}/participants/self. Talk only answers that path for DELETE (leaving), so every Join got 405 and the widget showed "You could not join …". On a listable conversation, joining means opening a session on participants/active, and that makes the user a member. The widget now does that and then closes the session, so the user is not shown as present. I checked on Talk 24.0.8 that membership (type 3) stays after the session closes. The unit test had pinned the wrong path. tests/e2e/communities-widget.spec.ts was red before the fix.
  • The "Pinned by your organisation" mark was nearly invisible. It used --color-primary-element-text, a text colour meant for a primary background, on a light row. It now uses the main text colour, in bold: measured live, rgb(34,34,34) on rgb(245,245,245).

Tests

  • tests/e2e/communities-widget.spec.ts: with two listable Talk conversations, one of them pinned, the reader sees the pinned one first with its mark, joins the other from the widget, and Talk confirms the membership. It skips with a reason when Talk is not enabled.
  • tests/e2e/tile-launch-types.spec.ts: an sso tile links to the launch template with the app id, in a new tab. An RDP tile downloads <title>.rdp with host, program and gateway and no credentials. A user who may not view the dashboard gets 403 on the file.

Archived

  • engagement-communities: the spec becomes openspec/specs/communities-widget, and e-communities is built with evidence.
  • engagement-activity-digest: the change's own recipe was run by hand on the rig. With the recipient's activity mail set to daily, a share queued one dashboard_shared mail row, and a later edit queued none. The delta is folded into activity-feed-integration, and e-digest is built.
  • launcher-tile-launch-types: task 7 is ticked. The change stays open for the admin section's axe check and its archive task.

What ran locally

  • The 4 e2e tests above, against a throwaway NC 34 with Talk 24.0.8: they pass.
  • Vitest for the talk service and the widget: 13 passed. The join test is red with the old path.
  • eslint on the changed files: clean.
  • composer check:strict and npm run lint, once each: phpstan clean, PHPUnit green (4621 tests). phpcs, phpmd and psalm are red on development too, and so are the 2 eslint errors in src/components/Announcements/__tests__/announcements.spec.js. This PR changes no PHP and does not touch that file.
  • Diff-scoped hydra gates: gate-23 flags an untouched file (lib/Service/Embed/TenantThemeValidator.php). gate-19 lists scenarios without an e2e. It marks them advisory and non-blocking. Most belong to launcher-tile-launch-types, which is still open, and to the four email scenarios of the digest change, which that change excluded. communities-widget::talk-disabled would need Talk switched off on the instance during the run.

Seen, not changed (needs a decision)

  • WidgetPickerModal has no way to open it. Its only opener was the edit toolbar's "Add Widget", removed on 3 May (9ad161303), and nothing calls openWidgetModal() since then except a unit test. Everything built into that modal is therefore unreachable in the UI: "Discovered on this server" (launcher-discover-server-services), the app catalogue (launcher-app-catalogue) and the office pack (integrations-office-tiles). "Add widget" in the More menu opens the custom-widget form instead. Which entry should open the picker is a call for the board (LpVandaag), so those changes' Playwright tasks stay open.

Assisted-by: ClaudeCode:claude-opus-5-5

The Communities widget posted to room/{token}/participants/self, which Talk
only answers for DELETE (leave), so every Join failed with 405 and the
widget said the user could not join. Joining a listable conversation is
opening a session on participants/active, which makes the user a member;
the widget now closes that session again so the user does not show as
present. The unit test had pinned the wrong path.

tests/e2e/communities-widget.spec.ts joins from the widget on a live NC 34
with Talk 24 and checks the membership in Talk; red before the fix.

Assisted-by: ClaudeCode:claude-opus-5-5
It used --color-primary-element-text, the text colour meant for a primary
background, on the widget's light row, so it was close to invisible.

Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
… e2e task

Communities passed its Playwright task on NC 34 with Talk after the join
fix; its spec becomes openspec/specs/communities-widget and e-communities is
built with evidence. launcher-tile-launch-types keeps its admin-section axe
check and its archive task open.

Assisted-by: ClaudeCode:claude-opus-5-5
On NC 34 a dashboard share queued one daily dashboard_shared mail row for
the recipient and a later edit queued none, as the change's recipe asked.
The delta is folded into activity-feed-integration and e-digest is built.

Assisted-by: ClaudeCode:claude-opus-5-5
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ e8e7a5a

Check PHP Vue Security License Tests
lint ❌
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ❌
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ❌
composer ❌ ❌
npm ✅ ✅ 636/636
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 13:15 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde

Copy link
Copy Markdown
Contributor Author

Final regression on the rig before merge: the 12 e2e files touched by the live pass, 39 tests, all passed (18.5 min).

@rubenvdlinde
rubenvdlinde merged commit ec73a83 into development Nov 17, 2026
30 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant