Repository navigation
fix(launchpad): join a community through Talk; e2e for communities and launch tiles; two archives - #1284
Merged
Conversation
The Communities widget posted to room/{token}/participants/self, which Talk
only answers for DELETE (leave), so every Join failed with 405 and the
widget said the user could not join. Joining a listable conversation is
opening a session on participants/active, which makes the user a member;
the widget now closes that session again so the user does not show as
present. The unit test had pinned the wrong path.
tests/e2e/communities-widget.spec.ts joins from the widget on a live NC 34
with Talk 24 and checks the membership in Talk; red before the fix.
Assisted-by: ClaudeCode:claude-opus-5-5
It used --color-primary-element-text, the text colour meant for a primary background, on the widget's light row, so it was close to invisible. Assisted-by: ClaudeCode:claude-opus-5-5
Assisted-by: ClaudeCode:claude-opus-5-5
… e2e task Communities passed its Playwright task on NC 34 with Talk after the join fix; its spec becomes openspec/specs/communities-widget and e-communities is built with evidence. launcher-tile-launch-types keeps its admin-section axe check and its archive task open. Assisted-by: ClaudeCode:claude-opus-5-5
On NC 34 a dashboard share queued one daily dashboard_shared mail row for the recipient and a later edit queued none, as the change's recipe asked. The delta is folded into activity-feed-integration and e-digest is built. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn and
remko48
as code owners
November 17, 2026 13:00
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ❌ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-17 13:15 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Author
|
Final regression on the rig before merge: the 12 e2e files touched by the live pass, 39 tests, all passed (18.5 min). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third live-pass batch for launchpad: two defects in the Communities widget fixed, two new e2e specs, and two changes archived.
Defects
joinCommunity()posted to Talk'sroom/{token}/participants/self. Talk only answers that path for DELETE (leaving), so every Join got 405 and the widget showed "You could not join …". On a listable conversation, joining means opening a session onparticipants/active, and that makes the user a member. The widget now does that and then closes the session, so the user is not shown as present. I checked on Talk 24.0.8 that membership (type 3) stays after the session closes. The unit test had pinned the wrong path.tests/e2e/communities-widget.spec.tswas red before the fix.--color-primary-element-text, a text colour meant for a primary background, on a light row. It now uses the main text colour, in bold: measured live, rgb(34,34,34) on rgb(245,245,245).Tests
tests/e2e/communities-widget.spec.ts: with two listable Talk conversations, one of them pinned, the reader sees the pinned one first with its mark, joins the other from the widget, and Talk confirms the membership. It skips with a reason when Talk is not enabled.tests/e2e/tile-launch-types.spec.ts: an sso tile links to the launch template with the app id, in a new tab. An RDP tile downloads<title>.rdpwith host, program and gateway and no credentials. A user who may not view the dashboard gets 403 on the file.Archived
openspec/specs/communities-widget, and e-communities isbuiltwith evidence.dashboard_sharedmail row, and a later edit queued none. The delta is folded intoactivity-feed-integration, and e-digest isbuilt.What ran locally
composer check:strictandnpm run lint, once each: phpstan clean, PHPUnit green (4621 tests). phpcs, phpmd and psalm are red ondevelopmenttoo, and so are the 2 eslint errors insrc/components/Announcements/__tests__/announcements.spec.js. This PR changes no PHP and does not touch that file.lib/Service/Embed/TenantThemeValidator.php). gate-19 lists scenarios without an e2e. It marks them advisory and non-blocking. Most belong to launcher-tile-launch-types, which is still open, and to the four email scenarios of the digest change, which that change excluded.communities-widget::talk-disabledwould need Talk switched off on the instance during the run.Seen, not changed (needs a decision)
WidgetPickerModalhas no way to open it. Its only opener was the edit toolbar's "Add Widget", removed on 3 May (9ad161303), and nothing callsopenWidgetModal()since then except a unit test. Everything built into that modal is therefore unreachable in the UI: "Discovered on this server" (launcher-discover-server-services), the app catalogue (launcher-app-catalogue) and the office pack (integrations-office-tiles). "Add widget" in the More menu opens the custom-widget form instead. Which entry should open the picker is a call for the board (LpVandaag), so those changes' Playwright tasks stay open.Assisted-by: ClaudeCode:claude-opus-5-5