Skip to content

fix(launchpad): a dashboard address opens that dashboard; e2e on the More menu, six archives - #1282

Merged
rubenvdlinde merged 10 commits into
developmentfrom
quality/livepass-launchpad-3
Nov 17, 2026
Merged

rubenvdlinde merged 10 commits into
developmentfrom
quality/livepass-launchpad-3

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Second live-pass batch for launchpad: one defect fixed, two stale e2e specs moved to the More menu, one e2e test that could never run made to run, one new e2e spec, and six changes archived.

The defect

Opening /apps/launchpad/dashboards/<id> cold mostly showed the stored active dashboard instead. On a live NC 34 instance, 5 of 6 cold loads landed on the wrong dashboard. The route's watcher switched as soon as the page started, while the first loadDashboards() was still fetching the stored active dashboard, and that later answer replaced the switch. The route now calls openDashboard(), which holds the id until the first load is done and then switches. After the fix, 6 of 6 cold loads open the right dashboard, on both /apps/... and /index.php/apps/.... The new store Vitest fails when the switch happens straight away.

Tests

  • tests/e2e/support/dashboardSwitcher.ts opens the switcher the way a person does now: More, then All dashboards. dashboard-sharing.spec.ts (4 tests, the recipient one included) and active-dashboard-resolution.spec.ts (2 of 3) were waiting for .launchpad-sidebar-toggle, which LpVandaag removed. All 7 now pass.
  • app-chrome.spec.ts › "a dashboard has an address" took its id from GET /api/dashboard. That endpoint returns the active dashboard, not a list, so the test skipped on every run. It now seeds two dashboards, makes the other one active, opens the address cold, and checks both the address and the active dashboard. The whole file passes 10 of 10.
  • New tests/e2e/public-start-page.spec.ts (3 tests): the plain address shows the chosen public dashboard with Sign in; Sign in leads to /login?direct=1 and signs in; a deep link to Files keeps the login form and lands in Files.

Archived

add-dashboard-sharing-e2e-coverage, launchpad-manifest-tier-3, analytics-personal-opt-out, record-parity-requirements and sharing-public-start-page each had live or e2e tasks left; every task line now says what was seen. launchpad-manifest-tier-3 had its spec written as a full spec, so it became an ADDED delta. REQ-ROUTE-005 got the scenario it lacked, checked live: there is one skip link and tabindex=-1 on the main region. There is a new main spec, manifest-routing. Before archiving the two fold-only changes, checks on the live instance confirmed that the personal opt-out route stores the caller's own setting and refuses anyone else, that the sharing allowed-groups limit refuses a member's share with 403, and that a new administrator gets the admin tour. In the parity matrix, g-optout, s-policy and d-tour are now built with evidence, and the other rows point at the main specs.

What ran locally

  • The 17 e2e tests above, against the rig: all pass.
  • Vitest on src/stores and src/views (43 files, 349 tests): green.
  • eslint on the changed files: clean.
  • Diff-scoped hydra gates: gate-19 passes for the sharing change. Gate-23 flags lib/Service/Embed/TenantThemeValidator.php, which this PR does not touch.
  • composer check:strict once: phpstan clean and PHPUnit green (4621 tests). phpcs, phpmd and psalm fail the same way as on development, and this PR changes no PHP.
  • npm run lint: the same 2 inherited errors in src/components/Announcements/__tests__/announcements.spec.js.

Seen, not changed

  • After signing in through the public start page, a staff member lands on the instance's default app. On a stock instance that is /apps/dashboard, so REQ-PSP-003's "lands on his Workspace page" holds only where LaunchPad is the default app.
  • About 15 more e2e files still use .launchpad-sidebar-toggle. They can move to the new helper.

Assisted-by: ClaudeCode:claude-opus-5-5

LpVandaag replaced the sidebar toggle with the More menu, whose All
dashboards item opens the switcher. dashboard-sharing (4 tests) and
active-dashboard-resolution (2 of 3) waited for the removed
.launchpad-sidebar-toggle and timed out. They now use
support/dashboardSwitcher.ts, and all 7 pass on a live NC 34 instance.

Assisted-by: ClaudeCode:claude-opus-5-5
…ve run

Assisted-by: ClaudeCode:claude-opus-5-5
…sharing.spec.ts

Assisted-by: ClaudeCode:claude-opus-5-5
REQ-SHARE-001 gains the browser sharing-flow scenario, keeping its @e2e line.

Assisted-by: ClaudeCode:claude-opus-5-5
/apps/launchpad/dashboards/<id> switched to the dashboard as the page
started, while the first loadDashboards() was still fetching the stored
active dashboard; when that answer came later it replaced the switch. On a
live NC 34 instance 5 of 6 cold loads landed on the stored dashboard
instead. The route now asks the store to open the dashboard, which waits
for the first load to finish and then switches.

Vitest: the store test is red with the old immediate switch.

Assisted-by: ClaudeCode:claude-opus-5-5
…ad of skipping

It read an id off GET /api/dashboard, which answers the active dashboard and
not a list, so it found none and skipped on every run. It now creates two
dashboards, makes the other one active, opens /dashboards/<id> cold and
checks the address and the active dashboard.

Assisted-by: ClaudeCode:claude-opus-5-5
The E2E leg ran on a throwaway NC 34 instance: every declared page renders on
a cold load from both URL forms and app-chrome.spec.ts passes 10 of 10, after
the dashboard-address fix in this branch. The change's spec was written as a
full spec; it is now an ADDED delta, REQ-ROUTE-005 gained the scenario it
lacked (checked live), and the new main spec manifest-routing carries the
change's Purpose.

Assisted-by: ClaudeCode:claude-opus-5-5
…-requirements

Both had only their fold-on-archive task left. Checked live on NC 34 first:
the personal opt-out route stores the caller's own setting and refuses
another user, the sharing allowed-groups limit refuses a member's share,
and a new administrator gets the admin tour. Requirements folded into six
main specs; g-optout, s-policy and d-tour are built with evidence lines and
the other rows point at the main specs.

Assisted-by: ClaudeCode:claude-opus-5-5
A signed-out visitor of the plain address lands on the chosen public
dashboard with a Sign in link, Sign in opens /login?direct=1 and signs in,
and a deep link to Files keeps the login form and lands in Files.

Assisted-by: ClaudeCode:claude-opus-5-5
Its Playwright task passed on NC 34; the delta is folded into
dashboard-public-share and d-public-start carries the e2e evidence.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 3e1ca79 into development Nov 17, 2026
5 of 6 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ 95a222e

Check PHP Vue Security License Tests
lint ❌
phpcs ❌
phpmd ❌
psalm ❌
phpstan ❌
phpmetrics ❌
eslint ❌
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ❌
composer ❌ ❌
npm ✅ ✅ 636/636
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 13:11 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant