Repository navigation
feat(launchpad): build widget-calculated-fields - #1254
Merged
Merged
Conversation
Tasks 21 and 22: widget placements store their calculated fields as a JSON list in a new nullable calculated_fields column (NULL reads as []), carry it on the wire and accept it on a placement update; the migration adds the column once. Goldens re-recorded for the new wire field. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 17, 2026 00:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues
widget-calculated-fieldsafter #1246 merged.Tasks done
WidgetPlacementgets a nullablecalculatedFieldsJSON column withgetCalculatedFieldsArray()/setCalculatedFieldsArray(). NULL, unparseable values and non-lists read as[]; entries that are not field objects are dropped. The list goes out on the wire ascalculatedFields, and a placement update with acalculatedFieldslist replaces the stored one (RequestDataExtractor,PlacementUpdater).Version002016Date20261117000000addscalculated_fields(TEXT, nullable) tolaunchpad_widget_placementsonce. Existing rows keep NULL, which reads as[], so no row is rewritten and a revert loses no data. The app version is raised so the migration runs.Tasks left, and why
validateAndCompile(a PHP AST type check), wiring validation into create/update, and the 400 envelope. This needs the stored fields from this PR first.computed-fields, cleanup on delete, and the downgrade logic.Tests
WidgetPlacementCalculatedFieldsTest(5 tests, round-trip, safe reads, update path) andCalculatedFieldsColumnMigrationTest(3 tests). Each was checked by breaking its subject line and watching it fail.RequestDataExtractorTestandWidgetPlacementSerializeGoldenTest. The mapper and add-widget golden fixtures were re-recorded; the only difference is"calculatedFields":[].Generated by Claude Code