Skip to content

feat(launchpad): build building-edit-a-dashboard-together - #1227

Open
rubenvdlinde wants to merge 4 commits into
developmentfrom
quality/build-building-edit-a-dashboard-together-c2
Open

rubenvdlinde wants to merge 4 commits into
developmentfrom
quality/build-building-edit-a-dashboard-together-c2

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Continues building-edit-a-dashboard-together after #1200 (tasks 1.2, 1.3, 1.5).

Tasks done

  • 1.1 Presence. POST/DELETE /api/dashboards/{uuid}/presence announce, renew and withdraw an editor; the answer lists the colleagues editing and since when (no user ids). Needs edit rights on the dashboard. Kept in the distributed cache; an editor without a heartbeat for 90 s drops off (the page renews every 30 s and withdraws on leave and page hide). New CoEditorsBanner in edit mode: "{name} is also editing this dashboard, since {time}. Your changes are not overwritten." plus "Who else is editing?" with initials.
  • 1.4 Edit mode without the lock. Entering edit mode announces the presence instead of acquiring the lock, also while colleagues edit. A refusal (403/404) keeps the page read-only with the existing banner; a refused renewal drops back to view mode. The admin take-over dialog is gone from the page; the lock endpoints, including admin force-release, stay for old locks.
  • Actions dashboard-presence.join / .leave in the seed, openapi entries, two new strings in all 37 catalogues (parity gate OK).

Tasks left

  • 2.1 e2e tests / @e2e exclude per scenario: left for a browser lane.

Tests

  • PHP: DashboardPresenceServiceTest (6), DashboardPresenceApiControllerTest (4). Unit suite 4196 before, 4206 after; the one failure (OpenApiStabilityTest::testEveryOperationIsPublicOrInternal) is on development too.
  • Vitest: useDashboardPresence.spec.js (5), CoEditorsBanner.spec.js (4), ViewsCoEditing.spec.js (5, replaces ViewsEditLock.spec.js); the edit-gate, tree and template-wiring specs follow the presence. 2265 passed, 0 failed. eslint: same 5 warnings as development, no errors.

Generated by Claude Code

Presence for edit mode (task 1.1, server side): POST and DELETE
/api/dashboards/{uuid}/presence announce, renew and withdraw an editor.
The answer names the colleagues editing the dashboard and since when,
without their user ids. Announcing needs edit rights on the dashboard;
the list lives in the distributed cache and an editor without a
heartbeat for 90 seconds drops off.

Assisted-by: ClaudeCode:claude-opus-5-5
Edit mode without the lock (tasks 1.1 and 1.4): entering edit mode
announces the editor through the presence endpoint instead of taking
the lock, also while colleagues edit the same dashboard. The new
CoEditorsBanner names the colleague editing longest and since when and
lists everyone by initials under 'Who else is editing?'. A refusal
(no edit rights, unknown dashboard) keeps the page read-only with the
existing banner; a refused renewal drops the page back to view mode.
The admin take-over dialog goes; the lock endpoints, including the
admin force-release, stay for old locks. Two new strings in every
locale.

Assisted-by: ClaudeCode:claude-opus-5-5
…er-c2 [skip ci]

Keeps both sides: development's filter strings and the co-editing strings
in every locale (keys both sides added once kept once), both imports in
Views.vue (the branch's replacement of the edit lock by presence stands),
and the prop-definitions golden regenerated over the merged components.

Assisted-by: ClaudeCode:claude-opus-5-5
…er-c2 [skip ci]

Assisted-by: ClaudeCode:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant