Repository navigation
feat(launchpad): build building-edit-a-dashboard-together - #1227
Open
rubenvdlinde wants to merge 4 commits into
Open
rubenvdlinde wants to merge 4 commits into
rubenvdlinde wants to merge 4 commits into
Conversation
Presence for edit mode (task 1.1, server side): POST and DELETE
/api/dashboards/{uuid}/presence announce, renew and withdraw an editor.
The answer names the colleagues editing the dashboard and since when,
without their user ids. Announcing needs edit rights on the dashboard;
the list lives in the distributed cache and an editor without a
heartbeat for 90 seconds drops off.
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 14, 2026 21:10
Edit mode without the lock (tasks 1.1 and 1.4): entering edit mode announces the editor through the presence endpoint instead of taking the lock, also while colleagues edit the same dashboard. The new CoEditorsBanner names the colleague editing longest and since when and lists everyone by initials under 'Who else is editing?'. A refusal (no edit rights, unknown dashboard) keeps the page read-only with the existing banner; a refused renewal drops the page back to view mode. The admin take-over dialog goes; the lock endpoints, including the admin force-release, stay for old locks. Two new strings in every locale. Assisted-by: ClaudeCode:claude-opus-5-5
…er-c2 [skip ci] Keeps both sides: development's filter strings and the co-editing strings in every locale (keys both sides added once kept once), both imports in Views.vue (the branch's replacement of the edit lock by presence stands), and the prop-definitions golden regenerated over the merged components. Assisted-by: ClaudeCode:claude-opus-5-5
…er-c2 [skip ci] Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues
building-edit-a-dashboard-togetherafter #1200 (tasks 1.2, 1.3, 1.5).Tasks done
POST/DELETE /api/dashboards/{uuid}/presenceannounce, renew and withdraw an editor; the answer lists the colleagues editing and since when (no user ids). Needs edit rights on the dashboard. Kept in the distributed cache; an editor without a heartbeat for 90 s drops off (the page renews every 30 s and withdraws on leave and page hide). NewCoEditorsBannerin edit mode: "{name} is also editing this dashboard, since {time}. Your changes are not overwritten." plus "Who else is editing?" with initials.dashboard-presence.join/.leavein the seed, openapi entries, two new strings in all 37 catalogues (parity gate OK).Tasks left
@e2e excludeper scenario: left for a browser lane.Tests
DashboardPresenceServiceTest(6),DashboardPresenceApiControllerTest(4). Unit suite 4196 before, 4206 after; the one failure (OpenApiStabilityTest::testEveryOperationIsPublicOrInternal) is on development too.useDashboardPresence.spec.js(5),CoEditorsBanner.spec.js(4),ViewsCoEditing.spec.js(5, replacesViewsEditLock.spec.js); the edit-gate, tree and template-wiring specs follow the presence. 2265 passed, 0 failed. eslint: same 5 warnings as development, no errors.Generated by Claude Code