Repository navigation
feat(launchpad): build governance-rest-api-reference - #1202
Merged
rubenvdlinde merged 1 commit intoNov 14, 2026
Merged
Conversation
Mark every operation of openapi.json x-launchpad-stability public or internal (design D2): dashboard CRUD and listing, placements and tiles, sharing, public links, export and import are public, the rest internal. A test pins the public set, so moving an operation in or out of it is a deliberate edit. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 14, 2026 08:26
rubenvdlinde
added a commit
that referenced
this pull request
Nov 14, 2026
GET and PUT /admin/public-start are admin settings, not part of the public API, so they carry x-launchpad-stability: internal as the operation stability check (arriving with #1202) requires of every operation. Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds part of
openspec/changes/governance-rest-api-reference: the stability levels of design D2. No task is ticked, because each touched task has a part that is not done (see below).What this does
openapi.jsonnow carriesx-launchpad-stability.public, as D2 lists them:/dashboard,/dashboard/{id},/dashboards,/dashboards/visible);/dashboard/{dashboardId}/widgets,/widgets/{placementId},/dashboard/{dashboardId}/tile,/tiles,/tiles/{id});/dashboard/{id}/shares,/dashboard/share/{shareId});/dashboards/{uuid}/public-share(s));/admin/export,/admin/import).internal.OpenApiStabilityTestfails when an operation has no stability, or when the public set changes without editing the pinned list in the test.Tasks left, and why
nextcloud/openapi-extractor/ 3 generate the file as OpenAPI 3.1. Since this change was written,openapi.json(3.0.3) landed on development infeat(api): serve every API path under /api/v1…. It is drawn fromroutes.phpand the controllers, andOpenApiDocumentTestkeeps it in step with the routes both ways. Whether to replace it with a generator is the D1 decision. That needs a person, so it is not made here, and the stability markers were added to the existing file.composer lint:openapiincheck:strict: the route-coverage half already exists asOpenApiDocumentTest. The regenerate-and-compare half depends on 1.Tests
OpenApiStabilityTest(1 test, 183 assertions).Generated by Claude Code