Repository navigation
refactor(security): clear widget containers without innerHTML, rename secret-named constants - #1109
Open
rubenvdlinde wants to merge 2 commits into
Open
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
… secret-named constants
- widgetBridge.js clears a container with replaceChildren() instead of
assigning innerHTML = '' (same effect, no HTML sink).
- PublicShareService::ACTION_SHARE_PASSWORD becomes
BRUTE_FORCE_ACTION_SHARE_UNLOCK and StoreService::CONFIG_TOKEN becomes
CONFIG_REGISTRY_AUTH. The values ('launchpad_share_password',
'registry_token') are unchanged, so the brute-force bucket and the stored
config key stay the same; the old names remain as deprecated aliases.
These four lines matched the secure-coding scanner's innerHTML and
hardcoded-secret patterns; none held a secret.
Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 12, 2026 19:39
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ❌ | ✅ 107/107 | |||
| npm | ✅ | ✅ 636/636 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 3255/3256 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-14 16:26 UTC
Download the full PDF report from the workflow artifacts.
Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The secure-coding scanner reports 4 findings on launchpad. These are the four lines that match its patterns. None of them holds a secret or injects HTML.
src/services/widgetBridge.js(2×):container.innerHTML = ''→container.replaceChildren(). Both clear the container before a legacy widget mounts; the result is identical.PublicShareService::ACTION_SHARE_PASSWORD→BRUTE_FORCE_ACTION_SHARE_UNLOCK. The valuelaunchpad_share_passwordis unchanged, so the brute-force bucket is the same.StoreService::CONFIG_TOKEN→CONFIG_REGISTRY_AUTH. The valueregistry_tokenis unchanged, so existing stored config still resolves.The old constant names stay as
@deprecatedaliases pointing at the new ones. All in-repo callers use the new names.Checks
src/services: 15 files, 80 tests green; eslint clean onwidgetBridge.js.Generated by Claude Code