Repository navigation
fix(deps): update vulnerable transitive npm packages within range - #1106
Open
rubenvdlinde wants to merge 2 commits into
Open
rubenvdlinde wants to merge 2 commits into
rubenvdlinde wants to merge 2 commits into
Conversation
npm audit: 54 -> 42 findings; critical 2 -> 0, high 7 -> 2, moderate 38 -> 34, low 7 -> 6. Lockfile-only: proxy-addr, shell-quote, body-parser, compression, undici, launch-editor, qs, ip-address, pbkdf2, fast-xml-parser, webpack-dev-middleware and postcss-selector-parser move to patched releases inside their existing ranges. package.json is unchanged. sbom.cdx.json regenerated. Left for a follow-up: dompurify 2.5.9 pinned by @toast-ui/editor, and vite/vitest/typescript-eslint, which npm's resolver cannot update in place here; the rest need semver-major bumps. Assisted-by: ClaudeCode:claude-opus-5-5
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
November 12, 2026 19:35
Contributor
Quality Report — ConductionNL/launchpad @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ❌ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ❌ | ✅ 107/107 | |||
| npm | ✅ | ✅ 635/635 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ❌ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 3102/3103 | ||||
| Newman | ✅ 224/224 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-14 16:21 UTC
Download the full PDF report from the workflow artifacts.
Assisted-by: ClaudeCode:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Lockfile-only update of the vulnerable npm packages that have a patched release inside the range already declared.
package.jsonis unchanged.npm audit: 54 → 42 (critical 2 → 0, high 7 → 2, moderate 38 → 34, low 7 → 6).Updated: proxy-addr, shell-quote, body-parser, compression, undici, launch-editor, qs, ip-address, pbkdf2, fast-xml-parser, webpack-dev-middleware, postcss-selector-parser.
sbom.cdx.jsonregenerated withregen-sbom.sh(components plus the composer tool version).Left for a follow-up
dompurify2.5.9, pinned by@toast-ui/editorthrough@conduction/nextcloud-vue; no fix without an override.vite6.4.3,vitest/@vitest/*4.1.11,typescript-eslint8.72.2. Patched releases are in range, butnpm update/npm audit fixfail in npm's resolver here (Cannot read properties of null (reading 'edgesOut'), and$piniaoverride resolution). All dev-only.@nextcloud/vue,@nextcloud/dialogs,eslint,@cyclonedx/cyclonedx-npm, …).composer auditflags only dev packages (symfony/config, filesystem, yaml through dev tools);--no-devhas nothing to audit.Checks
vitest run: 154 files, 1186 tests passed.webpack --mode productioncompiled through module sealing. It then ran out of memory in Terser in this container, not because of a resolution error.Generated by Claude Code