Skip to content

fix(deps): update vulnerable transitive npm packages within range - #1106

Open
rubenvdlinde wants to merge 2 commits into
developmentfrom
quality/gap-13-audit
Open

rubenvdlinde wants to merge 2 commits into
developmentfrom
quality/gap-13-audit

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What

Lockfile-only update of the vulnerable npm packages that have a patched release inside the range already declared. package.json is unchanged.

npm audit: 54 → 42 (critical 2 → 0, high 7 → 2, moderate 38 → 34, low 7 → 6).

Updated: proxy-addr, shell-quote, body-parser, compression, undici, launch-editor, qs, ip-address, pbkdf2, fast-xml-parser, webpack-dev-middleware, postcss-selector-parser. sbom.cdx.json regenerated with regen-sbom.sh (components plus the composer tool version).

Left for a follow-up

  • dompurify 2.5.9, pinned by @toast-ui/editor through @conduction/nextcloud-vue; no fix without an override.
  • vite 6.4.3, vitest/@vitest/* 4.1.11, typescript-eslint 8.72.2. Patched releases are in range, but npm update/npm audit fix fail in npm's resolver here (Cannot read properties of null (reading 'edgesOut'), and $pinia override resolution). All dev-only.
  • The remaining moderates need semver-major bumps (@nextcloud/vue, @nextcloud/dialogs, eslint, @cyclonedx/cyclonedx-npm, …).
  • composer audit flags only dev packages (symfony/config, filesystem, yaml through dev tools); --no-dev has nothing to audit.

Checks

  • vitest run: 154 files, 1186 tests passed.
  • webpack --mode production compiled through module sealing. It then ran out of memory in Terser in this container, not because of a resolution error.

Generated by Claude Code

npm audit: 54 -> 42 findings; critical 2 -> 0, high 7 -> 2, moderate
38 -> 34, low 7 -> 6. Lockfile-only: proxy-addr, shell-quote,
body-parser, compression, undici, launch-editor, qs, ip-address, pbkdf2,
fast-xml-parser, webpack-dev-middleware and postcss-selector-parser move to
patched releases inside their existing ranges. package.json is unchanged.
sbom.cdx.json regenerated.

Left for a follow-up: dompurify 2.5.9 pinned by @toast-ui/editor, and
vite/vitest/typescript-eslint, which npm's resolver cannot update in place
here; the rest need semver-major bumps.

Assisted-by: ClaudeCode:claude-opus-5-5
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/launchpad @ ff05be1

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ❌
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
format ❌
check-schema-l10n ✅
composer ❌ ✅ 107/107
npm ✅ ✅ 635/635
app:check-code ⏭️
info.xml ✅
REUSE ❌
lockfile sync ✅
PHPUnit ❌ 3102/3103
Newman ✅ 224/224
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-14 16:21 UTC

Download the full PDF report from the workflow artifacts.

Assisted-by: ClaudeCode:claude-opus-5-5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant