Repository navigation
feat(larpinq): build capability-rows-missing-requirements - #1105
Open
rubenvdlinde wants to merge 7 commits into
Open
rubenvdlinde wants to merge 7 commits into
rubenvdlinde wants to merge 7 commits into
Conversation
World page timeline (2.2): a timeline widget that lists the world's history entries and its events together by date, oldest first. The history schema's read rule already keeps game-master entries from players. Timeline and History strings in every locale. Assisted-by: ClaudeCode:claude-opus-5-5
Buy item on the character page (3.2): a header action opens a dialog that shows the character's money, offers the priced items of its world that it does not carry yet, and buys one through the purchase endpoint, which adds the item and takes the money in one write. The server's refusals are shown in the user's language. Strings in every locale; 29 vitest tests. Assisted-by: ClaudeCode:claude-opus-5-5
Run sheet download on the event page (4.1): a Download run sheet header action, shown when a new run-sheet access answer allows it (game masters and admins, the same rule as the download), opens a template picker and then the run sheet. The access endpoint is documented in openapi.json. Strings in every locale; PHPUnit for the access answer and vitest for the dialog and the wiring. Assisted-by: ClaudeCode:claude-opus-5-5
Requirement override on the character page (5.1): an Override a requirement header action, shown on a new override access answer (game masters and admins), opens a dialog that grants a skill of the world with a required reason. The skill and its requirementOverrides[] entry go in one write, so the requirement listener and the audit trail apply; a player gets no action and the listener still refuses their override. Strings in every locale; PHPUnit for the access answer, vitest for the write, the dialog and the wiring. Assisted-by: ClaudeCode:claude-opus-5-5
Rejecting a character (6.1): the approval lifecycle gets a rejected state, a reject transition for game masters with a required rejection reason, and a resubmit transition back to waiting; the owner is notified of the rejection with its reason and the game masters of the resubmission. The reason is read by game masters and the owner only, and shows on the character page and in the Characters list. A Reject action for game masters posts the transition; a Submit again action on a rejected character calls a new resubmit endpoint for the owner, who may not write the approval field directly. The game master access answer is shared by the Override and Reject actions. Strings in every locale; PHPUnit for the resubmission, the endpoint and the merged lifecycle and notifications, vitest for the dialog and the wiring. Assisted-by: ClaudeCode:claude-opus-5-5
…ents [skip ci] Routes keep both sides; the locale catalogues take the union of both sides' keys and the .js files are regenerated with npm run l10n:build; the effective manifest golden is re-recorded over the merged manifest. Assisted-by: ClaudeCode:claude-opus-5-5
Writers read the rejection reason too: development's staff roles let a writer read every character field, and the rejection reason is the one field this build added after them; game masters still write it alone and other players still do not read it. Round 2: Playwright spec coverage for the world description and timeline (including the hidden entry), the player page's account and characters, and the game master override and its absence for a player; the run-sheet spec now downloads the run sheet from the event page. Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues
openspec/changes/capability-rows-missing-requirementsafter #1039, which landed task 3.1. The branch already carried tasks 2.2, 3.2, 4.1, 5.1 and 6.1 in five commits pushed after #1039 merged, and they never reached a PR. This PR proposes them, merged with current development, plus the round-2 Playwright coverage.Tasks done
GET /api/events/runsheet-accessanswer). It opens the template picker, then the PDF.GET /api/characters/game-master-access). It grants a skill of the world with a required reason in one write, so the requirement listener and the audit trail apply.rejectedapproval state with a requiredrejectionReason, a Reject action for game masters, Submit again for the owner (POST /api/characters/{id}/resubmit), and notifications to the owner and the game masters.appinfo/routes.phpkeeps both sides. The locale catalogues take the union of both sides' keys, and the.jsfiles are regenerated withnpm run l10n:build. The effective-manifest golden is re-recorded over the merged manifest.rejectionReasonis the one field added after them. Writers now read it too. Game masters still write it alone, and other players still cannot read it.CharacterRejectionFragmentTestis updated to match.tests/e2e/spec-coverage/capability-rows-missing-requirements.spec.ts, 7 tests: the world description as a player; the timeline order; a game-master entry visible to a game master and hidden from a player; the player's account and characters; the override of "Dragon Speech" with its reason in the history; and no override action for a player.larpersuser.event-runsheet-export.spec.tsnow downloads the run sheet from the event page. It skips, and says why, when the instance offers no PDF template.Tasks left, and why
leaf-integrationsandregistration-tickets.Tests and suite
check:manifest(Ajv PASS),check:registerandtest:l10n(every locale at parity) pass.appinfo/routes.php: development's own lowercase comment, not part of this PR's diff.playwright test --listlists them.Generated by Claude Code