Skip to content

feat(larpinq): build character-player-picker - #1100

Open
rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-character-player-picker-2
Open

rubenvdlinde wants to merge 1 commit into
developmentfrom
quality/build-character-player-picker-2

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Round 2 of openspec/changes/character-player-picker: every code task (the register declarations and the seed) is already on development; this adds the browser spec the change's test plan asks for and that did not exist yet.

Tasks done

  • tests/e2e/workflows/character-player-picker.workflow.spec.ts, 6 tests for test-plan TC-1 to TC-7:
    • TC-1/TC-2: the Add Character dialog has no Owner UID field; the player is picked from the #cn-form-ocName dropdown and the saved ocName is the player's uuid.
    • TC-3: ownerUid materialises to the linked player's userUid.
    • TC-4: player.userUid stores a Nextcloud user.
    • TC-7: Approved renders as a toggle in the edit dialog and flipping it stores approved.
    • TC-5: approving a character linked to a player gives that player's Nextcloud user a notification (read through the notifications API in the user's own context, empty storage state).
    • TC-6: a character whose player does not resolve approves without error.
  • TC-8 stays with tests/unit/Settings/CharacterPlayerPickerSeedTest.php.

Tasks left and why

  • The Test lines of Tasks 1 to 5 stay unticked: the spec needs a live instance and has not been run here. The docs screenshots (ADR-010) also need the live instance.

Tests added

  • One Playwright workflow spec, 6 tests (playwright test --list parses it; eslint clean).

Suite

  • No production code changed; PHPUnit and vitest are unaffected.

Generated by Claude Code

Add the Playwright workflow spec for test-plan TC-1 to TC-7.

Assisted-by: ClaudeCode:claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant