Skip to content

feat(larpinq): build registration-payments-through-shillinq - #1055

Open
rubenvdlinde wants to merge 4 commits into
developmentfrom
quality/build-registration-payments-through-shillinq
Open

rubenvdlinde wants to merge 4 commits into
developmentfrom
quality/build-registration-payments-through-shillinq

Conversation

@rubenvdlinde

@rubenvdlinde rubenvdlinde commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Builds registration-payments-through-shillinq (every code task is now ticked).

Tasks done

  • 6.1 Invoice on request: shillinq issues the invoice a player asked for while it creates the payment request and names it in invoiceReference. RegistrationInvoice turns that into registration.invoiceId and an absolute invoiceUrl to shillinq's invoice download; it lands with the request in RegistrationPaymentService::raise() and, when shillinq reports it later, once through PaymentFollowUp::requestChanged(). The registration page gets a "Download invoice" header link when invoiceId is set; My registrations gets an Invoice link column, worded by a small invoiceDownload formatter. Five new strings in all 37 locales.
  • 6.2 Bank statement match: registration.paymentMethod (game masters may update) in the register fragment; PaymentFollowUp::markPaid() records bank-transfer when the settled request reports it; a "Upload and match a bank statement" header action on the Registrations index, shown when the payments access endpoint allows, opening the shillinq bank statement import. Four new strings in all 37 locales.

Tasks left

  • 4.2 Playwright workflow: needs an isolated instance with shillinq enabled.
  • The invoice PDF layout itself is shillinq's own sales-invoice-document change, still open there; larpinq only links to shillinq's download.

Tests added

  • tests/unit/Service/RegistrationInvoiceTest.php (7 tests: the fields, once only, at acceptance, later report, with a capture, unknown request)
  • tests/unit/Listener/PaymentRequestListenerTest.php (an issued invoice lands once)
  • tests/unit/Service/PaymentBankTransferTest.php (3 tests)
  • tests/unit/Settings/RegistrationPaymentsFragmentTest.php (paymentMethod, invoiceId, invoiceUrl; written fields validate)
  • tests/vitest/invoiceDownload.spec.js (4 tests), tests/vitest/bankStatementAction.spec.js (4 tests)
  • Golden fixtures: the effective-manifest hashes of MyRegistrations and RegistrationDetail, and the App.vue template hash (the formatters binding).

Suites (this branch merged with development, openregister main beside it)

  • PHPUnit unit: 1123 → 1131 tests; the same 13 errors and 5 failures with and without this change (PlayerAttendanceControllerTest, OwnXpAwardsReadTest, RuleSchemaAuthorizationTest, OpenRegisterStubDriftTest), so inherited
  • Vitest: 705 tests, all pass
  • npm run test:l10n, check:l10n-js, check:manifest, check:register pass; schema l10n at development's count; phpcs and phpstan clean on the touched lib files

Generated by Claude Code

Task 6.2: record a bank-transfer payment method when shillinq settles a
payment request from a bank statement line, and add the game-master action
on the Registrations index that opens the shillinq bank statement import.

Assisted-by: ClaudeCode:claude-opus-5-5
…illinq [skip ci]

l10n .json merged by key in every locale and the .js regenerated; registry.js imports both sides; the fragment test keeps paymentMethod and development's treasurer note.

Assisted-by: ClaudeCode:claude-opus-5-5
Task 6.1: the invoice shillinq issues on request lands on the registration
once (invoiceId, invoiceUrl), with a Download invoice link on the
registration page and an Invoice column on My registrations.

Assisted-by: ClaudeCode:claude-opus-5-5

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant