Repository navigation
feat(larpinq): build registration-payments-through-shillinq - #1055
Open
rubenvdlinde wants to merge 4 commits into
Open
rubenvdlinde wants to merge 4 commits into
rubenvdlinde wants to merge 4 commits into
Conversation
Task 6.2: record a bank-transfer payment method when shillinq settles a payment request from a bank statement line, and add the game-master action on the Registrations index that opens the shillinq bank statement import. Assisted-by: ClaudeCode:claude-opus-5-5
…illinq [skip ci] l10n .json merged by key in every locale and the .js regenerated; registry.js imports both sides; the fragment test keeps paymentMethod and development's treasurer note. Assisted-by: ClaudeCode:claude-opus-5-5
Task 6.1: the invoice shillinq issues on request lands on the registration once (invoiceId, invoiceUrl), with a Download invoice link on the registration page and an Invoice column on My registrations. Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds
registration-payments-through-shillinq(every code task is now ticked).Tasks done
invoiceReference.RegistrationInvoiceturns that intoregistration.invoiceIdand an absoluteinvoiceUrlto shillinq's invoice download; it lands with the request inRegistrationPaymentService::raise()and, when shillinq reports it later, once throughPaymentFollowUp::requestChanged(). The registration page gets a "Download invoice" header link wheninvoiceIdis set; My registrations gets an Invoice link column, worded by a smallinvoiceDownloadformatter. Five new strings in all 37 locales.registration.paymentMethod(game masters may update) in the register fragment;PaymentFollowUp::markPaid()recordsbank-transferwhen the settled request reports it; a "Upload and match a bank statement" header action on the Registrations index, shown when the payments access endpoint allows, opening the shillinq bank statement import. Four new strings in all 37 locales.Tasks left
sales-invoice-documentchange, still open there; larpinq only links to shillinq's download.Tests added
tests/unit/Service/RegistrationInvoiceTest.php(7 tests: the fields, once only, at acceptance, later report, with a capture, unknown request)tests/unit/Listener/PaymentRequestListenerTest.php(an issued invoice lands once)tests/unit/Service/PaymentBankTransferTest.php(3 tests)tests/unit/Settings/RegistrationPaymentsFragmentTest.php(paymentMethod, invoiceId, invoiceUrl; written fields validate)tests/vitest/invoiceDownload.spec.js(4 tests),tests/vitest/bankStatementAction.spec.js(4 tests)formattersbinding).Suites (this branch merged with development, openregister main beside it)
npm run test:l10n,check:l10n-js,check:manifest,check:registerpass; schema l10n at development's count; phpcs and phpstan clean on the touched lib filesGenerated by Claude Code