Skip to content

test(generator): count passphrase words without splitting on hyphens - #949

Merged
rubenvdlinde merged 2 commits into
developmentfrom
fix/generator-test-hyphenated-words
Oct 2, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
fix/generator-test-hyphenated-words

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

What changes

Two passphrase tests from #941 split a passphrase on - to count its words. Four words in the EFF large word list carry a hyphen themselves (drop-down, felt-tip, t-shirt, yo-yo), so those tests failed now and then. Found when the extension branch's full vitest run hit it.

The default test now checks the default separator and word count with a fixed random source. The content checks use a space as separator. Test-only change; the generator is unchanged.

How it was verified

  • tests/vitest/generator.spec.js five runs in a row green.
  • Full vitest suite: 183 files, 1252 tests green. npm run lint green.
  • composer check:strict not rerun: the PR touches one JS test file and no PHP.

🤖 Generated with Claude Code

Four EFF words carry a hyphen (drop-down, felt-tip, t-shirt, yo-yo), so
splitting a random default passphrase on '-' failed now and then. The
default is checked with a fixed random source; the content checks use a
space as separator.
@rubenvdlinde
rubenvdlinde merged commit 4b061ef into development Oct 2, 2026
@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 97284e0

Check PHP Vue Security License Tests
lint ⏭️
phpcs ⏭️
phpmd ⏭️
psalm ⏭️
phpstan ⏭️
phpmetrics ⏭️
eslint ⏭️
stylelint ⏭️
build ⏭️
composer ⏭️ ⏭️
npm ⏭️ ⏭️
app:check-code ⏭️
info.xml ⏭️
REUSE ⏭️
lockfile sync ⏭️
PHPUnit ❌
Newman ❌
Playwright ❌
Hydra gates ❌

Quality workflow — 2026-10-02 15:09 UTC

Download the full PDF report from the workflow artifacts.

@github-actions

github-actions Bot commented Oct 2, 2026

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 83ff8c3

Check PHP Vue Security License Tests
lint ✅
phpcs ✅
phpmd ✅
psalm ✅
phpstan ✅
phpmetrics ✅
eslint ✅
stylelint ✅
build ✅
check-manifest ✅
test-l10n ✅
format ✅
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 660/660
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ✅
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ✅

Quality workflow — 2026-10-02 15:17 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde
rubenvdlinde deleted the fix/generator-test-hyphenated-words branch October 2, 2026 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant