Repository navigation
feat(keepiq): build connection-certificate-expiry-for-integriq - #1899
Open
rubenvdlinde wants to merge 1 commit into
Open
rubenvdlinde wants to merge 1 commit into
rubenvdlinde wants to merge 1 commit into
Conversation
A broker mint may carry the certificate's notAfter, stored as expires_at without touching the ciphertext, and the organisation and consumer it was minted for, kept in the new keepiq_broker_mints table. The new CredentialExpiryRequestedEvent is answered with notAfter and a link to the secret only for an application-owned credential minted for integriq and for the organisation integriq acts for; every other request gets no answer. Assisted-by: ClaudeCode:claude-opus-5-5
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds keepiq's share of
connection-certificate-expiry-for-integriq.Tasks done
SecretService::createByApplication/updateByApplication) may carrynotAfter(ISO 8601). It is stored as the secret'sexpires_atin UTC without touching the ciphertext, so the existing expiry scan reminds its owners. A sentnullclears it, an unparsable value is refused, and a write without it leaves the expiry alone. NewBrokerMintRecorder, an optional last constructor argument, so existing callers are unchanged.CredentialExpiryRequestedEvent(credentialId, actingOrganisationId; collectsnotAfterandrenewUrl) andCredentialExpiryRequestedListener, registered inApplication. It answers only when the secret is application-owned, the broker minted it for the consumerintegriqand for the acting organisation, it is not trashed or tombstoned, and it has an expiry. Every other request, including personal entries, another organisation's credential, another consumer, an unknown secret or one without an expiry, stays unanswered. The answer has exactly the two fields and is stored nowhere.keepiq_broker_mints(migrationVersion001022Date20261117160000, also in the consolidated schema and the backup registry). It holds no name and no material. The app version is bumped so the migration runs.Tasks left
composer check:strict,npm run lint,npm run test:l10n): not run as a whole. phpcs and phpstan pass on every touchedlib/file, and no frontend or l10n file changed.DoriathCredentialStore::put) must sendnotAfter,organisationandconsumerwith the mint, and integriq must dispatch the event. Until then nothing is recorded and integriq shows "expiry unknown", as the design intends.Tests added
tests/Unit/Service/BrokerMintRecorderTest.php(6): UTC expiry with the ciphertext unchanged, absent and nullnotAfter, refusal of a non-date, the mint record replaced, nothing recorded when neither field is sent, and the create path throughSecretService.tests/Unit/Listener/CredentialExpiryRequestedListenerTest.php(6): integriq's own certificate is answered with2026-11-30T00:00:00+00:00and the secret's link; personal, foreign-organisation and other-consumer credentials get no answer; unknown, trashed, no-expiry and empty-organisation requests get no answer; other events are ignored.Suite: after, 5631 tests with 0 failures (241 skipped); the baseline on development was not run separately, and the only failure seen on the branch was the registry test below, now fixed.
ArchiveTest::testRegistryMatchesTheConsolidatedSchemafailed until the table was added to the backup registry.Generated by Claude Code