Skip to content

chore(keepiq): recovery kit e2e and archive crypto-recovery-kit - #1891

Merged
rubenvdlinde merged 2 commits into
developmentfrom
quality/livepass-keepiq-2
Nov 17, 2026
Merged

rubenvdlinde merged 2 commits into
developmentfrom
quality/livepass-keepiq-2

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Live pass for keepiq, second batch: the recovery kit's Playwright checks, then the archive of crypto-recovery-kit.

  • tests/e2e/workflows/recovery-kit.spec.ts runs on a fresh account. It makes a kit in Settings > Security and downloads it, and no request carries the code. After a reload it recovers with the code and a new master password. The spent kit is then no longer offered, and the new master password unlocks.
  • crypto-recovery-kit is archived. Row crypto-12 is set to built with the kit's files as evidence. The vault-recovery-kit spec has a Purpose. The 2.2 and 2.3 notes now name the Playwright run.

Verified locally

  • Throwaway Nextcloud 34 + Postgres running this branch: the new spec passes 2 of 2.
  • Diff check: hydra-gates --scope-to-diff --base origin/development: all 66 applicable gates passed. vitest on the recovery kit specs passed (20 tests). phpcs reports 0 findings on touched lines, and php -l is clean. The PHP changes are @spec comment paths only.
  • composer check:strict, run once: PHPUnit OK. phpcs, phpmd and psalm findings are on untouched lines (inherited), the same as on development.
  • npm run lint, run once: the same 4 inherited errors in src/store/modules/encryptionSuite.js.

This PR was prepared with AI assistance (Claude Code).

A fresh account makes a kit in its settings and downloads it with no
request carrying the code, then after a reload recovers with the code and a
new master password; the spent kit is no longer offered and the new master
password unlocks.

Assisted-by: ClaudeCode:claude-opus-5-5
Its Playwright checks now pass on a throwaway instance, so row crypto-12 is
set to built with the kit's files as evidence and the change is archived,
with a Purpose for the vault-recovery-kit spec.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit 2b71b65 into development Nov 17, 2026
10 of 11 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 3233a51

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ❌
build ✅
check-manifest ✅
test-l10n ❌
format ❌
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 13:07 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant