Repository navigation
chore(keepiq): recovery kit e2e and archive crypto-recovery-kit - #1891
Merged
Merged
Conversation
A fresh account makes a kit in its settings and downloads it with no request carrying the code, then after a reload recovers with the code and a new master password; the spent kit is no longer offered and the new master password unlocks. Assisted-by: ClaudeCode:claude-opus-5-5
Its Playwright checks now pass on a throwaway instance, so row crypto-12 is set to built with the kit's files as evidence and the change is archived, with a Purpose for the vault-recovery-kit spec. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ❌ | ||||
| format | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 652/652 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-17 13:07 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live pass for keepiq, second batch: the recovery kit's Playwright checks, then the archive of crypto-recovery-kit.
tests/e2e/workflows/recovery-kit.spec.tsruns on a fresh account. It makes a kit in Settings > Security and downloads it, and no request carries the code. After a reload it recovers with the code and a new master password. The spent kit is then no longer offered, and the new master password unlocks.vault-recovery-kitspec has a Purpose. The 2.2 and 2.3 notes now name the Playwright run.Verified locally
hydra-gates --scope-to-diff --base origin/development: all 66 applicable gates passed. vitest on the recovery kit specs passed (20 tests). phpcs reports 0 findings on touched lines, andphp -lis clean. The PHP changes are@speccomment paths only.composer check:strict, run once: PHPUnit OK. phpcs, phpmd and psalm findings are on untouched lines (inherited), the same as on development.npm run lint, run once: the same 4 inherited errors insrc/store/modules/encryptionSuite.js.This PR was prepared with AI assistance (Claude Code).