Skip to content

chore(keepiq): live pass, archive 10 changes and add their e2e flows - #1879

Merged
rubenvdlinde merged 6 commits into
developmentfrom
quality/livepass-keepiq-1
Nov 17, 2026
Merged

rubenvdlinde merged 6 commits into
developmentfrom
quality/livepass-keepiq-1

Conversation

@rubenvdlinde

Copy link
Copy Markdown
Contributor

Live pass for keepiq: archive what is finished, run the open live tasks against a throwaway instance, fix what they found.

Archived (10 changes)

  • Fully ticked already: capability-requirements-from-the-matrix, crypto-vault-encryption-details, health-site-security-checks, vault-website-addresses.
  • Process task done here: platform-properties (clients-16 and clients-23 point at the spec), vault-card-brand-formats (5.2: hydra-gates diff-scoped on the feature commit f884f5a, 48 of 48 applicable gates green, gate 16 PASS).
  • Live task passed here: crypto-item-reprompt, vault-duplicate-finder, vault-custom-field-kinds-and-ssh-key (rows vault-11 and vault-14 set to built), clients-vault-event-flow-triggers (row clients-15 set to built).
  • New capability specs got a written Purpose. @spec tags and parity rows that named the change folders now name the main specs or the archived task lists.

Also ticked: portability-cxp-cross-provider-transfer 2.1 (that change still has 1.1 and 3.2 open).

New e2e specs (tests/e2e/workflows/)

Each one runs on fresh accounts with their own vault:

  • item-reprompt.spec.ts: the list marks a flagged login, a wrong master password reveals and sends nothing, the right one copies, and the next copy asks again.
  • duplicate-finder.spec.ts: one exact group and one likely group, and no request body names a group.
  • custom-field-kinds.spec.ts: a hidden field shows dots until Show and Copy copies the real value. Generate key pair through the New secret dialog stores an SSH key, and the sidebar copies the public key.
  • cxp-file-transfer.spec.ts: request file out, sealed response back, an altered response refused, and the real one opens the import wizard with the item.
  • vault-event-flow-trigger.spec.ts: a published flow on keepiq.share.granted gets exactly one run per share, with no secret material in it. The spec skips when OpenRegister is not enabled.

Fix

  • vault-unlock.spec.ts "a locked vault issues no Keepiq API request" failed on every locked route. The cause is that the lock screen's RecoveryKitUnlock calls GET /api/v1/recovery-kit, which returns only the suite id and creation time. That route is now on the allowlist with its reason. The wrapped-copy route /copy is still off the list.

Verified locally

  • Throwaway Nextcloud 34 + Postgres with keepiq from this branch and OpenRegister main 28ff9cf60, seeded with tests/e2e/ci-seed.sh. Passing: all 5 new specs, vault-unlock.spec.ts with the fix, plus the rest of vault-unlock.
  • Diff check: hydra-gates --scope-to-diff --base origin/development: all 66 applicable gates passed. vitest on the touched test files passed (190 tests). php -l is clean on the touched PHP, which only had @spec comment path changes.
  • composer check:strict, run once. PHPUnit: 5619 tests OK (241 skipped). phpcs, phpmd and psalm have findings on lines this PR does not touch (inherited). phpcs reports 0 findings on touched lines.
  • npm run lint, run once: 4 errors in src/store/modules/encryptionSuite.js, which this PR does not touch (inherited).
  • openspec validate --specs --strict: 20 failing specs, the same count as on development. The 9 new specs pass.

Follow-ups (not in this PR)

  • These parity rows still say specified, although their changes are archived: vault-25, vault-28, vault-29, vault-31, crypto-13, crypto-20, sharing-26, health-11, health-12, health-15, rotation-08.
  • clients-vault-event-flow-triggers 2.2 named a Playwright check on the admin Flows section. That check was not run.

This PR was prepared with AI assistance (Claude Code).

Archive capability-requirements-from-the-matrix, crypto-vault-encryption-details,
health-site-security-checks and vault-website-addresses into the main specs,
write the Purpose of the three new capabilities, and point the @SPEC tags and
parity rows that named the change folders at the main specs and the archived
task lists.

Assisted-by: ClaudeCode:claude-opus-5-5
Point clients-16 and clients-23 at the platform-properties spec, drop the two
fixed colour defects the change removed, and repoint the remaining references
to the archived change folders.

Assisted-by: ClaudeCode:claude-opus-5-5
Gate 16 spec coverage passed on the feature commit (hydra-gates diff-scoped
against f884f5a~1, all 48 applicable gates green), which was the last open
task.

Assisted-by: ClaudeCode:claude-opus-5-5
…iles and flow triggers

Five Playwright specs behind the open live tasks, each on fresh accounts:
the master password re-prompt on a flagged login, the Duplicates section
of the health report, hidden custom fields and the generated SSH key item,
the CXP transfer through request and response files (an altered response
opens nothing), and a granted share starting one OpenRegister flow run with
no secret material (skipped without OpenRegister).

Assisted-by: ClaudeCode:claude-opus-5-5
RecoveryKitUnlock asks GET /api/v1/recovery-kit on the lock screen to offer
"I lost my master password". The answer is the kit's suite id and creation
time, no key material, so the locked-vault allowlist names it; the wrapped
copy route stays unlisted. The test failed on every locked route since the
recovery kit landed.

Assisted-by: ClaudeCode:claude-opus-5-5
crypto-item-reprompt, vault-duplicate-finder,
vault-custom-field-kinds-and-ssh-key and clients-vault-event-flow-triggers
had only their Playwright tasks open; those now pass on a throwaway
instance, so the changes are archived with Purposes for their new specs.
Rows vault-11, vault-14 and clients-15 are set to built with evidence, and
portability-cxp-cross-provider-transfer 2.1 is ticked.

Assisted-by: ClaudeCode:claude-opus-5-5
@rubenvdlinde
rubenvdlinde merged commit c6171c8 into development Nov 17, 2026
12 of 14 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/keepiq @ 442da3c

Check PHP Vue Security License Tests
lint ✅
phpcs ❌
phpmd ❌
psalm ❌
phpstan ✅
phpmetrics ✅
eslint ❌
stylelint ❌
build ✅
check-manifest ✅
test-l10n ❌
format ❌
check-l10n-js ✅
check-schema-l10n ✅
composer ✅ ✅ 114/114
npm ✅ ✅ 652/652
app:check-code ⏭️
info.xml ✅
REUSE ✅
lockfile sync ✅
PHPUnit ❌
Newman ❌
Playwright ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development.
Hydra gates ❌

Quality workflow — 2026-11-17 12:48 UTC

Download the full PDF report from the workflow artifacts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant