Repository navigation
chore(keepiq): live pass, archive 10 changes and add their e2e flows - #1879
Merged
Merged
Conversation
Archive capability-requirements-from-the-matrix, crypto-vault-encryption-details, health-site-security-checks and vault-website-addresses into the main specs, write the Purpose of the three new capabilities, and point the @SPEC tags and parity rows that named the change folders at the main specs and the archived task lists. Assisted-by: ClaudeCode:claude-opus-5-5
Point clients-16 and clients-23 at the platform-properties spec, drop the two fixed colour defects the change removed, and repoint the remaining references to the archived change folders. Assisted-by: ClaudeCode:claude-opus-5-5
Gate 16 spec coverage passed on the feature commit (hydra-gates diff-scoped against f884f5a~1, all 48 applicable gates green), which was the last open task. Assisted-by: ClaudeCode:claude-opus-5-5
…iles and flow triggers Five Playwright specs behind the open live tasks, each on fresh accounts: the master password re-prompt on a flagged login, the Duplicates section of the health report, hidden custom fields and the generated SSH key item, the CXP transfer through request and response files (an altered response opens nothing), and a granted share starting one OpenRegister flow run with no secret material (skipped without OpenRegister). Assisted-by: ClaudeCode:claude-opus-5-5
RecoveryKitUnlock asks GET /api/v1/recovery-kit on the lock screen to offer "I lost my master password". The answer is the kit's suite id and creation time, no key material, so the locked-vault allowlist names it; the wrapped copy route stays unlisted. The test failed on every locked route since the recovery kit landed. Assisted-by: ClaudeCode:claude-opus-5-5
crypto-item-reprompt, vault-duplicate-finder, vault-custom-field-kinds-and-ssh-key and clients-vault-event-flow-triggers had only their Playwright tasks open; those now pass on a throwaway instance, so the changes are archived with Purposes for their new specs. Rows vault-11, vault-14 and clients-15 are set to built with evidence, and portability-cxp-cross-provider-transfer 2.1 is ticked. Assisted-by: ClaudeCode:claude-opus-5-5
Contributor
Quality Report — ConductionNL/keepiq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| build | ✅ | ||||
| check-manifest | ✅ | ||||
| test-l10n | ❌ | ||||
| format | ❌ | ||||
| check-l10n-js | ✅ | ||||
| check-schema-l10n | ✅ | ||||
| composer | ✅ | ✅ 114/114 | |||
| npm | ✅ | ✅ 652/652 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-17 12:48 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live pass for keepiq: archive what is finished, run the open live tasks against a throwaway instance, fix what they found.
Archived (10 changes)
@spectags and parity rows that named the change folders now name the main specs or the archived task lists.Also ticked: portability-cxp-cross-provider-transfer 2.1 (that change still has 1.1 and 3.2 open).
New e2e specs (tests/e2e/workflows/)
Each one runs on fresh accounts with their own vault:
item-reprompt.spec.ts: the list marks a flagged login, a wrong master password reveals and sends nothing, the right one copies, and the next copy asks again.duplicate-finder.spec.ts: one exact group and one likely group, and no request body names a group.custom-field-kinds.spec.ts: a hidden field shows dots until Show and Copy copies the real value. Generate key pair through the New secret dialog stores an SSH key, and the sidebar copies the public key.cxp-file-transfer.spec.ts: request file out, sealed response back, an altered response refused, and the real one opens the import wizard with the item.vault-event-flow-trigger.spec.ts: a published flow onkeepiq.share.grantedgets exactly one run per share, with no secret material in it. The spec skips when OpenRegister is not enabled.Fix
vault-unlock.spec.ts"a locked vault issues no Keepiq API request" failed on every locked route. The cause is that the lock screen's RecoveryKitUnlock callsGET /api/v1/recovery-kit, which returns only the suite id and creation time. That route is now on the allowlist with its reason. The wrapped-copy route/copyis still off the list.Verified locally
tests/e2e/ci-seed.sh. Passing: all 5 new specs,vault-unlock.spec.tswith the fix, plus the rest of vault-unlock.hydra-gates --scope-to-diff --base origin/development: all 66 applicable gates passed. vitest on the touched test files passed (190 tests).php -lis clean on the touched PHP, which only had@speccomment path changes.composer check:strict, run once. PHPUnit: 5619 tests OK (241 skipped). phpcs, phpmd and psalm have findings on lines this PR does not touch (inherited). phpcs reports 0 findings on touched lines.npm run lint, run once: 4 errors insrc/store/modules/encryptionSuite.js, which this PR does not touch (inherited).openspec validate --specs --strict: 20 failing specs, the same count as on development. The 9 new specs pass.Follow-ups (not in this PR)
specified, although their changes are archived: vault-25, vault-28, vault-29, vault-31, crypto-13, crypto-20, sharing-26, health-11, health-12, health-15, rotation-08.This PR was prepared with AI assistance (Claude Code).